DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 0/2] buildtools: enable chkincs on Windows
@ 2021-10-01 16:37 Dmitry Kozlyuk
  2021-10-01 16:37 ` [dpdk-dev] [PATCH 1/2] eal/windows: do not install virt2phys header Dmitry Kozlyuk
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Dmitry Kozlyuk @ 2021-10-01 16:37 UTC (permalink / raw)
  To: dev; +Cc: Dmitry Kozlyuk

Dmitry Kozlyuk (2):
  eal/windows: do not install virt2phys header
  buildtools: enable chkincs on Windows

 buildtools/chkincs/meson.build      | 5 -----
 lib/eal/windows/include/meson.build | 1 -
 2 files changed, 6 deletions(-)

-- 
2.29.3


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dpdk-dev] [PATCH 1/2] eal/windows: do not install virt2phys header
  2021-10-01 16:37 [dpdk-dev] [PATCH 0/2] buildtools: enable chkincs on Windows Dmitry Kozlyuk
@ 2021-10-01 16:37 ` Dmitry Kozlyuk
  2021-10-11 19:07   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
  2021-10-01 16:37 ` [dpdk-dev] [PATCH 2/2] buildtools: enable chkincs on Windows Dmitry Kozlyuk
  2021-10-11 19:10 ` [dpdk-dev] [PATCH 0/2] " Thomas Monjalon
  2 siblings, 1 reply; 7+ messages in thread
From: Dmitry Kozlyuk @ 2021-10-01 16:37 UTC (permalink / raw)
  To: dev
  Cc: Dmitry Kozlyuk, stable, Narcisa Ana Maria Vasile, Dmitry Malloy,
	Pallavi Kadam

The header was not intended to be a public one.
DPDK users should use `rte_mem_virt2iova()` to translate addresses.
Other virt2phys users should use the header from the driver instead.

Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management")
Cc: stable@dpdk.org

Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
---
 lib/eal/windows/include/meson.build | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/eal/windows/include/meson.build b/lib/eal/windows/include/meson.build
index b3534b025f..5fb1962ac7 100644
--- a/lib/eal/windows/include/meson.build
+++ b/lib/eal/windows/include/meson.build
@@ -5,6 +5,5 @@ includes += include_directories('.')
 
 headers += files(
         'rte_os.h',
-        'rte_virt2phys.h',
         'rte_windows.h',
 )
-- 
2.29.3


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dpdk-dev] [PATCH 2/2] buildtools: enable chkincs on Windows
  2021-10-01 16:37 [dpdk-dev] [PATCH 0/2] buildtools: enable chkincs on Windows Dmitry Kozlyuk
  2021-10-01 16:37 ` [dpdk-dev] [PATCH 1/2] eal/windows: do not install virt2phys header Dmitry Kozlyuk
@ 2021-10-01 16:37 ` Dmitry Kozlyuk
  2021-10-01 16:39   ` Bruce Richardson
  2021-10-11 19:10 ` [dpdk-dev] [PATCH 0/2] " Thomas Monjalon
  2 siblings, 1 reply; 7+ messages in thread
From: Dmitry Kozlyuk @ 2021-10-01 16:37 UTC (permalink / raw)
  To: dev; +Cc: Dmitry Kozlyuk, bruce.richardson

Independent header compilation test (chkincs) was disabled on Windows.
The comment stated that the shebang line in the generator script was not
working. Meson 0.57.0, currently recommended for Windows, successfully
parses that line and invokes the script. Remove the OS restriction
as its reason no longer applies.

Fixes: 05050ac4ce99 ("build: add header includes check")
Cc: bruce.richardson@intel.com

Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
---
 buildtools/chkincs/meson.build | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/buildtools/chkincs/meson.build b/buildtools/chkincs/meson.build
index 34dcd81ce1..5ffca89761 100644
--- a/buildtools/chkincs/meson.build
+++ b/buildtools/chkincs/meson.build
@@ -6,11 +6,6 @@ if not get_option('check_includes')
     subdir_done()
 endif
 
-if is_windows
-    # for windows, the shebang line in the script won't work.
-    error('option "check_includes" is not supported on windows')
-endif
-
 gen_c_file_for_header = find_program('gen_c_file_for_header.py')
 gen_c_files = generator(gen_c_file_for_header,
         output: '@BASENAME@.c',
-- 
2.29.3


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH 2/2] buildtools: enable chkincs on Windows
  2021-10-01 16:37 ` [dpdk-dev] [PATCH 2/2] buildtools: enable chkincs on Windows Dmitry Kozlyuk
@ 2021-10-01 16:39   ` Bruce Richardson
  0 siblings, 0 replies; 7+ messages in thread
From: Bruce Richardson @ 2021-10-01 16:39 UTC (permalink / raw)
  To: Dmitry Kozlyuk; +Cc: dev

On Fri, Oct 01, 2021 at 07:37:26PM +0300, Dmitry Kozlyuk wrote:
> Independent header compilation test (chkincs) was disabled on Windows.
> The comment stated that the shebang line in the generator script was not
> working. Meson 0.57.0, currently recommended for Windows, successfully
> parses that line and invokes the script. Remove the OS restriction
> as its reason no longer applies.
> 
> Fixes: 05050ac4ce99 ("build: add header includes check")
> Cc: bruce.richardson@intel.com
> 
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] eal/windows: do not install virt2phys header
  2021-10-01 16:37 ` [dpdk-dev] [PATCH 1/2] eal/windows: do not install virt2phys header Dmitry Kozlyuk
@ 2021-10-11 19:07   ` Thomas Monjalon
  2021-10-24 21:58     ` Dmitry Kozlyuk
  0 siblings, 1 reply; 7+ messages in thread
From: Thomas Monjalon @ 2021-10-11 19:07 UTC (permalink / raw)
  To: Dmitry Kozlyuk
  Cc: dev, stable, stable, Narcisa Ana Maria Vasile, Dmitry Malloy,
	Pallavi Kadam

01/10/2021 18:37, Dmitry Kozlyuk:
> The header was not intended to be a public one.
> DPDK users should use `rte_mem_virt2iova()` to translate addresses.
> Other virt2phys users should use the header from the driver instead.
> 
> Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---
>  headers += files(
>          'rte_os.h',
> -        'rte_virt2phys.h',
>          'rte_windows.h',
>  )

We should plan to rename it.
Files starting with rte_ are supposed to be public.



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH 0/2] buildtools: enable chkincs on Windows
  2021-10-01 16:37 [dpdk-dev] [PATCH 0/2] buildtools: enable chkincs on Windows Dmitry Kozlyuk
  2021-10-01 16:37 ` [dpdk-dev] [PATCH 1/2] eal/windows: do not install virt2phys header Dmitry Kozlyuk
  2021-10-01 16:37 ` [dpdk-dev] [PATCH 2/2] buildtools: enable chkincs on Windows Dmitry Kozlyuk
@ 2021-10-11 19:10 ` Thomas Monjalon
  2 siblings, 0 replies; 7+ messages in thread
From: Thomas Monjalon @ 2021-10-11 19:10 UTC (permalink / raw)
  To: Dmitry Kozlyuk; +Cc: dev

01/10/2021 18:37, Dmitry Kozlyuk:
> Dmitry Kozlyuk (2):
>   eal/windows: do not install virt2phys header
>   buildtools: enable chkincs on Windows

Applied, thanks.




^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] eal/windows: do not install virt2phys header
  2021-10-11 19:07   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
@ 2021-10-24 21:58     ` Dmitry Kozlyuk
  0 siblings, 0 replies; 7+ messages in thread
From: Dmitry Kozlyuk @ 2021-10-24 21:58 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev

2021-10-11 21:07 (UTC+0200), Thomas Monjalon:
> 01/10/2021 18:37, Dmitry Kozlyuk:
> > The header was not intended to be a public one.
> > DPDK users should use `rte_mem_virt2iova()` to translate addresses.
> > Other virt2phys users should use the header from the driver instead.
> > 
> > Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > ---
> >  headers += files(
> >          'rte_os.h',
> > -        'rte_virt2phys.h',
> >          'rte_windows.h',
> >  )  
> 
> We should plan to rename it.
> Files starting with rte_ are supposed to be public.

Is "rte_eal_" prefix OK for internal headers, like in "rte_eal_paging.h"?
I want to put NetUIO interface to EAL, but also to use it from bus/pci.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-10-24 21:59 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-01 16:37 [dpdk-dev] [PATCH 0/2] buildtools: enable chkincs on Windows Dmitry Kozlyuk
2021-10-01 16:37 ` [dpdk-dev] [PATCH 1/2] eal/windows: do not install virt2phys header Dmitry Kozlyuk
2021-10-11 19:07   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2021-10-24 21:58     ` Dmitry Kozlyuk
2021-10-01 16:37 ` [dpdk-dev] [PATCH 2/2] buildtools: enable chkincs on Windows Dmitry Kozlyuk
2021-10-01 16:39   ` Bruce Richardson
2021-10-11 19:10 ` [dpdk-dev] [PATCH 0/2] " Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).