* [PATCH v2 2/4] event/sw: report periodic event timer capability
@ 2022-08-10 7:01 Naga Harish K S V
0 siblings, 0 replies; 5+ messages in thread
From: Naga Harish K S V @ 2022-08-10 7:01 UTC (permalink / raw)
To: erik.g.carrillo, jerinj, harry.van.haaren; +Cc: dev
update the software eventdev pmd timer_adapter_caps_get
callback function to report the support of periodic
event timer capability
Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
---
drivers/event/sw/sw_evdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
index f93313b31b..89c07d30ae 100644
--- a/drivers/event/sw/sw_evdev.c
+++ b/drivers/event/sw/sw_evdev.c
@@ -564,7 +564,7 @@ sw_timer_adapter_caps_get(const struct rte_eventdev *dev, uint64_t flags,
{
RTE_SET_USED(dev);
RTE_SET_USED(flags);
- *caps = 0;
+ *caps = RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC;
/* Use default SW ops */
*ops = NULL;
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v2 2/4] event/sw: report periodic event timer capability
2022-08-10 20:52 ` Carrillo, Erik G
2022-08-11 15:33 ` Van Haaren, Harry
@ 2022-08-11 15:44 ` Naga Harish K, S V
1 sibling, 0 replies; 5+ messages in thread
From: Naga Harish K, S V @ 2022-08-11 15:44 UTC (permalink / raw)
To: Carrillo, Erik G, jerinj, Van Haaren, Harry; +Cc: dev
Hi Gabe,
> -----Original Message-----
> From: Carrillo, Erik G <erik.g.carrillo@intel.com>
> Sent: Thursday, August 11, 2022 2:22 AM
> To: Naga Harish K, S V <s.v.naga.harish.k@intel.com>; jerinj@marvell.com;
> Van Haaren, Harry <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v2 2/4] event/sw: report periodic event timer capability
>
> Hi Harish,
>
> > -----Original Message-----
> > From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > Sent: Wednesday, August 10, 2022 2:10 AM
> > To: Carrillo, Erik G <erik.g.carrillo@intel.com>; jerinj@marvell.com;
> > Van Haaren, Harry <harry.van.haaren@intel.com>
> > Cc: dev@dpdk.org
> > Subject: [PATCH v2 2/4] event/sw: report periodic event timer
> > capability
> >
> > update the software eventdev pmd timer_adapter_caps_get callback
> > function to report the support of periodic event timer capability
> >
> > Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> > ---
> > drivers/event/sw/sw_evdev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
> > index f93313b31b..89c07d30ae 100644
> > --- a/drivers/event/sw/sw_evdev.c
> > +++ b/drivers/event/sw/sw_evdev.c
> > @@ -564,7 +564,7 @@ sw_timer_adapter_caps_get(const struct
> > rte_eventdev *dev, uint64_t flags, {
> > RTE_SET_USED(dev);
> > RTE_SET_USED(flags);
> > - *caps = 0;
> > + *caps = RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC;
>
> It looks like we can add:
>
> #define RTE_EVENT_TIMER_ADAPTER_SW_CAP \
> RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC
>
> to eventdev_pmd.h (the same as RTE_EVENT_CRYPTO_ADAPTER_SW_CAP,
> for example),
>
> and use that definition here, and in rte_event_timer_adapter_caps_get().
>
Taken in v3 version of the patch
> Thanks,
> Erik
>
> >
> > /* Use default SW ops */
> > *ops = NULL;
> > --
> > 2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v2 2/4] event/sw: report periodic event timer capability
2022-08-10 20:52 ` Carrillo, Erik G
@ 2022-08-11 15:33 ` Van Haaren, Harry
2022-08-11 15:44 ` Naga Harish K, S V
1 sibling, 0 replies; 5+ messages in thread
From: Van Haaren, Harry @ 2022-08-11 15:33 UTC (permalink / raw)
To: Carrillo, Erik G, Naga Harish K, S V, jerinj; +Cc: dev
> -----Original Message-----
> From: Carrillo, Erik G <erik.g.carrillo@intel.com>
> Sent: Wednesday, August 10, 2022 9:52 PM
> To: Naga Harish K, S V <s.v.naga.harish.k@intel.com>; jerinj@marvell.com; Van
> Haaren, Harry <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v2 2/4] event/sw: report periodic event timer capability
>
> Hi Harish,
>
> > -----Original Message-----
> > From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > Sent: Wednesday, August 10, 2022 2:10 AM
> > To: Carrillo, Erik G <erik.g.carrillo@intel.com>; jerinj@marvell.com; Van
> > Haaren, Harry <harry.van.haaren@intel.com>
> > Cc: dev@dpdk.org
> > Subject: [PATCH v2 2/4] event/sw: report periodic event timer capability
> >
> > update the software eventdev pmd timer_adapter_caps_get callback
> > function to report the support of periodic event timer capability
> >
> > Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> > ---
> > drivers/event/sw/sw_evdev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
> > index f93313b31b..89c07d30ae 100644
> > --- a/drivers/event/sw/sw_evdev.c
> > +++ b/drivers/event/sw/sw_evdev.c
> > @@ -564,7 +564,7 @@ sw_timer_adapter_caps_get(const struct
> > rte_eventdev *dev, uint64_t flags, {
> > RTE_SET_USED(dev);
> > RTE_SET_USED(flags);
> > - *caps = 0;
> > + *caps = RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC;
Thanks Harish for the explanation as to why caps are exposed in the Eventdev PMD,
for related timer/etc features, makes sense.
> It looks like we can add:
>
> #define RTE_EVENT_TIMER_ADAPTER_SW_CAP \
> RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC
>
> to eventdev_pmd.h (the same as RTE_EVENT_CRYPTO_ADAPTER_SW_CAP, for
> example),
>
> and use that definition here, and in rte_event_timer_adapter_caps_get().
>
> Thanks,
> Erik
Erik, I like the suggestion of a standardized set of "generic SW" caps flags at the Eventdev level,
and then all SW based PMDs can use that #define, avoids each new cap needing changes in multiple drivers.
Good work, -Harry
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v2 2/4] event/sw: report periodic event timer capability
2022-08-10 7:09 ` [PATCH v2 " Naga Harish K S V
@ 2022-08-10 20:52 ` Carrillo, Erik G
2022-08-11 15:33 ` Van Haaren, Harry
2022-08-11 15:44 ` Naga Harish K, S V
0 siblings, 2 replies; 5+ messages in thread
From: Carrillo, Erik G @ 2022-08-10 20:52 UTC (permalink / raw)
To: Naga Harish K, S V, jerinj, Van Haaren, Harry; +Cc: dev
Hi Harish,
> -----Original Message-----
> From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Sent: Wednesday, August 10, 2022 2:10 AM
> To: Carrillo, Erik G <erik.g.carrillo@intel.com>; jerinj@marvell.com; Van
> Haaren, Harry <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org
> Subject: [PATCH v2 2/4] event/sw: report periodic event timer capability
>
> update the software eventdev pmd timer_adapter_caps_get callback
> function to report the support of periodic event timer capability
>
> Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> ---
> drivers/event/sw/sw_evdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
> index f93313b31b..89c07d30ae 100644
> --- a/drivers/event/sw/sw_evdev.c
> +++ b/drivers/event/sw/sw_evdev.c
> @@ -564,7 +564,7 @@ sw_timer_adapter_caps_get(const struct
> rte_eventdev *dev, uint64_t flags, {
> RTE_SET_USED(dev);
> RTE_SET_USED(flags);
> - *caps = 0;
> + *caps = RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC;
It looks like we can add:
#define RTE_EVENT_TIMER_ADAPTER_SW_CAP \
RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC
to eventdev_pmd.h (the same as RTE_EVENT_CRYPTO_ADAPTER_SW_CAP, for example),
and use that definition here, and in rte_event_timer_adapter_caps_get().
Thanks,
Erik
>
> /* Use default SW ops */
> *ops = NULL;
> --
> 2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 2/4] event/sw: report periodic event timer capability
2022-08-03 16:26 [PATCH " Naga Harish K S V
@ 2022-08-10 7:09 ` Naga Harish K S V
2022-08-10 20:52 ` Carrillo, Erik G
0 siblings, 1 reply; 5+ messages in thread
From: Naga Harish K S V @ 2022-08-10 7:09 UTC (permalink / raw)
To: erik.g.carrillo, jerinj, harry.van.haaren; +Cc: dev
update the software eventdev pmd timer_adapter_caps_get
callback function to report the support of periodic
event timer capability
Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
---
drivers/event/sw/sw_evdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
index f93313b31b..89c07d30ae 100644
--- a/drivers/event/sw/sw_evdev.c
+++ b/drivers/event/sw/sw_evdev.c
@@ -564,7 +564,7 @@ sw_timer_adapter_caps_get(const struct rte_eventdev *dev, uint64_t flags,
{
RTE_SET_USED(dev);
RTE_SET_USED(flags);
- *caps = 0;
+ *caps = RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC;
/* Use default SW ops */
*ops = NULL;
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-08-11 15:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-10 7:01 [PATCH v2 2/4] event/sw: report periodic event timer capability Naga Harish K S V
-- strict thread matches above, loose matches on Subject: below --
2022-08-03 16:26 [PATCH " Naga Harish K S V
2022-08-10 7:09 ` [PATCH v2 " Naga Harish K S V
2022-08-10 20:52 ` Carrillo, Erik G
2022-08-11 15:33 ` Van Haaren, Harry
2022-08-11 15:44 ` Naga Harish K, S V
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).