DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] rcu: fix build failure with debug dp log level
@ 2022-08-29 16:51 Anoob Joseph
  2022-08-29 16:55 ` Honnappa Nagarahalli
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Anoob Joseph @ 2022-08-29 16:51 UTC (permalink / raw)
  To: Honnappa Nagarahalli; +Cc: Jerin Jacob, dev, sean.morrissey

Build fails if RTE_LOG_DP_LEVEL is set to RTE_LOG_DEBUG. Fix the
same by including the required header when RTE_LOG_DP_LEVEL is
set to RTE_LOG_DEBUG.

../lib/rcu/rte_rcu_qsbr.h:678:40: error: expected ‘)’ before ‘PRIu64’
  678 |    "%s: status: least acked token = %" PRIu64,
      |                                        ^~~~~~

Fixes: 30a1de105a5f ("lib: remove unneeded header includes")
Cc: sean.morrissey@intel.com

Signed-off-by: Anoob Joseph <anoobj@marvell.com>
---
 lib/rcu/rte_rcu_qsbr.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h
index d81bf5e8db..b0f1720ca1 100644
--- a/lib/rcu/rte_rcu_qsbr.h
+++ b/lib/rcu/rte_rcu_qsbr.h
@@ -37,6 +37,10 @@ extern "C" {
 #include <rte_atomic.h>
 #include <rte_ring.h>

+#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
+#include <inttypes.h>
+#endif
+
 extern int rte_rcu_log_type;

 #if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
--
2.25.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: [PATCH] rcu: fix build failure with debug dp log level
  2022-08-29 16:51 [PATCH] rcu: fix build failure with debug dp log level Anoob Joseph
@ 2022-08-29 16:55 ` Honnappa Nagarahalli
  2022-08-30  8:38   ` Morrissey, Sean
  2022-09-28 22:21 ` Stephen Hemminger
  2022-09-29 10:27 ` [PATCH v2] " Anoob Joseph
  2 siblings, 1 reply; 10+ messages in thread
From: Honnappa Nagarahalli @ 2022-08-29 16:55 UTC (permalink / raw)
  To: Anoob Joseph, sean.morrissey; +Cc: jerinj, dev, nd, nd



> -----Original Message-----
> From: Anoob Joseph <anoobj@marvell.com>
> Sent: Monday, August 29, 2022 11:52 AM
> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Cc: jerinj@marvell.com; dev@dpdk.org; sean.morrissey@intel.com
> Subject: [PATCH] rcu: fix build failure with debug dp log level
> 
> Build fails if RTE_LOG_DP_LEVEL is set to RTE_LOG_DEBUG. Fix the same by
> including the required header when RTE_LOG_DP_LEVEL is set to
> RTE_LOG_DEBUG.
> 
> ../lib/rcu/rte_rcu_qsbr.h:678:40: error: expected ‘)’ before ‘PRIu64’
>   678 |    "%s: status: least acked token = %" PRIu64,
>       |                                        ^~~~~~
> 
> Fixes: 30a1de105a5f ("lib: remove unneeded header includes")
> Cc: sean.morrissey@intel.com
Agree on the fix.
@sean.morrissey@intel.com Does the process that removed this header file inclusion needs fixing?
If yes, should that fix be included in this patch?

> 
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> ---
>  lib/rcu/rte_rcu_qsbr.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h index
> d81bf5e8db..b0f1720ca1 100644
> --- a/lib/rcu/rte_rcu_qsbr.h
> +++ b/lib/rcu/rte_rcu_qsbr.h
> @@ -37,6 +37,10 @@ extern "C" {
>  #include <rte_atomic.h>
>  #include <rte_ring.h>
> 
> +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
> +#include <inttypes.h>
> +#endif
> +
>  extern int rte_rcu_log_type;
> 
>  #if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
> --
> 2.25.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] rcu: fix build failure with debug dp log level
  2022-08-29 16:55 ` Honnappa Nagarahalli
@ 2022-08-30  8:38   ` Morrissey, Sean
  2022-08-30 13:17     ` Honnappa Nagarahalli
  0 siblings, 1 reply; 10+ messages in thread
From: Morrissey, Sean @ 2022-08-30  8:38 UTC (permalink / raw)
  To: Honnappa Nagarahalli, Anoob Joseph; +Cc: jerinj, dev, nd


On 29/08/2022 17:55, Honnappa Nagarahalli wrote:
>> -----Original Message-----
>> From: Anoob Joseph <anoobj@marvell.com>
>> Sent: Monday, August 29, 2022 11:52 AM
>> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
>> Cc: jerinj@marvell.com; dev@dpdk.org; sean.morrissey@intel.com
>> Subject: [PATCH] rcu: fix build failure with debug dp log level
>>
>> Build fails if RTE_LOG_DP_LEVEL is set to RTE_LOG_DEBUG. Fix the same by
>> including the required header when RTE_LOG_DP_LEVEL is set to
>> RTE_LOG_DEBUG.
>>
>> ../lib/rcu/rte_rcu_qsbr.h:678:40: error: expected ‘)’ before ‘PRIu64’
>>    678 |    "%s: status: least acked token = %" PRIu64,
>>        |                                        ^~~~~~
>>
>> Fixes: 30a1de105a5f ("lib: remove unneeded header includes")
>> Cc: sean.morrissey@intel.com
> Agree on the fix.
> @sean.morrissey@intel.com Does the process that removed this header file inclusion needs fixing?
> If yes, should that fix be included in this patch?

@Honnappa.Nagarahalli@arm.com Yes, I believe the tool will need an 
update, however, I believe it should be a separate patch for that.

>> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
>> ---
>>   lib/rcu/rte_rcu_qsbr.h | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h index
>> d81bf5e8db..b0f1720ca1 100644
>> --- a/lib/rcu/rte_rcu_qsbr.h
>> +++ b/lib/rcu/rte_rcu_qsbr.h
>> @@ -37,6 +37,10 @@ extern "C" {
>>   #include <rte_atomic.h>
>>   #include <rte_ring.h>
>>
>> +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
>> +#include <inttypes.h>
>> +#endif
>> +
>>   extern int rte_rcu_log_type;
>>
>>   #if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
>> --
>> 2.25.1

^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: [PATCH] rcu: fix build failure with debug dp log level
  2022-08-30  8:38   ` Morrissey, Sean
@ 2022-08-30 13:17     ` Honnappa Nagarahalli
  2022-09-28 22:04       ` Honnappa Nagarahalli
  0 siblings, 1 reply; 10+ messages in thread
From: Honnappa Nagarahalli @ 2022-08-30 13:17 UTC (permalink / raw)
  To: Morrissey, Sean, Anoob Joseph; +Cc: jerinj, dev, nd, nd

<snip>

> >>
> >> Build fails if RTE_LOG_DP_LEVEL is set to RTE_LOG_DEBUG. Fix the same
> >> by including the required header when RTE_LOG_DP_LEVEL is set to
> >> RTE_LOG_DEBUG.
> >>
> >> ../lib/rcu/rte_rcu_qsbr.h:678:40: error: expected ‘)’ before ‘PRIu64’
> >>    678 |    "%s: status: least acked token = %" PRIu64,
> >>        |                                        ^~~~~~
> >>
> >> Fixes: 30a1de105a5f ("lib: remove unneeded header includes")
> >> Cc: sean.morrissey@intel.com
> > Agree on the fix.
> > @sean.morrissey@intel.com Does the process that removed this header file
> inclusion needs fixing?
> > If yes, should that fix be included in this patch?
> 
> @Honnappa.Nagarahalli@arm.com Yes, I believe the tool will need an
> update, however, I believe it should be a separate patch for that.
Ok, as long as it is addressed, it should be fine.
 
> 
> >> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> >> ---
> >>   lib/rcu/rte_rcu_qsbr.h | 4 ++++
> >>   1 file changed, 4 insertions(+)
> >>
> >> diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h index
> >> d81bf5e8db..b0f1720ca1 100644
> >> --- a/lib/rcu/rte_rcu_qsbr.h
> >> +++ b/lib/rcu/rte_rcu_qsbr.h
> >> @@ -37,6 +37,10 @@ extern "C" {
> >>   #include <rte_atomic.h>
> >>   #include <rte_ring.h>
> >>
> >> +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG #include <inttypes.h> #endif
> >> +
> >>   extern int rte_rcu_log_type;
> >>
> >>   #if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
> >> --
> >> 2.25.1

^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: [PATCH] rcu: fix build failure with debug dp log level
  2022-08-30 13:17     ` Honnappa Nagarahalli
@ 2022-09-28 22:04       ` Honnappa Nagarahalli
  0 siblings, 0 replies; 10+ messages in thread
From: Honnappa Nagarahalli @ 2022-09-28 22:04 UTC (permalink / raw)
  To: Morrissey, Sean, Anoob Joseph; +Cc: jerinj, dev, nd, nd

<snip>
> 
> > >>
> > >> Build fails if RTE_LOG_DP_LEVEL is set to RTE_LOG_DEBUG. Fix the
> > >> same by including the required header when RTE_LOG_DP_LEVEL is set
> > >> to RTE_LOG_DEBUG.
> > >>
> > >> ../lib/rcu/rte_rcu_qsbr.h:678:40: error: expected ‘)’ before ‘PRIu64’
> > >>    678 |    "%s: status: least acked token = %" PRIu64,
> > >>        |                                        ^~~~~~
> > >>
> > >> Fixes: 30a1de105a5f ("lib: remove unneeded header includes")
> > >> Cc: sean.morrissey@intel.com
> > > Agree on the fix.
> > > @sean.morrissey@intel.com Does the process that removed this header
> > > file
> > inclusion needs fixing?
> > > If yes, should that fix be included in this patch?
> >
> > @Honnappa.Nagarahalli@arm.com Yes, I believe the tool will need an
> > update, however, I believe it should be a separate patch for that.
> Ok, as long as it is addressed, it should be fine.
> 
> >
> > >> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

> > >> ---
> > >>   lib/rcu/rte_rcu_qsbr.h | 4 ++++
> > >>   1 file changed, 4 insertions(+)
> > >>
> > >> diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h index
> > >> d81bf5e8db..b0f1720ca1 100644
> > >> --- a/lib/rcu/rte_rcu_qsbr.h
> > >> +++ b/lib/rcu/rte_rcu_qsbr.h
> > >> @@ -37,6 +37,10 @@ extern "C" {
> > >>   #include <rte_atomic.h>
> > >>   #include <rte_ring.h>
> > >>
> > >> +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG #include <inttypes.h>
> #endif
> > >> +
> > >>   extern int rte_rcu_log_type;
> > >>
> > >>   #if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
> > >> --
> > >> 2.25.1

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] rcu: fix build failure with debug dp log level
  2022-08-29 16:51 [PATCH] rcu: fix build failure with debug dp log level Anoob Joseph
  2022-08-29 16:55 ` Honnappa Nagarahalli
@ 2022-09-28 22:21 ` Stephen Hemminger
  2022-09-29  3:25   ` [EXT] " Anoob Joseph
  2022-09-29 10:27 ` [PATCH v2] " Anoob Joseph
  2 siblings, 1 reply; 10+ messages in thread
From: Stephen Hemminger @ 2022-09-28 22:21 UTC (permalink / raw)
  To: Anoob Joseph; +Cc: Honnappa Nagarahalli, Jerin Jacob, dev, sean.morrissey

On Mon, 29 Aug 2022 22:21:51 +0530
Anoob Joseph <anoobj@marvell.com> wrote:

> Build fails if RTE_LOG_DP_LEVEL is set to RTE_LOG_DEBUG. Fix the
> same by including the required header when RTE_LOG_DP_LEVEL is
> set to RTE_LOG_DEBUG.
> 
> ../lib/rcu/rte_rcu_qsbr.h:678:40: error: expected ‘)’ before ‘PRIu64’
>   678 |    "%s: status: least acked token = %" PRIu64,
>       |                                        ^~~~~~
> 
> Fixes: 30a1de105a5f ("lib: remove unneeded header includes")
> Cc: sean.morrissey@intel.com
> 
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> ---
>  lib/rcu/rte_rcu_qsbr.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h
> index d81bf5e8db..b0f1720ca1 100644
> --- a/lib/rcu/rte_rcu_qsbr.h
> +++ b/lib/rcu/rte_rcu_qsbr.h
> @@ -37,6 +37,10 @@ extern "C" {
>  #include <rte_atomic.h>
>  #include <rte_ring.h>
> 
> +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
> +#include <inttypes.h>
> +#endif
> +
>  extern int rt

This is not the best way to fix this.
Just always include the header file.
Having it conditional can lead to more problems

^ permalink raw reply	[flat|nested] 10+ messages in thread

* RE: [EXT] Re: [PATCH] rcu: fix build failure with debug dp log level
  2022-09-28 22:21 ` Stephen Hemminger
@ 2022-09-29  3:25   ` Anoob Joseph
  2022-09-29  8:27     ` Bruce Richardson
  0 siblings, 1 reply; 10+ messages in thread
From: Anoob Joseph @ 2022-09-29  3:25 UTC (permalink / raw)
  To: Stephen Hemminger
  Cc: Honnappa Nagarahalli, Jerin Jacob Kollanukkaran, dev, sean.morrissey

Hi Stephen,

Please see inline.

Thanks,
Anoob

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Thursday, September 29, 2022 3:51 AM
> To: Anoob Joseph <anoobj@marvell.com>
> Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>; Jerin Jacob
> Kollanukkaran <jerinj@marvell.com>; dev@dpdk.org;
> sean.morrissey@intel.com
> Subject: [EXT] Re: [PATCH] rcu: fix build failure with debug dp log level
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Mon, 29 Aug 2022 22:21:51 +0530
> Anoob Joseph <anoobj@marvell.com> wrote:
> 
> > Build fails if RTE_LOG_DP_LEVEL is set to RTE_LOG_DEBUG. Fix the same
> > by including the required header when RTE_LOG_DP_LEVEL is set to
> > RTE_LOG_DEBUG.
> >
> > ../lib/rcu/rte_rcu_qsbr.h:678:40: error: expected ‘)’ before ‘PRIu64’
> >   678 |    "%s: status: least acked token = %" PRIu64,
> >       |                                        ^~~~~~
> >
> > Fixes: 30a1de105a5f ("lib: remove unneeded header includes")
> > Cc: sean.morrissey@intel.com
> >
> > Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> > ---
> >  lib/rcu/rte_rcu_qsbr.h | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h index
> > d81bf5e8db..b0f1720ca1 100644
> > --- a/lib/rcu/rte_rcu_qsbr.h
> > +++ b/lib/rcu/rte_rcu_qsbr.h
> > @@ -37,6 +37,10 @@ extern "C" {
> >  #include <rte_atomic.h>
> >  #include <rte_ring.h>
> >
> > +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG #include <inttypes.h>
> #endif
> > +
> >  extern int rt
> 
> This is not the best way to fix this.
> Just always include the header file.
> Having it conditional can lead to more problems

[Anoob] The header include is only required when RTE_LOG_DP_LEVEL is lower than RTE_LOG_DEBUG. I'm not sure how the tool runs, but it may still flag this include as an unnecessary include. But I can make the change if the tool can ignore this case.

@Sean, do you agree with the suggestion?

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [EXT] Re: [PATCH] rcu: fix build failure with debug dp log level
  2022-09-29  3:25   ` [EXT] " Anoob Joseph
@ 2022-09-29  8:27     ` Bruce Richardson
  0 siblings, 0 replies; 10+ messages in thread
From: Bruce Richardson @ 2022-09-29  8:27 UTC (permalink / raw)
  To: Anoob Joseph
  Cc: Stephen Hemminger, Honnappa Nagarahalli, Jerin Jacob Kollanukkaran, dev

On Thu, Sep 29, 2022 at 03:25:44AM +0000, Anoob Joseph wrote:
> Hi Stephen,
> 
> Please see inline.
> 
> Thanks,
> Anoob
> 
> > -----Original Message-----
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > Sent: Thursday, September 29, 2022 3:51 AM
> > To: Anoob Joseph <anoobj@marvell.com>
> > Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>; Jerin Jacob
> > Kollanukkaran <jerinj@marvell.com>; dev@dpdk.org;
> > sean.morrissey@intel.com
> > Subject: [EXT] Re: [PATCH] rcu: fix build failure with debug dp log level
> > 
> > External Email
> > 
> > ----------------------------------------------------------------------
> > On Mon, 29 Aug 2022 22:21:51 +0530
> > Anoob Joseph <anoobj@marvell.com> wrote:
> > 
> > > Build fails if RTE_LOG_DP_LEVEL is set to RTE_LOG_DEBUG. Fix the same
> > > by including the required header when RTE_LOG_DP_LEVEL is set to
> > > RTE_LOG_DEBUG.
> > >
> > > ../lib/rcu/rte_rcu_qsbr.h:678:40: error: expected ‘)’ before ‘PRIu64’
> > >   678 |    "%s: status: least acked token = %" PRIu64,
> > >       |                                        ^~~~~~
> > >
> > > Fixes: 30a1de105a5f ("lib: remove unneeded header includes")
> > > Cc: sean.morrissey@intel.com
> > >
> > > Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> > > ---
> > >  lib/rcu/rte_rcu_qsbr.h | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h index
> > > d81bf5e8db..b0f1720ca1 100644
> > > --- a/lib/rcu/rte_rcu_qsbr.h
> > > +++ b/lib/rcu/rte_rcu_qsbr.h
> > > @@ -37,6 +37,10 @@ extern "C" {
> > >  #include <rte_atomic.h>
> > >  #include <rte_ring.h>
> > >
> > > +#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG #include <inttypes.h>
> > #endif
> > > +
> > >  extern int rt
> > 
> > This is not the best way to fix this.
> > Just always include the header file.
> > Having it conditional can lead to more problems
> 
> [Anoob] The header include is only required when RTE_LOG_DP_LEVEL is lower than RTE_LOG_DEBUG. I'm not sure how the tool runs, but it may still flag this include as an unnecessary include. But I can make the change if the tool can ignore this case.
>

I think the number of build configurations needing testing has made the
automatic removal of header includes too problematic to use further.
Therefore, I think either way - with or without the #if - is probably fine.

/Bruce 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2] rcu: fix build failure with debug dp log level
  2022-08-29 16:51 [PATCH] rcu: fix build failure with debug dp log level Anoob Joseph
  2022-08-29 16:55 ` Honnappa Nagarahalli
  2022-09-28 22:21 ` Stephen Hemminger
@ 2022-09-29 10:27 ` Anoob Joseph
  2022-10-06 10:40   ` Thomas Monjalon
  2 siblings, 1 reply; 10+ messages in thread
From: Anoob Joseph @ 2022-09-29 10:27 UTC (permalink / raw)
  To: Honnappa Nagarahalli
  Cc: Stephen Hemminger, Bruce Richardson, Jerin Jacob,
	Thomas Monjalon, dev, sean.morrissey

Build fails if RTE_LOG_DP_LEVEL is set to RTE_LOG_DEBUG. Fix the
same by including the required header.

../lib/rcu/rte_rcu_qsbr.h:678:40: error: expected ‘)’ before ‘PRIu64’
  678 |    "%s: status: least acked token = %" PRIu64,
      |                                        ^~~~~~

Fixes: 30a1de105a5f ("lib: remove unneeded header includes")
Cc: sean.morrissey@intel.com

Signed-off-by: Anoob Joseph <anoobj@marvell.com>
---
 lib/rcu/rte_rcu_qsbr.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h
index d81bf5e8db..36571c15df 100644
--- a/lib/rcu/rte_rcu_qsbr.h
+++ b/lib/rcu/rte_rcu_qsbr.h
@@ -29,6 +29,7 @@
 extern "C" {
 #endif

+#include <inttypes.h>
 #include <stdbool.h>
 #include <stdio.h>
 #include <stdint.h>
--
2.25.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] rcu: fix build failure with debug dp log level
  2022-09-29 10:27 ` [PATCH v2] " Anoob Joseph
@ 2022-10-06 10:40   ` Thomas Monjalon
  0 siblings, 0 replies; 10+ messages in thread
From: Thomas Monjalon @ 2022-10-06 10:40 UTC (permalink / raw)
  To: Anoob Joseph
  Cc: Honnappa Nagarahalli, dev, Stephen Hemminger, Bruce Richardson,
	Jerin Jacob, dev, sean.morrissey

29/09/2022 12:27, Anoob Joseph:
> Build fails if RTE_LOG_DP_LEVEL is set to RTE_LOG_DEBUG. Fix the
> same by including the required header.
> 
> ../lib/rcu/rte_rcu_qsbr.h:678:40: error: expected ‘)’ before ‘PRIu64’
>   678 |    "%s: status: least acked token = %" PRIu64,
>       |                                        ^~~~~~
> 
> Fixes: 30a1de105a5f ("lib: remove unneeded header includes")
> Cc: sean.morrissey@intel.com
> 
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>

Applied, thanks.

Would be good to avoid the tool doing the same mistake again.




^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2022-10-06 10:40 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-29 16:51 [PATCH] rcu: fix build failure with debug dp log level Anoob Joseph
2022-08-29 16:55 ` Honnappa Nagarahalli
2022-08-30  8:38   ` Morrissey, Sean
2022-08-30 13:17     ` Honnappa Nagarahalli
2022-09-28 22:04       ` Honnappa Nagarahalli
2022-09-28 22:21 ` Stephen Hemminger
2022-09-29  3:25   ` [EXT] " Anoob Joseph
2022-09-29  8:27     ` Bruce Richardson
2022-09-29 10:27 ` [PATCH v2] " Anoob Joseph
2022-10-06 10:40   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).