[PATCH 1/2] test/crypto-perf: fix number of sessions for cores

[PATCH 1/2] test/crypto-perf: fix number of sessions for cores

[Ciara Power]

Currently the performance application creates a device session per lcore.
This was not reflected in how many session objects were available
in the mempool, when using a scheduler device.

The number of lcores is now taken into consideration when calculating
how many sessions are needed for the scheduler.

Fixes: 09fcf99dcad2 ("test/crypto-perf: fix number of scheduler sessions")

Reported-by: Kevin O'Sullivan <kevin.osullivan@intel.com>
Signed-off-by: Ciara Power <ciara.power@intel.com>
---
 app/test-crypto-perf/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c
index 0fe47c6caa..22f6b2b3ba 100644
--- a/app/test-crypto-perf/main.c
+++ b/app/test-crypto-perf/main.c
@@ -269,8 +269,8 @@ cperf_initialize_cryptodev(struct cperf_options *opts, uint8_t *enabled_cdevs)
 			uint32_t nb_slaves =
 				rte_cryptodev_scheduler_workers_get(cdev_id,
 								NULL);
-			/* scheduler session header + 1 session per worker qp */
-			sessions_needed = 1 + enabled_cdev_count *
+			/* scheduler session header per lcore + 1 session per worker qp */
+			sessions_needed = nb_lcores + enabled_cdev_count *
 				opts->nb_qps * nb_slaves;
 #endif
 		} else
-- 
2.34.1

[PATCH 2/2] test/crypto-perf: replace slave with worker

[Ciara Power]

Update the use of outdated language "slaves" with "workers".

Signed-off-by: Ciara Power <ciara.power@intel.com>
---
 app/test-crypto-perf/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c
index 22f6b2b3ba..af5bd0d23b 100644
--- a/app/test-crypto-perf/main.c
+++ b/app/test-crypto-perf/main.c
@@ -266,12 +266,12 @@ cperf_initialize_cryptodev(struct cperf_options *opts, uint8_t *enabled_cdevs)
 		if (!strcmp((const char *)opts->device_type,
 					"crypto_scheduler")) {
 #ifdef RTE_CRYPTO_SCHEDULER
-			uint32_t nb_slaves =
+			uint32_t nb_workers =
 				rte_cryptodev_scheduler_workers_get(cdev_id,
 								NULL);
 			/* scheduler session header per lcore + 1 session per worker qp */
 			sessions_needed = nb_lcores + enabled_cdev_count *
-				opts->nb_qps * nb_slaves;
+				opts->nb_qps * nb_workers;
 #endif
 		} else
 			sessions_needed = enabled_cdev_count * opts->nb_qps;
-- 
2.34.1

RE: [EXT] [PATCH 1/2] test/crypto-perf: fix number of sessions for cores

[Akhil Goyal]

> Currently the performance application creates a device session per lcore.
> This was not reflected in how many session objects were available
> in the mempool, when using a scheduler device.
> 
> The number of lcores is now taken into consideration when calculating
> how many sessions are needed for the scheduler.
> 
> Fixes: 09fcf99dcad2 ("test/crypto-perf: fix number of scheduler sessions")
> 
> Reported-by: Kevin O'Sullivan <kevin.osullivan@intel.com>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
Series applied to dpdk-next-crypto

Thanks.