* [PATCH] hash: remove return statement from function returning void
@ 2024-03-08 21:20 Tyler Retzlaff
2024-03-14 15:58 ` David Marchand
2024-04-04 18:19 ` Tyler Retzlaff
0 siblings, 2 replies; 4+ messages in thread
From: Tyler Retzlaff @ 2024-03-08 21:20 UTC (permalink / raw)
To: dev
Cc: Bruce Richardson, Sameh Gobriel, Stephen Hemminger,
Vladimir Medvedkin, Yipeng Wang, david.marchand, Tyler Retzlaff
rte_thash_gfni_bulk and rte_thash_gfni_bulk_stub both return void.
Remove superfluous return statement from rte_thash_gfni_bulk.
Fixes: 944a03a5cfc1 ("hash: fix MSVC link on GFNI stubs")
Cc: stephen@networkplumber.org
Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
---
lib/hash/rte_thash_gfni.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/hash/rte_thash_gfni.h b/lib/hash/rte_thash_gfni.h
index edae2e8..132f375 100644
--- a/lib/hash/rte_thash_gfni.h
+++ b/lib/hash/rte_thash_gfni.h
@@ -71,7 +71,7 @@
rte_thash_gfni_bulk(const uint64_t *mtrx, int len, uint8_t *tuple[],
uint32_t val[], uint32_t num)
{
- return rte_thash_gfni_bulk_stub(mtrx, len, tuple, val, num);
+ rte_thash_gfni_bulk_stub(mtrx, len, tuple, val, num);
}
#endif /* RTE_THASH_GFNI_DEFINED */
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hash: remove return statement from function returning void
2024-03-08 21:20 [PATCH] hash: remove return statement from function returning void Tyler Retzlaff
@ 2024-03-14 15:58 ` David Marchand
2024-03-14 16:30 ` Tyler Retzlaff
2024-04-04 18:19 ` Tyler Retzlaff
1 sibling, 1 reply; 4+ messages in thread
From: David Marchand @ 2024-03-14 15:58 UTC (permalink / raw)
To: Tyler Retzlaff
Cc: dev, Bruce Richardson, Sameh Gobriel, Stephen Hemminger,
Vladimir Medvedkin, Yipeng Wang
Hello Tyler,
On Fri, Mar 8, 2024 at 10:20 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
>
> rte_thash_gfni_bulk and rte_thash_gfni_bulk_stub both return void.
> Remove superfluous return statement from rte_thash_gfni_bulk.
>
> Fixes: 944a03a5cfc1 ("hash: fix MSVC link on GFNI stubs")
> Cc: stephen@networkplumber.org
>
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---
> lib/hash/rte_thash_gfni.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/hash/rte_thash_gfni.h b/lib/hash/rte_thash_gfni.h
> index edae2e8..132f375 100644
> --- a/lib/hash/rte_thash_gfni.h
> +++ b/lib/hash/rte_thash_gfni.h
> @@ -71,7 +71,7 @@
> rte_thash_gfni_bulk(const uint64_t *mtrx, int len, uint8_t *tuple[],
> uint32_t val[], uint32_t num)
> {
> - return rte_thash_gfni_bulk_stub(mtrx, len, tuple, val, num);
> + rte_thash_gfni_bulk_stub(mtrx, len, tuple, val, num);
> }
I am surprised the CI did not catch it.
I need to pass -pedantic when compiling with this header, but no code
does this in-tree.
How did you catch this issue?
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hash: remove return statement from function returning void
2024-03-14 15:58 ` David Marchand
@ 2024-03-14 16:30 ` Tyler Retzlaff
0 siblings, 0 replies; 4+ messages in thread
From: Tyler Retzlaff @ 2024-03-14 16:30 UTC (permalink / raw)
To: David Marchand
Cc: dev, Bruce Richardson, Sameh Gobriel, Stephen Hemminger,
Vladimir Medvedkin, Yipeng Wang
On Thu, Mar 14, 2024 at 04:58:54PM +0100, David Marchand wrote:
> Hello Tyler,
>
> On Fri, Mar 8, 2024 at 10:20 PM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
> >
> > rte_thash_gfni_bulk and rte_thash_gfni_bulk_stub both return void.
> > Remove superfluous return statement from rte_thash_gfni_bulk.
> >
> > Fixes: 944a03a5cfc1 ("hash: fix MSVC link on GFNI stubs")
> > Cc: stephen@networkplumber.org
> >
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > ---
> > lib/hash/rte_thash_gfni.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/hash/rte_thash_gfni.h b/lib/hash/rte_thash_gfni.h
> > index edae2e8..132f375 100644
> > --- a/lib/hash/rte_thash_gfni.h
> > +++ b/lib/hash/rte_thash_gfni.h
> > @@ -71,7 +71,7 @@
> > rte_thash_gfni_bulk(const uint64_t *mtrx, int len, uint8_t *tuple[],
> > uint32_t val[], uint32_t num)
> > {
> > - return rte_thash_gfni_bulk_stub(mtrx, len, tuple, val, num);
> > + rte_thash_gfni_bulk_stub(mtrx, len, tuple, val, num);
> > }
>
> I am surprised the CI did not catch it.
> I need to pass -pedantic when compiling with this header, but no code
> does this in-tree.
> How did you catch this issue?
MSVC warns about it (and hundreds of other things). Benefits of compiling the
same code with a compiler not sharing the same lineage.
>
>
> --
> David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hash: remove return statement from function returning void
2024-03-08 21:20 [PATCH] hash: remove return statement from function returning void Tyler Retzlaff
2024-03-14 15:58 ` David Marchand
@ 2024-04-04 18:19 ` Tyler Retzlaff
1 sibling, 0 replies; 4+ messages in thread
From: Tyler Retzlaff @ 2024-04-04 18:19 UTC (permalink / raw)
To: dev
Recheck-request: iol-unit-amd64-testing
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-04 18:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-08 21:20 [PATCH] hash: remove return statement from function returning void Tyler Retzlaff
2024-03-14 15:58 ` David Marchand
2024-03-14 16:30 ` Tyler Retzlaff
2024-04-04 18:19 ` Tyler Retzlaff
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).