DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 1/1] doc: fix build
@ 2021-01-26 15:07 Thomas Monjalon
  2021-01-26 15:32 ` Bruce Richardson
  2021-01-26 15:32 ` David Marchand
  0 siblings, 2 replies; 6+ messages in thread
From: Thomas Monjalon @ 2021-01-26 15:07 UTC (permalink / raw)
  To: dev; +Cc: Ruifeng Wang, Juraj Linkeš

When removing the label "arm_cross_build_getting_the_prerequisite_library"
in the rework of cross_build_dpdk_for_arm64.rst,
the reference to this section got broken.
It went unnoticed because "ninja -C doc" does not regenerate the file
which is referencing the changed file.

Fixes: eb0e12c0c299 ("doc: add clang to aarch64 cross build guide")

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 doc/guides/platform/bluefield.rst | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/doc/guides/platform/bluefield.rst b/doc/guides/platform/bluefield.rst
index 824f2bde64..635e414600 100644
--- a/doc/guides/platform/bluefield.rst
+++ b/doc/guides/platform/bluefield.rst
@@ -77,12 +77,11 @@ required:
    - libnl-3
    - libnl-route-3
 
-Such header files and libraries can be cross-compiled and installed on to the
-cross toolchain directory like depicted in
-:ref:`arm_cross_build_getting_the_prerequisite_library`, but those can also be
-simply copied from the filesystem of a working BlueField platform. The following
-script can be run on a BlueField platform in order to create a supplementary
-tarball for the cross toolchain.
+Such header files and libraries can be cross-compiled and installed
+in the cross toolchain environment.
+They can also be simply copied from the filesystem of a working BlueField platform.
+The following script can be run on a BlueField platform in order to create
+a supplementary tarball for the cross toolchain.
 
 .. code-block:: console
 
-- 
2.30.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH 1/1] doc: fix build
  2021-01-26 15:07 [dpdk-dev] [PATCH 1/1] doc: fix build Thomas Monjalon
@ 2021-01-26 15:32 ` Bruce Richardson
  2021-01-26 15:35   ` Thomas Monjalon
  2021-01-26 15:32 ` David Marchand
  1 sibling, 1 reply; 6+ messages in thread
From: Bruce Richardson @ 2021-01-26 15:32 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev, Ruifeng Wang, Juraj Linkeš

On Tue, Jan 26, 2021 at 04:07:22PM +0100, Thomas Monjalon wrote:
> When removing the label "arm_cross_build_getting_the_prerequisite_library"
> in the rework of cross_build_dpdk_for_arm64.rst,
> the reference to this section got broken.
> It went unnoticed because "ninja -C doc" does not regenerate the file
> which is referencing the changed file.
> 
Do we know why this is? The doc builds should be doing proper dependency
tracking, based off the output from sphinx IIRC.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH 1/1] doc: fix build
  2021-01-26 15:07 [dpdk-dev] [PATCH 1/1] doc: fix build Thomas Monjalon
  2021-01-26 15:32 ` Bruce Richardson
@ 2021-01-26 15:32 ` David Marchand
  2021-01-26 15:42   ` Thomas Monjalon
  1 sibling, 1 reply; 6+ messages in thread
From: David Marchand @ 2021-01-26 15:32 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev, Ruifeng Wang, Juraj Linkeš

On Tue, Jan 26, 2021 at 4:08 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> When removing the label "arm_cross_build_getting_the_prerequisite_library"
> in the rework of cross_build_dpdk_for_arm64.rst,
> the reference to this section got broken.
> It went unnoticed because "ninja -C doc" does not regenerate the file
> which is referencing the changed file.
>
> Fixes: eb0e12c0c299 ("doc: add clang to aarch64 cross build guide")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Reviewed-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH 1/1] doc: fix build
  2021-01-26 15:32 ` Bruce Richardson
@ 2021-01-26 15:35   ` Thomas Monjalon
  2021-01-26 15:57     ` Bruce Richardson
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2021-01-26 15:35 UTC (permalink / raw)
  To: Bruce Richardson
  Cc: dev, Ruifeng Wang, Juraj Linkeš, david.marchand, bluca

26/01/2021 16:32, Bruce Richardson:
> On Tue, Jan 26, 2021 at 04:07:22PM +0100, Thomas Monjalon wrote:
> > When removing the label "arm_cross_build_getting_the_prerequisite_library"
> > in the rework of cross_build_dpdk_for_arm64.rst,
> > the reference to this section got broken.
> > It went unnoticed because "ninja -C doc" does not regenerate the file
> > which is referencing the changed file.
> > 
> Do we know why this is? The doc builds should be doing proper dependency
> tracking, based off the output from sphinx IIRC.

It seems it is building only the changed files.
I don't understand the logic in buildtools/call-sphinx-build.py



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH 1/1] doc: fix build
  2021-01-26 15:32 ` David Marchand
@ 2021-01-26 15:42   ` Thomas Monjalon
  0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2021-01-26 15:42 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, Ruifeng Wang, Juraj Linkeš

26/01/2021 16:32, David Marchand:
> On Tue, Jan 26, 2021 at 4:08 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > When removing the label "arm_cross_build_getting_the_prerequisite_library"
> > in the rework of cross_build_dpdk_for_arm64.rst,
> > the reference to this section got broken.
> > It went unnoticed because "ninja -C doc" does not regenerate the file
> > which is referencing the changed file.

Adding this explanation:
The fix is a reword not mentioning the "not so relevant" example
from cross_build_dpdk_for_arm64.rst.

> > Fixes: eb0e12c0c299 ("doc: add clang to aarch64 cross build guide")
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Reviewed-by: David Marchand <david.marchand@redhat.com>

Applied



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH 1/1] doc: fix build
  2021-01-26 15:35   ` Thomas Monjalon
@ 2021-01-26 15:57     ` Bruce Richardson
  0 siblings, 0 replies; 6+ messages in thread
From: Bruce Richardson @ 2021-01-26 15:57 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: dev, Ruifeng Wang, Juraj Linkeš, david.marchand, bluca

On Tue, Jan 26, 2021 at 04:35:16PM +0100, Thomas Monjalon wrote:
> 26/01/2021 16:32, Bruce Richardson:
> > On Tue, Jan 26, 2021 at 04:07:22PM +0100, Thomas Monjalon wrote:
> > > When removing the label "arm_cross_build_getting_the_prerequisite_library"
> > > in the rework of cross_build_dpdk_for_arm64.rst,
> > > the reference to this section got broken.
> > > It went unnoticed because "ninja -C doc" does not regenerate the file
> > > which is referencing the changed file.
> > > 
> > Do we know why this is? The doc builds should be doing proper dependency
> > tracking, based off the output from sphinx IIRC.
> 
> It seems it is building only the changed files.
> I don't understand the logic in buildtools/call-sphinx-build.py
> 
That needs some investigation, but it may be sphinx which is at fault
rather than the DPDK build. Most of the extra work done in the wrapper is
processing the files list worked by sphinx so we can mark them as
dependencies of the doc target. Sphinx itself does the incremental builds
of only changed files.

Unfortunately I don't have time to dig into this more right now.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-01-26 15:57 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-26 15:07 [dpdk-dev] [PATCH 1/1] doc: fix build Thomas Monjalon
2021-01-26 15:32 ` Bruce Richardson
2021-01-26 15:35   ` Thomas Monjalon
2021-01-26 15:57     ` Bruce Richardson
2021-01-26 15:32 ` David Marchand
2021-01-26 15:42   ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git