From: Thomas Monjalon <thomas.monjalon@6wind.com> To: "Qiu, Michael" <michael.qiu@intel.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 3/3 v2] librte_eal/common: Fix redeclaration of enumerator ‘REG_EAX’ Date: Thu, 05 Mar 2015 15:38:56 +0100 Message-ID: <2382780.BfG7EQavsa@xps13> (raw) In-Reply-To: <533710CFB86FA344BFBF2D6802E60286CEEF6B@SHSMSX101.ccr.corp.intel.com> 2015-03-05 14:03, Qiu, Michael: > On 3/5/2015 9:54 PM, David Marchand wrote: > > On Thu, Mar 5, 2015 at 2:50 PM, Michael Qiu <michael.qiu@intel.com > > <mailto:michael.qiu@intel.com>> wrote: > > > > include/rte_cpuflags.h:154:2: error: redeclaration of enumerator > > ‘REG_EAX’ > > In file included from /usr/include/signal.h:358:0, > > from /usr/include/sys/wait.h:30, > > from /root/dpdk/app/test/test_mp_secondary.c:50: > > /usr/include/sys/ucontext.h:180:3: note: previous definition of > > ‘REG_EAX’ was here > > > > In i686, from REG_EAX to REG_EDX are all defined in > > /usr/include/sys/ucontext.h > > > > Rename to CPU_REG_EAX to avoid this issue. > > > > Signed-off-by: Michael Qou <michael.qiu@intel.com > > <mailto:michael.qiu@intel.com>> > > > > > > NAK. > > > > I have answered in you last thread, please check the mail. > > Yes, but for some reason, it was not include, see /usr/include/signal.h:358 > > # include <bits/sigstack.h> > # if defined __USE_XOPEN || defined __USE_XOPEN2K8 > /* This will define `ucontext_t' and `mcontext_t'. */ > # include <sys/ucontext.h> > # endif > > So only if __USE_XOPEN or __USE_XOPEN2K8 been defined will include > <sys/ucontext.h> So try to define USE_XOPEN. > Why NAK? Because it seems you didn't really try to include system headers. We must avoid redefine existing symbols. That's why this bug happens. Michael, thanks for trying to fix this issue. It's appreciated even if the first solution is refused.
next prev parent reply other threads:[~2015-03-05 14:39 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-05 13:15 [dpdk-dev] [PATCH 0/3] dpdk2.0-rc1 build error fix Michael Qiu 2015-03-05 13:15 ` [dpdk-dev] [PATCH 1/3] librte_hash: Fix unsupported instruction `crc32' in i686 platform Michael Qiu 2015-03-05 16:10 ` Yerden Zhumabekov 2015-03-05 16:34 ` Qiu, Michael 2015-03-05 16:55 ` [dpdk-dev] [PATCH 1/3 v2] " Michael Qiu 2015-03-05 17:02 ` Yerden Zhumabekov 2015-03-05 17:10 ` Thomas Monjalon 2015-03-06 1:39 ` Qiu, Michael 2015-03-07 18:39 ` Thomas Monjalon 2015-03-10 3:55 ` Yerden Zhumabekov 2015-03-19 2:00 ` Qiu, Michael 2015-03-19 8:10 ` Thomas Monjalon 2015-03-09 5:58 ` [dpdk-dev] [PATCH 1/3 v3] " Michael Qiu 2015-03-18 13:20 ` Liu, Yong 2015-03-18 14:59 ` Qiu, Michael 2015-03-05 13:15 ` [dpdk-dev] [PATCH 2/3] app/test: Fix size_t printf formart issue Michael Qiu 2015-03-05 13:22 ` Bruce Richardson 2015-03-05 14:00 ` [dpdk-dev] [PATCH 2/3 v2] app/test: Fix size_t printf format issue Michael Qiu 2015-03-05 17:27 ` Thomas Monjalon 2015-03-06 1:42 ` Qiu, Michael 2015-03-06 3:53 ` [dpdk-dev] [PATCH 2/3 v3] " Michael Qiu 2015-03-05 13:15 ` [dpdk-dev] [PATCH 3/3] librte_eal/common: Fix redeclaration of enumerator ‘REG_EAX’ Michael Qiu 2015-03-05 13:23 ` Bruce Richardson 2015-03-05 13:36 ` David Marchand 2015-03-05 13:54 ` Qiu, Michael 2015-03-05 13:41 ` Qiu, Michael 2015-03-05 13:23 ` Qiu, Michael 2015-03-05 13:50 ` [dpdk-dev] [PATCH 3/3 v2] =?UTF-8?q?librte=5Feal/common:=20Fix=20redeclaration=20of?= =?UTF-8?q?=20enumerator=20=E2=80=98REG=5FEAX=E2=80=99?= Michael Qiu 2015-03-05 13:54 ` [dpdk-dev] [PATCH 3/3 v2] librte_eal/common: Fix redeclaration of enumerator ‘REG_EAX’ David Marchand 2015-03-05 14:03 ` Qiu, Michael 2015-03-05 14:38 ` Thomas Monjalon [this message] 2015-03-05 16:31 ` Qiu, Michael 2015-03-05 18:24 ` Thomas Monjalon 2015-03-05 13:57 ` [dpdk-dev] [PATCH 3/3 v3] =?UTF-8?q?librte=5Feal/common:=20Fix=20redeclaration=20of?= =?UTF-8?q?=20enumerator=20=E2=80=98REG=5FEAX=E2=80=99?= Michael Qiu 2015-03-06 6:28 ` [dpdk-dev] [PATCH 3/3 v3] librte_eal/common: Fix redeclaration of enumerator ‘REG_EAX’ David Marchand 2015-03-09 17:04 ` [dpdk-dev] [PATCH 0/3] dpdk2.0-rc1 build error fix Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2382780.BfG7EQavsa@xps13 \ --to=thomas.monjalon@6wind.com \ --cc=dev@dpdk.org \ --cc=michael.qiu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git