DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "johndale@cisco.com" <johndale@cisco.com>,
	"Zhang, Helin" <helin.zhang@intel.com>,
	"arnon@qwilt.com" <arnon@qwilt.com>,
	"rolette@infinite.io" <rolette@infinite.io>,
	"Chen, Jing D" <jing.d.chen@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] mbuf: remove unused Rx error flags
Date: Mon, 13 Jun 2016 12:42:17 +0000	[thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725836B6FDB0@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1463990171-10295-1-git-send-email-olivier.matz@6wind.com>


Hi Olivier,

> > -----Original Message-----
> > From: Olivier Matz [mailto:olivier.matz@6wind.com]
> > Sent: Monday, May 23, 2016 8:56 AM
> > To: dev@dpdk.org
> > Cc: johndale@cisco.com; Ananyev, Konstantin; Zhang, Helin; arnon@qwilt.com; rolette@infinite.io; Chen, Jing D; Wu, Jingjing
> > Subject: [PATCH] mbuf: remove unused Rx error flags
> >
> > Following the discussions from:
> > http://dpdk.org/ml/archives/dev/2015-July/021721.html
> > http://dpdk.org/ml/archives/dev/2016-April/038143.html
> >
> > The value of these flags is 0, making them useless. Today, no example
> > application checks them on Rx, and only few drivers sets them and
> > silently give wrong packets to the application, which should not happen.
> >
> > This patch removes the unused flags from rte_mbuf and their use in the
> > drivers. The i40e and fm10k are kept as they are today and should be
> > fixed to drop bad packets. The enic driver is managed by its maintainer
> > in another patch.
> >
> > Fixes: c22265f6 ("mbuf: add new packet flags for i40e")
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > ---
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>


Just a note, I think you'll need to rebase your patch with latest code.
enic PMD fails to compile.
Please feel free to keep my ack on it.
Konstantin

  parent reply	other threads:[~2016-06-13 12:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-29 12:25 [dpdk-dev] removing mbuf " Olivier Matz
2016-04-29 17:47 ` John Daley (johndale)
2016-04-29 18:16 ` Don Provan
2016-04-29 18:24   ` Jay Rolette
2016-04-29 20:00     ` Arnon Warshavsky
2016-04-29 20:57       ` Olivier MATZ
2016-04-30  1:41         ` Don Provan
2016-05-10  8:40           ` [dpdk-dev] [RFC] mbuf: remove unused rx " Olivier Matz
2016-05-12  1:32             ` John Daley (johndale)
2016-05-12  9:25               ` Olivier MATZ
2016-05-23  7:56                 ` [dpdk-dev] [PATCH] mbuf: remove unused Rx " Olivier Matz
2016-06-13 11:39                   ` Olivier Matz
2016-06-13 12:39                   ` Ananyev, Konstantin
2016-06-13 14:00                     ` Bruce Richardson
2016-06-13 12:42                   ` Ananyev, Konstantin [this message]
2016-06-13 12:49                     ` Olivier Matz
2016-06-13 13:25                       ` Bruce Richardson
2016-06-13 13:52                         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2601191342CEEE43887BDE71AB97725836B6FDB0@irsmsx105.ger.corp.intel.com \
    --to=konstantin.ananyev@intel.com \
    --cc=arnon@qwilt.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=jing.d.chen@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=johndale@cisco.com \
    --cc=olivier.matz@6wind.com \
    --cc=rolette@infinite.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).