DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] kni: fix build with Linux 3.17
@ 2014-08-18 12:44 Aaro Koskinen
  2014-08-19  2:55 ` Zhang, Helin
  2014-08-29 14:37 ` Thomas Monjalon
  0 siblings, 2 replies; 3+ messages in thread
From: Aaro Koskinen @ 2014-08-18 12:44 UTC (permalink / raw)
  To: dev

In the series of ever-lasting ugly #ifdefs trying make out-of-tree
drivers to support latest mainline kernel...

Signed-off-by: Aaro Koskinen <aaro.koskinen@nsn.com>
---
 lib/librte_eal/linuxapp/kni/kni_misc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c b/lib/librte_eal/linuxapp/kni/kni_misc.c
index 1c085d9..ba77776 100644
--- a/lib/librte_eal/linuxapp/kni/kni_misc.c
+++ b/lib/librte_eal/linuxapp/kni/kni_misc.c
@@ -345,6 +345,9 @@ kni_ioctl_create(unsigned int ioctl_num, unsigned long ioctl_param)
 	up_read(&kni_list_lock);
 
 	net_dev = alloc_netdev(sizeof(struct kni_dev), dev_info.name,
+#ifdef NET_NAME_UNKNOWN
+							NET_NAME_UNKNOWN,
+#endif
 							kni_net_init);
 	if (net_dev == NULL) {
 		KNI_ERR("error allocating device \"%s\"\n", dev_info.name);
-- 
2.0.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] kni: fix build with Linux 3.17
  2014-08-18 12:44 [dpdk-dev] [PATCH] kni: fix build with Linux 3.17 Aaro Koskinen
@ 2014-08-19  2:55 ` Zhang, Helin
  2014-08-29 14:37 ` Thomas Monjalon
  1 sibling, 0 replies; 3+ messages in thread
From: Zhang, Helin @ 2014-08-19  2:55 UTC (permalink / raw)
  To: Aaro Koskinen, dev



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Aaro Koskinen
> Sent: Monday, August 18, 2014 8:45 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] kni: fix build with Linux 3.17
> 
> In the series of ever-lasting ugly #ifdefs trying make out-of-tree drivers to
> support latest mainline kernel...
> 
> Signed-off-by: Aaro Koskinen <aaro.koskinen@nsn.com>
> ---
>  lib/librte_eal/linuxapp/kni/kni_misc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c
> b/lib/librte_eal/linuxapp/kni/kni_misc.c
> index 1c085d9..ba77776 100644
> --- a/lib/librte_eal/linuxapp/kni/kni_misc.c
> +++ b/lib/librte_eal/linuxapp/kni/kni_misc.c
> @@ -345,6 +345,9 @@ kni_ioctl_create(unsigned int ioctl_num, unsigned long
> ioctl_param)
>  	up_read(&kni_list_lock);
> 
>  	net_dev = alloc_netdev(sizeof(struct kni_dev), dev_info.name,
> +#ifdef NET_NAME_UNKNOWN
> +							NET_NAME_UNKNOWN,
> +#endif
>  							kni_net_init);
>  	if (net_dev == NULL) {
>  		KNI_ERR("error allocating device \"%s\"\n", dev_info.name);
> --
> 2.0.0

Will this interface be changed from kernel version 3.17?
Would it be better to add kernel version check here instead?

Regards,
Helin

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] kni: fix build with Linux 3.17
  2014-08-18 12:44 [dpdk-dev] [PATCH] kni: fix build with Linux 3.17 Aaro Koskinen
  2014-08-19  2:55 ` Zhang, Helin
@ 2014-08-29 14:37 ` Thomas Monjalon
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2014-08-29 14:37 UTC (permalink / raw)
  To: Aaro Koskinen; +Cc: dev

> In the series of ever-lasting ugly #ifdefs trying make out-of-tree
> drivers to support latest mainline kernel...
> 
> Signed-off-by: Aaro Koskinen <aaro.koskinen@nsn.com>

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied with this commit log:
    Since Linux commit "set name_assign_type in alloc_netdev" (c835a677331495),
    the function alloc_netdev takes a new parameter (name_assign_type)
    whose default value is NET_NAME_UNKNOWN.

Thanks
-- 
Thomas

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-08-29 14:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-18 12:44 [dpdk-dev] [PATCH] kni: fix build with Linux 3.17 Aaro Koskinen
2014-08-19  2:55 ` Zhang, Helin
2014-08-29 14:37 ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git