DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Wisam Jaddo <wisamm@mellanox.com>
Cc: jackmin@mellanox.com, david.marchand@redhat.com, dev@dpdk.org,
	asafp@mellanox.com, arybchenko@solarflare.com
Subject: Re: [dpdk-dev] [PATCH] app/flow-perf: fix condition of hairpin queues setup
Date: Sun, 05 Jul 2020 22:39:34 +0200
Message-ID: <31256849.VAYTUQ5BGV@thomas> (raw)
In-Reply-To: <20200630081028.21339-1-wisamm@mellanox.com>

30/06/2020 10:10, Wisam Jaddo:
> The hairpin queue is the one that start from normal rxq,
> and will be less than nr_queues where nr_queues is the
> sum of normal and hairpin
> Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation")
> Cc: wisamm@mellanox.com
> Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>

You should take this opportunity to document the logic
for the allocation and peering of hairpin queues.

It would be good to add short code comments for the variables as well.
It confusing to have hairpinq and hairpin_q variables.

Currently, we cannot really understand whether this fix is good or not.

On hairpin topic, I suggest fixing this typo:
	hairping-rss -> hairpin-rss

  parent reply	other threads:[~2020-07-05 20:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-30  8:10 Wisam Jaddo
2020-07-05 15:39 ` Asaf Penso
2020-07-05 20:39 ` Thomas Monjalon [this message]
2020-07-06  8:00   ` Wisam Monther
2020-07-06  7:53 ` [dpdk-dev] [PATCH v2] " Wisam Jaddo
2020-07-06  8:15   ` Thomas Monjalon
2020-07-06  8:32   ` [dpdk-dev] [PATCH v3] " Wisam Jaddo
2020-07-16 14:16     ` [dpdk-dev] [PATCH v4] " Wisam Jaddo
2020-07-19 13:11       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31256849.VAYTUQ5BGV@thomas \
    --to=thomas@monjalon.net \
    --cc=arybchenko@solarflare.com \
    --cc=asafp@mellanox.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jackmin@mellanox.com \
    --cc=wisamm@mellanox.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git