DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: announce ethdev port freeing on close operation
@ 2020-08-04  9:20 Thomas Monjalon
  2020-08-04  9:22 ` Jerin Jacob
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2020-08-04  9:20 UTC (permalink / raw)
  To: dev
  Cc: david.marchand, jerinj, arybchenko, ferruh.yigit, stephen,
	ajit.khaparde, matan, linville, qi.z.zhang, shepard.siegel,
	igor.russkikh, rmody, chas3, rahul.lakkireddy, hemant.agrawal,
	g.singh, grive, cristian.dumitrescu, keith.wiles, beilei.xing,
	jingjing.wu, cardigliano, rosen.xu, sthotton, heinrich.kuhn

Since DPDK 18.11, some drivers are migrating to a new behaviour,
releasing port resources on close.
The temporary flag RTE_ETH_DEV_CLOSE_REMOVE triggers this new mode
in the migrated drivers.
After 2 years, the flag and the old behaviour will be removed.
Last drivers not migrated will have to complete the switch.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 doc/guides/rel_notes/deprecation.rst | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index ea4cfa7a48..b5e8045d00 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -91,6 +91,12 @@ Deprecation Notices
   - ``rte_eth_dev_stop``
   - ``rte_eth_dev_close``
 
+* ethdev: The temporary flag RTE_ETH_DEV_CLOSE_REMOVE will be removed in 20.11.
+  As a consequence, the new behaviour introduced in 18.11 will be effective
+  for all drivers: generic port resources are freed on close operation.
+  Private resources are expected to be released in the ``dev_close`` callback.
+  More details in http://inbox.dpdk.org/dev/5248162.j6AOsuQRmx@thomas/
+
 * ethdev: New offload flags ``DEV_RX_OFFLOAD_FLOW_MARK`` will be added in 19.11.
   This will allow application to enable or disable PMDs from updating
   ``rte_mbuf::hash::fdir``.
-- 
2.27.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce ethdev port freeing on close operation
  2020-08-04  9:20 [dpdk-dev] [PATCH] doc: announce ethdev port freeing on close operation Thomas Monjalon
@ 2020-08-04  9:22 ` Jerin Jacob
  2020-08-04  9:29   ` Hemant Agrawal
  0 siblings, 1 reply; 6+ messages in thread
From: Jerin Jacob @ 2020-08-04  9:22 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: dpdk-dev, David Marchand, Jerin Jacob, Andrew Rybchenko,
	Ferruh Yigit, Stephen Hemminger, Ajit Khaparde, Matan Azrad,
	John W. Linville, Qi Zhang, Shepard Siegel, Igor Russkikh,
	Rasesh Mody, Chas Williams, Rahul Lakkireddy, Hemant Agrawal,
	Gagandeep Singh, Gaetan Rivet, Cristian Dumitrescu, Wiles, Keith,
	Beilei Xing, Jingjing Wu, Alfredo Cardigliano, Rosen Xu,
	Shijith Thotton, Heinrich Kuhn

On Tue, Aug 4, 2020 at 2:50 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> Since DPDK 18.11, some drivers are migrating to a new behaviour,
> releasing port resources on close.
> The temporary flag RTE_ETH_DEV_CLOSE_REMOVE triggers this new mode
> in the migrated drivers.
> After 2 years, the flag and the old behaviour will be removed.
> Last drivers not migrated will have to complete the switch.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Acked-by: Jerin Jacob <jerinj@marvell.com>



> ---
>  doc/guides/rel_notes/deprecation.rst | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index ea4cfa7a48..b5e8045d00 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -91,6 +91,12 @@ Deprecation Notices
>    - ``rte_eth_dev_stop``
>    - ``rte_eth_dev_close``
>
> +* ethdev: The temporary flag RTE_ETH_DEV_CLOSE_REMOVE will be removed in 20.11.
> +  As a consequence, the new behaviour introduced in 18.11 will be effective
> +  for all drivers: generic port resources are freed on close operation.
> +  Private resources are expected to be released in the ``dev_close`` callback.
> +  More details in http://inbox.dpdk.org/dev/5248162.j6AOsuQRmx@thomas/
> +
>  * ethdev: New offload flags ``DEV_RX_OFFLOAD_FLOW_MARK`` will be added in 19.11.
>    This will allow application to enable or disable PMDs from updating
>    ``rte_mbuf::hash::fdir``.
> --
> 2.27.0
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce ethdev port freeing on close operation
  2020-08-04  9:22 ` Jerin Jacob
@ 2020-08-04  9:29   ` Hemant Agrawal
  2020-08-04 17:34     ` Ajit Khaparde
  0 siblings, 1 reply; 6+ messages in thread
From: Hemant Agrawal @ 2020-08-04  9:29 UTC (permalink / raw)
  To: Jerin Jacob, Thomas Monjalon
  Cc: dpdk-dev, David Marchand, Jerin Jacob, Andrew Rybchenko,
	Ferruh Yigit, Stephen Hemminger, Ajit Khaparde, Matan Azrad,
	John W. Linville, Qi Zhang, Shepard Siegel, Igor Russkikh,
	Rasesh Mody, Chas Williams, Rahul Lakkireddy, Gagandeep Singh,
	Gaetan Rivet, Cristian Dumitrescu, Wiles, Keith, Beilei Xing,
	Jingjing Wu, Alfredo Cardigliano, Rosen Xu, Shijith Thotton,
	Heinrich Kuhn

> On Tue, Aug 4, 2020 at 2:50 PM Thomas Monjalon <thomas@monjalon.net>
> wrote:
> >
> > Since DPDK 18.11, some drivers are migrating to a new behaviour,
> > releasing port resources on close.
> > The temporary flag RTE_ETH_DEV_CLOSE_REMOVE triggers this new mode
> in
> > the migrated drivers.
> > After 2 years, the flag and the old behaviour will be removed.
> > Last drivers not migrated will have to complete the switch.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce ethdev port freeing on close operation
  2020-08-04  9:29   ` Hemant Agrawal
@ 2020-08-04 17:34     ` Ajit Khaparde
  2020-08-05 10:33       ` Andrew Rybchenko
  0 siblings, 1 reply; 6+ messages in thread
From: Ajit Khaparde @ 2020-08-04 17:34 UTC (permalink / raw)
  To: Hemant Agrawal
  Cc: Jerin Jacob, Thomas Monjalon, dpdk-dev, David Marchand,
	Jerin Jacob, Andrew Rybchenko, Ferruh Yigit, Stephen Hemminger,
	Matan Azrad, John W. Linville, Qi Zhang, Shepard Siegel,
	Igor Russkikh, Rasesh Mody, Chas Williams, Rahul Lakkireddy,
	Gagandeep Singh, Gaetan Rivet, Cristian Dumitrescu, Wiles, Keith,
	Beilei Xing, Jingjing Wu, Alfredo Cardigliano, Rosen Xu,
	Shijith Thotton, Heinrich Kuhn

On Tue, Aug 4, 2020 at 2:29 AM Hemant Agrawal <hemant.agrawal@nxp.com>
wrote:

> > On Tue, Aug 4, 2020 at 2:50 PM Thomas Monjalon <thomas@monjalon.net>
> > wrote:
> > >
> > > Since DPDK 18.11, some drivers are migrating to a new behaviour,
> > > releasing port resources on close.
> > > The temporary flag RTE_ETH_DEV_CLOSE_REMOVE triggers this new mode
> > in
> > > the migrated drivers.
> > > After 2 years, the flag and the old behaviour will be removed.
> > > Last drivers not migrated will have to complete the switch.
> > >
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> >
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce ethdev port freeing on close operation
  2020-08-04 17:34     ` Ajit Khaparde
@ 2020-08-05 10:33       ` Andrew Rybchenko
  2020-08-06  0:18         ` Thomas Monjalon
  0 siblings, 1 reply; 6+ messages in thread
From: Andrew Rybchenko @ 2020-08-05 10:33 UTC (permalink / raw)
  To: Ajit Khaparde, Hemant Agrawal
  Cc: Jerin Jacob, Thomas Monjalon, dpdk-dev, David Marchand,
	Jerin Jacob, Ferruh Yigit, Stephen Hemminger, Matan Azrad,
	John W. Linville, Qi Zhang, Shepard Siegel, Igor Russkikh,
	Rasesh Mody, Chas Williams, Rahul Lakkireddy, Gagandeep Singh,
	Gaetan Rivet, Cristian Dumitrescu, Wiles, Keith, Beilei Xing,
	Jingjing Wu, Alfredo Cardigliano, Rosen Xu, Shijith Thotton,
	Heinrich Kuhn

On 8/4/20 8:34 PM, Ajit Khaparde wrote:
> On Tue, Aug 4, 2020 at 2:29 AM Hemant Agrawal <hemant.agrawal@nxp.com>
> wrote:
> 
>>> On Tue, Aug 4, 2020 at 2:50 PM Thomas Monjalon <thomas@monjalon.net>
>>> wrote:
>>>>
>>>> Since DPDK 18.11, some drivers are migrating to a new behaviour,
>>>> releasing port resources on close.
>>>> The temporary flag RTE_ETH_DEV_CLOSE_REMOVE triggers this new mode
>>> in
>>>> the migrated drivers.
>>>> After 2 years, the flag and the old behaviour will be removed.
>>>> Last drivers not migrated will have to complete the switch.
>>>>
>>>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>>>
>> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> 

Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce ethdev port freeing on close operation
  2020-08-05 10:33       ` Andrew Rybchenko
@ 2020-08-06  0:18         ` Thomas Monjalon
  0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2020-08-06  0:18 UTC (permalink / raw)
  To: dev
  Cc: Ajit Khaparde, Hemant Agrawal, Jerin Jacob, dpdk-dev,
	David Marchand, Jerin Jacob, Ferruh Yigit, Stephen Hemminger,
	Matan Azrad, John W. Linville, Qi Zhang, Shepard Siegel,
	Igor Russkikh, Rasesh Mody, Chas Williams, Rahul Lakkireddy,
	Gagandeep Singh, Gaetan Rivet, Cristian Dumitrescu, Wiles, Keith,
	Beilei Xing, Jingjing Wu, Alfredo Cardigliano, Rosen Xu,
	Shijith Thotton, Heinrich Kuhn, Andrew Rybchenko

05/08/2020 12:33, Andrew Rybchenko:
> On 8/4/20 8:34 PM, Ajit Khaparde wrote:
> > On Tue, Aug 4, 2020 at 2:29 AM Hemant Agrawal <hemant.agrawal@nxp.com>
> > wrote:
> > 
> >>> On Tue, Aug 4, 2020 at 2:50 PM Thomas Monjalon <thomas@monjalon.net>
> >>> wrote:
> >>>>
> >>>> Since DPDK 18.11, some drivers are migrating to a new behaviour,
> >>>> releasing port resources on close.
> >>>> The temporary flag RTE_ETH_DEV_CLOSE_REMOVE triggers this new mode
> >>> in
> >>>> the migrated drivers.
> >>>> After 2 years, the flag and the old behaviour will be removed.
> >>>> Last drivers not migrated will have to complete the switch.
> >>>>
> >>>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Jerin Jacob <jerinj@marvell.com>
> >> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>

Applied




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-08-06  0:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-04  9:20 [dpdk-dev] [PATCH] doc: announce ethdev port freeing on close operation Thomas Monjalon
2020-08-04  9:22 ` Jerin Jacob
2020-08-04  9:29   ` Hemant Agrawal
2020-08-04 17:34     ` Ajit Khaparde
2020-08-05 10:33       ` Andrew Rybchenko
2020-08-06  0:18         ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git