From: "Pattan, Reshma" <reshma.pattan@intel.com> To: "Chaitanya Babu, TalluriX" <tallurix.chaitanya.babu@intel.com>, "dev@dpdk.org" <dev@dpdk.org> Cc: "Marohn, Byron" <byron.marohn@intel.com>, "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, "stable@dpdk.org" <stable@dpdk.org> Subject: Re: [dpdk-dev] [PATCH] lib: fix write unlock during ring creation Date: Tue, 13 Nov 2018 16:58:11 +0000 Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A3D301C@irsmsx110.ger.corp.intel.com> (raw) In-Reply-To: <1542113714-22607-1-git-send-email-tallurix.chaitanya.babu@intel.com> > -----Original Message----- > From: Chaitanya Babu, TalluriX > Sent: Tuesday, November 13, 2018 12:55 PM > To: dev@dpdk.org > Cc: Marohn, Byron <byron.marohn@intel.com>; Pattan, Reshma > <reshma.pattan@intel.com>; De Lara Guarch, Pablo > <pablo.de.lara.guarch@intel.com>; Chaitanya Babu, TalluriX > <tallurix.chaitanya.babu@intel.com>; stable@dpdk.org > Subject: [PATCH] lib: fix write unlock during ring creation Heading should have lib/efd: > > In rte_efd_create() write lock has already been unlocked before ring creation > itself. > So second unlock after the ring creation has been removed and added freeing of > tail queue entry and efd table. Changes do not have free of tailq entry, so remove the mention of it from commit message. > - /* Create ring (Dummy slot index is not enqueued) */ > + /* Create ring (Dummy slot index is not enqueued) */ Undo this change. Unrelated. Other than these looks ok. Acked-by: Reshma Pattan <reshma.pattan@intel.com> Thanks, Reshma
next prev parent reply other threads:[~2018-11-13 16:58 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-13 12:55 Chaitanya Babu Talluri 2018-11-13 16:58 ` Pattan, Reshma [this message] 2018-11-18 14:43 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon 2018-11-14 11:24 ` [dpdk-dev] [PATCH v2] lib/efd: " Chaitanya Babu Talluri 2018-11-16 13:39 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit 2018-11-18 14:46 ` Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3AEA2BF9852C6F48A459DA490692831F2A3D301C@irsmsx110.ger.corp.intel.com \ --to=reshma.pattan@intel.com \ --cc=byron.marohn@intel.com \ --cc=dev@dpdk.org \ --cc=pablo.de.lara.guarch@intel.com \ --cc=stable@dpdk.org \ --cc=tallurix.chaitanya.babu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git