DPDK patches and discussions
 help / color / mirror / Atom feed
From: Shahaf Shuler <shahafs@mellanox.com>
To: dev@dpdk.org, konstantin.ananyev@intel.com,
	radu.nicolau@intel.com, arybchenko@solarflare.com
Subject: [dpdk-dev] [PATCH v2 22/39] examples/qos_meter: convert to new ethdev offloads API
Date: Tue, 12 Dec 2017 14:26:39 +0200	[thread overview]
Message-ID: <3bd06d43d7e2a36566beb4f98752200366d396dc.1513081088.git.shahafs@mellanox.com> (raw)
In-Reply-To: <cover.1513081087.git.shahafs@mellanox.com>

Ethdev offloads API has changed since:

commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
commit cba7f53b717d ("ethdev: introduce Tx queue offloads API")

This commit support the new API.

Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---
 examples/qos_meter/main.c | 61 +++++++++++++++++++++++++++++++++++++-----
 1 file changed, 54 insertions(+), 7 deletions(-)

diff --git a/examples/qos_meter/main.c b/examples/qos_meter/main.c
index 67b4a75..5b0e3ae 100644
--- a/examples/qos_meter/main.c
+++ b/examples/qos_meter/main.c
@@ -85,11 +85,9 @@
 		.mq_mode	= ETH_MQ_RX_RSS,
 		.max_rx_pkt_len = ETHER_MAX_LEN,
 		.split_hdr_size = 0,
-		.header_split   = 0,
-		.hw_ip_checksum = 1,
-		.hw_vlan_filter = 0,
-		.jumbo_frame    = 0,
-		.hw_strip_crc   = 1,
+		.ignore_offload_bitfield = 1,
+		.offloads = (DEV_RX_OFFLOAD_CHECKSUM |
+			     DEV_RX_OFFLOAD_CRC_STRIP),
 	},
 	.rx_adv_conf = {
 		.rss_conf = {
@@ -99,6 +97,7 @@
 	},
 	.txmode = {
 		.mq_mode = ETH_DCB_NONE,
+		.offloads = DEV_TX_OFFLOAD_MBUF_FAST_FREE,
 	},
 };
 
@@ -310,6 +309,10 @@ static __attribute__((noreturn)) int
 	uint32_t lcore_id;
 	uint16_t nb_rxd = NIC_RX_QUEUE_DESC;
 	uint16_t nb_txd = NIC_TX_QUEUE_DESC;
+	struct rte_eth_conf conf;
+	struct rte_eth_rxconf rxq_conf;
+	struct rte_eth_txconf txq_conf;
+	struct rte_eth_dev_info dev_info;
 	int ret;
 
 	/* EAL init */
@@ -335,6 +338,22 @@ static __attribute__((noreturn)) int
 		rte_exit(EXIT_FAILURE, "Buffer pool creation error\n");
 
 	/* NIC init */
+	rte_eth_dev_info_get(port_rx, &dev_info);
+	if ((dev_info.rx_offload_capa & port_conf.rxmode.offloads) !=
+	    port_conf.rxmode.offloads) {
+		printf("Some Rx offloads are not supported "
+		       "by port %d: requested 0x%lx supported 0x%lx\n",
+		       port_rx, port_conf.rxmode.offloads,
+		       dev_info.rx_offload_capa);
+	}
+	if ((dev_info.tx_offload_capa & port_conf.txmode.offloads) !=
+	    port_conf.txmode.offloads) {
+		printf("Some Tx offloads are not supported "
+		       "by port %d: requested 0x%lx supported 0x%lx\n",
+		       port_rx, port_conf.txmode.offloads,
+		       dev_info.tx_offload_capa);
+	}
+	conf = port_conf;
 	ret = rte_eth_dev_configure(port_rx, 1, 1, &port_conf);
 	if (ret < 0)
 		rte_exit(EXIT_FAILURE, "Port %d configuration error (%d)\n", port_rx, ret);
@@ -344,18 +363,41 @@ static __attribute__((noreturn)) int
 		rte_exit(EXIT_FAILURE, "Port %d adjust number of descriptors error (%d)\n",
 				port_rx, ret);
 
+	rxq_conf = dev_info.default_rxconf;
+	rxq_conf.offloads = conf.rxmode.offloads;
 	ret = rte_eth_rx_queue_setup(port_rx, NIC_RX_QUEUE, nb_rxd,
 				rte_eth_dev_socket_id(port_rx),
-				NULL, pool);
+				&rxq_conf, pool);
 	if (ret < 0)
 		rte_exit(EXIT_FAILURE, "Port %d RX queue setup error (%d)\n", port_rx, ret);
 
+	txq_conf = dev_info.default_txconf;
+	txq_conf.txq_flags = ETH_TXQ_FLAGS_IGNORE;
+	txq_conf.offloads = conf.txmode.offloads;
 	ret = rte_eth_tx_queue_setup(port_rx, NIC_TX_QUEUE, nb_txd,
 				rte_eth_dev_socket_id(port_rx),
-				NULL);
+				&txq_conf);
 	if (ret < 0)
 	rte_exit(EXIT_FAILURE, "Port %d TX queue setup error (%d)\n", port_rx, ret);
 
+	rte_eth_dev_info_get(port_tx, &dev_info);
+	if ((dev_info.rx_offload_capa & port_conf.rxmode.offloads) !=
+	    port_conf.rxmode.offloads) {
+		printf("Some Rx offloads are not supported "
+		       "by port %d: requested 0x%lx supported 0x%lx\n",
+		       port_tx, port_conf.rxmode.offloads,
+		       dev_info.rx_offload_capa);
+	}
+	if ((dev_info.tx_offload_capa & port_conf.txmode.offloads) !=
+	    port_conf.txmode.offloads) {
+		printf("Some Tx offloads are not supported "
+		       "by port %d: requested 0x%lx supported 0x%lx\n",
+		       port_tx, port_conf.txmode.offloads,
+		       dev_info.tx_offload_capa);
+	}
+	conf = port_conf;
+	conf.rxmode.offloads &= dev_info.rx_offload_capa;
+	conf.txmode.offloads &= dev_info.tx_offload_capa;
 	ret = rte_eth_dev_configure(port_tx, 1, 1, &port_conf);
 	if (ret < 0)
 		rte_exit(EXIT_FAILURE, "Port %d configuration error (%d)\n", port_tx, ret);
@@ -367,12 +409,17 @@ static __attribute__((noreturn)) int
 		rte_exit(EXIT_FAILURE, "Port %d adjust number of descriptors error (%d)\n",
 				port_tx, ret);
 
+	rxq_conf = dev_info.default_rxconf;
+	rxq_conf.offloads = conf.rxmode.offloads;
 	ret = rte_eth_rx_queue_setup(port_tx, NIC_RX_QUEUE, nb_rxd,
 				rte_eth_dev_socket_id(port_tx),
 				NULL, pool);
 	if (ret < 0)
 		rte_exit(EXIT_FAILURE, "Port %d RX queue setup error (%d)\n", port_tx, ret);
 
+	txq_conf = dev_info.default_txconf;
+	txq_conf.txq_flags = ETH_TXQ_FLAGS_IGNORE;
+	txq_conf.offloads = conf.txmode.offloads;
 	ret = rte_eth_tx_queue_setup(port_tx, NIC_TX_QUEUE, nb_txd,
 				rte_eth_dev_socket_id(port_tx),
 				NULL);
-- 
1.8.3.1

  parent reply	other threads:[~2017-12-12 12:27 UTC|newest]

Thread overview: 134+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-23 12:14 [dpdk-dev] [PATCH 00/39] convert examples " Shahaf Shuler
2017-11-23 12:14 ` [dpdk-dev] [PATCH 01/39] examples/l2fwd: convert " Shahaf Shuler
2017-11-24 15:00   ` Andrew Rybchenko
2017-11-26  7:41     ` Shahaf Shuler
2017-11-27  6:34       ` Andrew Rybchenko
2017-11-27  7:03         ` Shahaf Shuler
2017-11-27  7:33           ` Jerin Jacob
2017-11-27 19:41             ` Shahaf Shuler
2017-11-27  7:40           ` Andrew Rybchenko
2017-11-23 12:14 ` [dpdk-dev] [PATCH 02/39] examples/l2fwd-crypto: " Shahaf Shuler
2017-11-23 12:14 ` [dpdk-dev] [PATCH 03/39] examples/l2fwd-jobstats: " Shahaf Shuler
2017-11-23 12:14 ` [dpdk-dev] [PATCH 04/39] examples/l2fwd-keepalive: " Shahaf Shuler
2017-11-23 12:14 ` [dpdk-dev] [PATCH 05/39] examples/l3fwd: move to " Shahaf Shuler
2017-11-23 12:14 ` [dpdk-dev] [PATCH 06/39] examples/l3fwd-acl: convert to new " Shahaf Shuler
2017-12-11 14:48   ` Ananyev, Konstantin
2017-11-23 12:14 ` [dpdk-dev] [PATCH 07/39] examples/l3fwd-power: " Shahaf Shuler
2017-12-11 14:00   ` Hunt, David
2017-11-23 12:14 ` [dpdk-dev] [PATCH 08/39] examples/l3fwd-vf: " Shahaf Shuler
2017-11-23 12:14 ` [dpdk-dev] [PATCH 09/39] examples/bond: " Shahaf Shuler
2017-12-11 11:08   ` Radu Nicolau
2017-12-04 12:12 ` [dpdk-dev] [PATCH 00/39] convert examples " Shahaf Shuler
2017-12-12 12:26 ` [dpdk-dev] [PATCH v2 " Shahaf Shuler
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 01/39] examples/l2fwd: convert " Shahaf Shuler
2017-12-19 12:16     ` De Lara Guarch, Pablo
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 02/39] examples/l2fwd-crypto: " Shahaf Shuler
2017-12-19 12:18     ` De Lara Guarch, Pablo
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 03/39] examples/l2fwd-jobstats: " Shahaf Shuler
2017-12-19 12:33     ` De Lara Guarch, Pablo
2017-12-21 13:47       ` Shahaf Shuler
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 04/39] examples/l2fwd-keepalive: " Shahaf Shuler
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 05/39] examples/l3fwd: move to " Shahaf Shuler
2017-12-12 17:12     ` Ananyev, Konstantin
2017-12-13  7:21       ` Shahaf Shuler
2017-12-13  7:55         ` Jerin Jacob
2017-12-13 12:10           ` Ananyev, Konstantin
2017-12-13 17:32             ` Jerin Jacob
2017-12-21 14:26               ` Shahaf Shuler
2017-12-18 16:00     ` Maciej Czekaj
2017-12-21 14:08       ` Shahaf Shuler
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 06/39] examples/l3fwd-acl: convert to new " Shahaf Shuler
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 07/39] examples/l3fwd-power: " Shahaf Shuler
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 08/39] examples/l3fwd-vf: " Shahaf Shuler
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 09/39] examples/bond: " Shahaf Shuler
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 10/39] examples/exception_path: " Shahaf Shuler
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 11/39] examples/kni: " Shahaf Shuler
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 12/39] examples/ip_fragmentation: convert to new " Shahaf Shuler
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 13/39] examples/ip_pipeline: convert to new ethdev " Shahaf Shuler
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 14/39] examples/ip_reassembly: " Shahaf Shuler
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 15/39] examples/ipsec-secgw: " Shahaf Shuler
2017-12-19 12:38     ` De Lara Guarch, Pablo
2017-12-21 13:45       ` Shahaf Shuler
2018-01-08 16:27         ` De Lara Guarch, Pablo
2018-01-09  7:07           ` Akhil Goyal
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 16/39] examples/ipv4_multicast: " Shahaf Shuler
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 17/39] examples/link_status_interrupt: convert to new " Shahaf Shuler
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 18/39] examples/load_balancer: convert to new ethdev " Shahaf Shuler
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 19/39] examples/multi_process: " Shahaf Shuler
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 20/39] examples/netmap_compat: " Shahaf Shuler
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 21/39] examples/performance-thread: convert to new " Shahaf Shuler
2017-12-12 12:26   ` Shahaf Shuler [this message]
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 23/39] examples/qos_sched: convert to new ethdev " Shahaf Shuler
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 24/39] examples/quota_watermark: " Shahaf Shuler
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 25/39] examples/tep_termination: " Shahaf Shuler
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 26/39] examples/vhost: " Shahaf Shuler
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 27/39] examples/vmdq: " Shahaf Shuler
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 28/39] examples/vmdq_dcb: " Shahaf Shuler
2017-12-12 12:26   ` [dpdk-dev] [PATCH v2 29/39] examples/vm_power_manager: convert to new " Shahaf Shuler
2017-12-12 12:35   ` [dpdk-dev] [PATCH v2 30/39] examples/distributor: convert to new ethdev " Shahaf Shuler
2017-12-12 12:35   ` [dpdk-dev] [PATCH v2 31/39] examples/ethtool: " Shahaf Shuler
2017-12-12 12:35   ` [dpdk-dev] [PATCH v2 32/39] examples/eventdev_pipeline: convert to new " Shahaf Shuler
2017-12-15 15:20     ` Van Haaren, Harry
2017-12-12 12:35   ` [dpdk-dev] [PATCH v2 33/39] examples/flow_classify: convert to new ethdev " Shahaf Shuler
2017-12-12 12:35   ` [dpdk-dev] [PATCH v2 34/39] examples/flow_filtering: " Shahaf Shuler
2017-12-12 12:35   ` [dpdk-dev] [PATCH v2 35/39] examples/packet_ordering: " Shahaf Shuler
2017-12-12 12:35   ` [dpdk-dev] [PATCH v2 36/39] examples/ptpclient: " Shahaf Shuler
2017-12-12 12:35   ` [dpdk-dev] [PATCH v2 37/39] examples/rxtx_callbacks: " Shahaf Shuler
2017-12-12 12:35   ` [dpdk-dev] [PATCH v2 38/39] examples/server_node_efd: " Shahaf Shuler
2017-12-12 12:35   ` [dpdk-dev] [PATCH v2 39/39] examples/skeleton: " Shahaf Shuler
2017-12-26  9:22   ` [dpdk-dev] [PATCH v3 00/39] convert examples " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 01/39] examples/l2fwd: convert " Shahaf Shuler
2018-01-10 12:12       ` De Lara Guarch, Pablo
2018-01-12 13:30       ` Ferruh Yigit
2018-01-14 10:37         ` Shahaf Shuler
2018-01-15 10:20           ` Ferruh Yigit
2018-01-15 11:02             ` Shahaf Shuler
2018-01-15 11:34               ` Ferruh Yigit
2018-01-15 11:41                 ` Shahaf Shuler
2018-01-15 11:56                   ` Ferruh Yigit
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 02/39] examples/l2fwd-crypto: " Shahaf Shuler
2018-01-10 12:12       ` De Lara Guarch, Pablo
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 03/39] examples/l2fwd-jobstats: " Shahaf Shuler
2018-01-10 12:13       ` De Lara Guarch, Pablo
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 04/39] examples/l2fwd-keepalive: " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 05/39] examples/l3fwd: convert to " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 06/39] examples/l3fwd-acl: convert to new " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 07/39] examples/l3fwd-power: " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 08/39] examples/l3fwd-vf: " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 09/39] examples/bond: " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 10/39] examples/exception_path: " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 11/39] examples/kni: " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 12/39] examples/ip_fragmentation: convert to new " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 13/39] examples/ip_pipeline: convert to new ethdev " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 14/39] examples/ip_reassembly: " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 15/39] examples/ipsec-secgw: " Shahaf Shuler
2018-01-16 11:10       ` Nicolau, Radu
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 16/39] examples/ipv4_multicast: " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 17/39] examples/link_status_interrupt: convert to new " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 18/39] examples/load_balancer: convert to new ethdev " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 19/39] examples/multi_process: " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 20/39] examples/netmap_compat: " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 21/39] examples/performance-thread: convert to new " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 22/39] examples/qos_meter: convert to new ethdev " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 23/39] examples/qos_sched: " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 24/39] examples/quota_watermark: " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 25/39] examples/tep_termination: " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 26/39] examples/vhost: " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 27/39] examples/vmdq: " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 28/39] examples/vmdq_dcb: " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 29/39] examples/vm_power_manager: convert to new " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 30/39] examples/distributor: convert to new ethdev " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 31/39] examples/ethtool: " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 32/39] examples/eventdev_pipeline: convert to new " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 33/39] examples/flow_classify: convert to new ethdev " Shahaf Shuler
2018-01-03 15:09       ` Iremonger, Bernard
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 34/39] examples/flow_filtering: " Shahaf Shuler
2017-12-26 13:57       ` Ori Kam
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 35/39] examples/packet_ordering: " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 36/39] examples/ptpclient: " Shahaf Shuler
2018-01-10 12:14       ` De Lara Guarch, Pablo
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 37/39] examples/rxtx_callbacks: " Shahaf Shuler
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 38/39] examples/server_node_efd: " Shahaf Shuler
2018-01-10 12:15       ` De Lara Guarch, Pablo
2017-12-26  9:23     ` [dpdk-dev] [PATCH v3 39/39] examples/skeleton: " Shahaf Shuler
2018-01-16 16:25     ` [dpdk-dev] [PATCH v3 00/39] convert examples " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3bd06d43d7e2a36566beb4f98752200366d396dc.1513081088.git.shahafs@mellanox.com \
    --to=shahafs@mellanox.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=radu.nicolau@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).