DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Xia, Chenbo" <chenbo.xia@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"amorenoz@redhat.com" <amorenoz@redhat.com>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>,
	"olivier.matz@6wind.com" <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH 0/3] net/virtio: make virtqueue struct cache-friendly
Date: Fri, 8 Jan 2021 09:25:20 +0100
Message-ID: <3cecca64-f2cc-5b3b-aa7f-8a02fb951622@redhat.com> (raw)
In-Reply-To: <MN2PR11MB40638866675E3D62A32C847F9CAE0@MN2PR11MB4063.namprd11.prod.outlook.com>

Hi Chenbo,

On 1/8/21 3:50 AM, Xia, Chenbo wrote:
> Hi Maxime,
> 
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Sent: Tuesday, December 22, 2020 12:15 AM
>> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; amorenoz@redhat.com;
>> david.marchand@redhat.com; olivier.matz@6wind.com
>> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Subject: [PATCH 0/3] net/virtio: make virtqueue struct cache-friendly
>>
>> This series optimizes the cache usage of virtqueue struct,
>> by make a "fake" mbuf being dynamically allocated in Rx
>> virtnet struct, by removing a useless virtuque pointer
>> into the virtnet structs and by moving a few fields
>> to pack holes.
>>
>> With these 3 patches, the virtqueue struct size goes from
>> 576 bytes (9 cachelines) to 248 bytes (4 cachelines).
>>
>> Maxime Coquelin (3):
>>   net/virtio: remove reference to virtqueue in vrings
>>   net/virtio: allocate fake mbuf in Rx queue
>>   net/virtio: pack virtuqueue struct
>>
>>  drivers/net/virtio/virtio_ethdev.c            | 46 +++++++++++--------
>>  drivers/net/virtio/virtio_rxtx.c              | 36 +++++++--------
>>  drivers/net/virtio/virtio_rxtx.h              |  5 +-
>>  drivers/net/virtio/virtio_rxtx_packed_avx.c   | 14 +++---
>>  drivers/net/virtio/virtio_rxtx_simple.h       |  2 +-
>>  .../net/virtio/virtio_rxtx_simple_altivec.c   |  2 +-
>>  drivers/net/virtio/virtio_rxtx_simple_neon.c  |  2 +-
>>  drivers/net/virtio/virtio_rxtx_simple_sse.c   |  2 +-
>>  .../net/virtio/virtio_user/virtio_user_dev.c  |  4 +-
>>  drivers/net/virtio/virtio_user_ethdev.c       |  2 +-
>>  drivers/net/virtio/virtqueue.h                | 24 ++++++----
>>  11 files changed, 72 insertions(+), 67 deletions(-)
>>
>> --
>> 2.29.2
> 
> Does this patchset have a apply issue? Locally I can't apply the patches and
> Patchwork also shows apply issues.

For got to mention, but the series applied on top of the big rework as
it conflict with it, and the rework is more important.

Cheers,
Maxime

> Thanks,
> Chenbo
> 


  reply	other threads:[~2021-01-08  8:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-21 16:14 Maxime Coquelin
2020-12-21 16:14 ` [dpdk-dev] [PATCH 1/3] net/virtio: remove reference to virtqueue in vrings Maxime Coquelin
2021-01-11  2:17   ` Xia, Chenbo
2020-12-21 16:14 ` [dpdk-dev] [PATCH 2/3] net/virtio: allocate fake mbuf in Rx queue Maxime Coquelin
2021-01-11  2:50   ` Xia, Chenbo
2021-03-15 11:29     ` Maxime Coquelin
2021-01-11  5:39   ` Xia, Chenbo
2021-03-15 13:46     ` Maxime Coquelin
2020-12-21 16:14 ` [dpdk-dev] [PATCH 3/3] net/virtio: pack virtuqueue struct Maxime Coquelin
2021-01-11  2:56   ` Xia, Chenbo
2021-01-08  2:50 ` [dpdk-dev] [PATCH 0/3] net/virtio: make virtqueue struct cache-friendly Xia, Chenbo
2021-01-08  8:25   ` Maxime Coquelin [this message]
2021-01-25 17:30 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3cecca64-f2cc-5b3b-aa7f-8a02fb951622@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=amorenoz@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git