DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] bus/pci: set boot-up log prints to absolute minimum
@ 2020-01-21  8:00 jerinj
  2020-02-06 14:14 ` Thomas Monjalon
  2020-05-04 13:26 ` [dpdk-dev] [PATCH v2] " jerinj
  0 siblings, 2 replies; 13+ messages in thread
From: jerinj @ 2020-01-21  8:00 UTC (permalink / raw)
  To: dev; +Cc: thomas, olivier.matz, Jerin Jacob

From: Jerin Jacob <jerinj@marvell.com>

Some machines may have a lot of PCI devices, logs from PCI probe
creates a lot of clutter on boot-up, typically one needs
to scroll the screen to find other issues in boot-up.

This patch changes the loglevel of PCI probes to `debug`
to reduce the clutter on default boot-up logs

Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
 drivers/bus/pci/pci_common.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
index 3f5542076..665a8b3df 100644
--- a/drivers/bus/pci/pci_common.c
+++ b/drivers/bus/pci/pci_common.c
@@ -136,7 +136,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
 		/* Match of device and driver failed */
 		return 1;
 
-	RTE_LOG(INFO, EAL, "PCI device "PCI_PRI_FMT" on NUMA socket %i\n",
+	RTE_LOG(DEBUG, EAL, "PCI device "PCI_PRI_FMT" on NUMA socket %i\n",
 			loc->domain, loc->bus, loc->devid, loc->function,
 			dev->device.numa_node);
 
@@ -161,7 +161,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
 		return -EEXIST;
 	}
 
-	RTE_LOG(INFO, EAL, "  probe driver: %x:%x %s\n", dev->id.vendor_id,
+	RTE_LOG(DEBUG, EAL, "  probe driver: %x:%x %s\n", dev->id.vendor_id,
 		dev->id.device_id, dr->driver.name);
 
 	/*
-- 
2.24.1


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [dpdk-dev] [PATCH] bus/pci: set boot-up log prints to absolute minimum
  2020-01-21  8:00 [dpdk-dev] [PATCH] bus/pci: set boot-up log prints to absolute minimum jerinj
@ 2020-02-06 14:14 ` Thomas Monjalon
  2020-02-06 14:36   ` Jerin Jacob
  2020-05-04 13:26 ` [dpdk-dev] [PATCH v2] " jerinj
  1 sibling, 1 reply; 13+ messages in thread
From: Thomas Monjalon @ 2020-02-06 14:14 UTC (permalink / raw)
  To: Jerin Jacob; +Cc: dev, olivier.matz, jerinj

21/01/2020 09:00, jerinj@marvell.com:
> From: Jerin Jacob <jerinj@marvell.com>
> 
> Some machines may have a lot of PCI devices, logs from PCI probe
> creates a lot of clutter on boot-up, typically one needs
> to scroll the screen to find other issues in boot-up.
> 
> This patch changes the loglevel of PCI probes to `debug`
> to reduce the clutter on default boot-up logs

I think the PCI probe informations are... informational.
Maybe you are just not interested in info logs.
If this is the case, I suggest to change the log level at runtime.




^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [dpdk-dev] [PATCH] bus/pci: set boot-up log prints to absolute minimum
  2020-02-06 14:14 ` Thomas Monjalon
@ 2020-02-06 14:36   ` Jerin Jacob
  2020-04-25 20:12     ` Thomas Monjalon
  0 siblings, 1 reply; 13+ messages in thread
From: Jerin Jacob @ 2020-02-06 14:36 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: Jerin Jacob, dpdk-dev, Olivier Matz

On Thu, Feb 6, 2020 at 7:44 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 21/01/2020 09:00, jerinj@marvell.com:
> > From: Jerin Jacob <jerinj@marvell.com>
> >
> > Some machines may have a lot of PCI devices, logs from PCI probe
> > creates a lot of clutter on boot-up, typically one needs
> > to scroll the screen to find other issues in boot-up.
> >
> > This patch changes the loglevel of PCI probes to `debug`
> > to reduce the clutter on default boot-up logs
>
> I think the PCI probe informations are... informational.
> Maybe you are just not interested in info logs.
> If this is the case, I suggest to change the log level at runtime.

I am wondering, what would be the right balance, Following is DPDK
startup output from octeontx2[1]
It creates a lot of clutter in the "default" boot up. Why not enable
below prints using log level at runtime?
I believe it comes as a debug category, i.e information required to
debug if something is not working,
dpdk bind script already lists what is bound to DPDK.

Suggestion to remove clutter?

[1]
EAL: Detected 24 lcore(s)
EAL: Detected 1 NUMA nodes
EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
EAL: Selected IOVA mode 'VA'
EAL: No available hugepages reported in hugepages-2048kB
EAL: Probing VFIO support...
EAL: VFIO support initialized
EAL: PCI device 0002:01:00.1 on NUMA socket 0
EAL:   probe driver: 177d:a0f8 net_octeontx2
EAL: PCI device 0002:01:00.2 on NUMA socket 0
EAL:   probe driver: 177d:a0f8 net_octeontx2
EAL: PCI device 0002:01:00.3 on NUMA socket 0
EAL:   probe driver: 177d:a0f8 net_octeontx2
EAL: PCI device 0002:01:00.4 on NUMA socket 0
EAL:   probe driver: 177d:a0f8 net_octeontx2
EAL: PCI device 0002:01:00.5 on NUMA socket 0
EAL:   probe driver: 177d:a0f8 net_octeontx2
EAL: PCI device 0002:01:00.6 on NUMA socket 0
EAL:   probe driver: 177d:a0f8 net_octeontx2
EAL: PCI device 0002:01:00.7 on NUMA socket 0
EAL:   probe driver: 177d:a0f8 net_octeontx2
EAL: PCI device 0002:01:01.0 on NUMA socket 0
EAL:   probe driver: 177d:a0f8 net_octeontx2
EAL: PCI device 0002:01:01.1 on NUMA socket 0
EAL:   probe driver: 177d:a0f8 net_octeontx2
EAL: PCI device 0002:01:01.2 on NUMA socket 0
EAL:   probe driver: 177d:a0f8 net_octeontx2
EAL: PCI device 0002:01:01.3 on NUMA socket 0
EAL:   probe driver: 177d:a0f8 net_octeontx2
EAL: PCI device 0002:01:01.4 on NUMA socket 0
EAL:   probe driver: 177d:a0f8 net_octeontx2
EAL: PCI device 0002:01:01.5 on NUMA socket 0
EAL:   probe driver: 177d:a0f8 net_octeontx2
EAL: PCI device 0002:01:01.6 on NUMA socket 0
EAL:   probe driver: 177d:a0f8 net_octeontx2
EAL: PCI device 0002:01:01.7 on NUMA socket 0
EAL:   probe driver: 177d:a0f8 net_octeontx2
EAL: PCI device 0002:01:02.0 on NUMA socket 0
EAL:   probe driver: 177d:a0f8 net_octeontx2
EAL: PCI device 0002:02:00.0 on NUMA socket 0
EAL:   probe driver: 177d:a063 net_octeontx2
EAL:   using IOMMU type 1 (Type 1)
EAL: PCI device 0002:03:00.0 on NUMA socket 0
EAL:   probe driver: 177d:a063 net_octeontx2
EAL: PCI device 0002:04:00.0 on NUMA socket 0
EAL:   probe driver: 177d:a063 net_octeontx2
EAL: PCI device 0002:05:00.0 on NUMA socket 0
EAL:   probe driver: 177d:a063 net_octeontx2
EAL: PCI device 0002:06:00.0 on NUMA socket 0
EAL:   probe driver: 177d:a063 net_octeontx2
EAL: PCI device 0002:07:00.0 on NUMA socket 0
EAL:   probe driver: 177d:a063 net_octeontx2
EAL: PCI device 0002:08:00.0 on NUMA socket 0
EAL:   probe driver: 177d:a0f9 event_octeontx2
EAL: PCI device 0002:09:00.0 on NUMA socket 0
EAL:   probe driver: 177d:a0f9 event_octeontx2
EAL: PCI device 0002:0a:00.0 on NUMA socket 0
EAL:   probe driver: 177d:a0f9 event_octeontx2
EAL: PCI device 0002:0b:00.0 on NUMA socket 0
EAL:   probe driver: 177d:a0f9 event_octeontx2
EAL: PCI device 0002:0c:00.0 on NUMA socket 0
EAL:   probe driver: 177d:a0fb mempool_octeontx2
EAL: PCI device 0002:0d:00.0 on NUMA socket 0
EAL:   probe driver: 177d:a0fb mempool_octeontx2
EAL: PCI device 0002:0e:00.0 on NUMA socket 0
EAL:   probe driver: 177d:a0f9 event_octeontx2
EAL: PCI device 0002:0f:00.0 on NUMA socket 0
EAL:   probe driver: 177d:a0fb mempool_octeontx2
APP: HPET is not enabled, using TSC as default timer


>
>
>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [dpdk-dev] [PATCH] bus/pci: set boot-up log prints to absolute minimum
  2020-02-06 14:36   ` Jerin Jacob
@ 2020-04-25 20:12     ` Thomas Monjalon
  2020-04-26 17:42       ` Jerin Jacob
  0 siblings, 1 reply; 13+ messages in thread
From: Thomas Monjalon @ 2020-04-25 20:12 UTC (permalink / raw)
  To: Jerin Jacob; +Cc: dev, dpdk-dev, Olivier Matz, Jerin Jacob

06/02/2020 15:36, Jerin Jacob:
> On Thu, Feb 6, 2020 at 7:44 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > 21/01/2020 09:00, jerinj@marvell.com:
> > > From: Jerin Jacob <jerinj@marvell.com>
> > >
> > > Some machines may have a lot of PCI devices, logs from PCI probe
> > > creates a lot of clutter on boot-up, typically one needs
> > > to scroll the screen to find other issues in boot-up.
> > >
> > > This patch changes the loglevel of PCI probes to `debug`
> > > to reduce the clutter on default boot-up logs
> >
> > I think the PCI probe informations are... informational.
> > Maybe you are just not interested in info logs.
> > If this is the case, I suggest to change the log level at runtime.
> 
> I am wondering, what would be the right balance, Following is DPDK
> startup output from octeontx2[1]
> It creates a lot of clutter in the "default" boot up. Why not enable
> below prints using log level at runtime?
> I believe it comes as a debug category, i.e information required to
> debug if something is not working,
> dpdk bind script already lists what is bound to DPDK.
> 
> Suggestion to remove clutter?

I suggest using dynamic log level in the PCI driver.
Unfortunately a lot of old DPDK code is still using the old log macros.
Some cleanup work is needed here.



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [dpdk-dev] [PATCH] bus/pci: set boot-up log prints to absolute minimum
  2020-04-25 20:12     ` Thomas Monjalon
@ 2020-04-26 17:42       ` Jerin Jacob
  2020-04-26 18:06         ` Thomas Monjalon
  0 siblings, 1 reply; 13+ messages in thread
From: Jerin Jacob @ 2020-04-26 17:42 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: Jerin Jacob, dpdk-dev, Olivier Matz

On Sun, Apr 26, 2020 at 1:42 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 06/02/2020 15:36, Jerin Jacob:
> > On Thu, Feb 6, 2020 at 7:44 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > 21/01/2020 09:00, jerinj@marvell.com:
> > > > From: Jerin Jacob <jerinj@marvell.com>
> > > >
> > > > Some machines may have a lot of PCI devices, logs from PCI probe
> > > > creates a lot of clutter on boot-up, typically one needs
> > > > to scroll the screen to find other issues in boot-up.
> > > >
> > > > This patch changes the loglevel of PCI probes to `debug`
> > > > to reduce the clutter on default boot-up logs
> > >
> > > I think the PCI probe informations are... informational.
> > > Maybe you are just not interested in info logs.
> > > If this is the case, I suggest to change the log level at runtime.
> >
> > I am wondering, what would be the right balance, Following is DPDK
> > startup output from octeontx2[1]
> > It creates a lot of clutter in the "default" boot up. Why not enable
> > below prints using log level at runtime?
> > I believe it comes as a debug category, i.e information required to
> > debug if something is not working,
> > dpdk bind script already lists what is bound to DPDK.
> >
> > Suggestion to remove clutter?
>
> I suggest using dynamic log level in the PCI driver.
> Unfortunately a lot of old DPDK code is still using the old log macros.
> Some cleanup work is needed here.

Sent an alternative fix to skip probing the devices with RTE_KDRV_NONE.
I think that is the source of the problem.
http://patches.dpdk.org/patch/69351/


>
>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [dpdk-dev] [PATCH] bus/pci: set boot-up log prints to absolute minimum
  2020-04-26 17:42       ` Jerin Jacob
@ 2020-04-26 18:06         ` Thomas Monjalon
  2020-04-26 18:48           ` Jerin Jacob
  0 siblings, 1 reply; 13+ messages in thread
From: Thomas Monjalon @ 2020-04-26 18:06 UTC (permalink / raw)
  To: Jerin Jacob; +Cc: Jerin Jacob, dpdk-dev, Olivier Matz

26/04/2020 19:42, Jerin Jacob:
> On Sun, Apr 26, 2020 at 1:42 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> > 06/02/2020 15:36, Jerin Jacob:
> > > On Thu, Feb 6, 2020 at 7:44 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > > 21/01/2020 09:00, jerinj@marvell.com:
> > > > > From: Jerin Jacob <jerinj@marvell.com>
> > > > >
> > > > > Some machines may have a lot of PCI devices, logs from PCI probe
> > > > > creates a lot of clutter on boot-up, typically one needs
> > > > > to scroll the screen to find other issues in boot-up.
> > > > >
> > > > > This patch changes the loglevel of PCI probes to `debug`
> > > > > to reduce the clutter on default boot-up logs
> > > >
> > > > I think the PCI probe informations are... informational.
> > > > Maybe you are just not interested in info logs.
> > > > If this is the case, I suggest to change the log level at runtime.
> > >
> > > I am wondering, what would be the right balance, Following is DPDK
> > > startup output from octeontx2[1]
> > > It creates a lot of clutter in the "default" boot up. Why not enable
> > > below prints using log level at runtime?
> > > I believe it comes as a debug category, i.e information required to
> > > debug if something is not working,
> > > dpdk bind script already lists what is bound to DPDK.
> > >
> > > Suggestion to remove clutter?
> >
> > I suggest using dynamic log level in the PCI driver.
> > Unfortunately a lot of old DPDK code is still using the old log macros.
> > Some cleanup work is needed here.
> 
> Sent an alternative fix to skip probing the devices with RTE_KDRV_NONE.

No, a PCI PMD can work without a known kernel driver.
This is the case of mlx4/mlx5.

> I think that is the source of the problem.
> http://patches.dpdk.org/patch/69351/

The source of the problem is just changing log levels dynamically
is not possible currently with PCI driver logs.



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [dpdk-dev] [PATCH] bus/pci: set boot-up log prints to absolute minimum
  2020-04-26 18:06         ` Thomas Monjalon
@ 2020-04-26 18:48           ` Jerin Jacob
  2020-04-26 19:56             ` Thomas Monjalon
  0 siblings, 1 reply; 13+ messages in thread
From: Jerin Jacob @ 2020-04-26 18:48 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: Jerin Jacob, dpdk-dev, Olivier Matz

On Sun, Apr 26, 2020 at 11:37 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 26/04/2020 19:42, Jerin Jacob:
> > On Sun, Apr 26, 2020 at 1:42 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > 06/02/2020 15:36, Jerin Jacob:
> > > > On Thu, Feb 6, 2020 at 7:44 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > > > 21/01/2020 09:00, jerinj@marvell.com:
> > > > > > From: Jerin Jacob <jerinj@marvell.com>
> > > > > >
> > > > > > Some machines may have a lot of PCI devices, logs from PCI probe
> > > > > > creates a lot of clutter on boot-up, typically one needs
> > > > > > to scroll the screen to find other issues in boot-up.
> > > > > >
> > > > > > This patch changes the loglevel of PCI probes to `debug`
> > > > > > to reduce the clutter on default boot-up logs
> > > > >
> > > > > I think the PCI probe informations are... informational.
> > > > > Maybe you are just not interested in info logs.
> > > > > If this is the case, I suggest to change the log level at runtime.
> > > >
> > > > I am wondering, what would be the right balance, Following is DPDK
> > > > startup output from octeontx2[1]
> > > > It creates a lot of clutter in the "default" boot up. Why not enable
> > > > below prints using log level at runtime?
> > > > I believe it comes as a debug category, i.e information required to
> > > > debug if something is not working,
> > > > dpdk bind script already lists what is bound to DPDK.
> > > >
> > > > Suggestion to remove clutter?
> > >
> > > I suggest using dynamic log level in the PCI driver.
> > > Unfortunately a lot of old DPDK code is still using the old log macros.
> > > Some cleanup work is needed here.
> >
> > Sent an alternative fix to skip probing the devices with RTE_KDRV_NONE.
>
> No, a PCI PMD can work without a known kernel driver.
> This is the case of mlx4/mlx5.

Yes. it can work with UNKNOWN, But It not with NONE.

>
> > I think that is the source of the problem.
> > http://patches.dpdk.org/patch/69351/
>
> The source of the problem is just changing log levels dynamically
> is not possible currently with PCI driver logs.

Assuming if we add, dynamic stuff what would the default log level for
RTE_LOG(INFO, EAL, "PCI device "PCI_PRI_FMT" on NUMA socket %i\n",

If it is INFO, Still the problem persist in the default bootup. Right?




>
>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [dpdk-dev] [PATCH] bus/pci: set boot-up log prints to absolute minimum
  2020-04-26 18:48           ` Jerin Jacob
@ 2020-04-26 19:56             ` Thomas Monjalon
  2020-04-27 18:02               ` Jerin Jacob
  0 siblings, 1 reply; 13+ messages in thread
From: Thomas Monjalon @ 2020-04-26 19:56 UTC (permalink / raw)
  To: Jerin Jacob; +Cc: Jerin Jacob, dpdk-dev, Olivier Matz

26/04/2020 20:48, Jerin Jacob:
> On Sun, Apr 26, 2020 at 11:37 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > 26/04/2020 19:42, Jerin Jacob:
> > > On Sun, Apr 26, 2020 at 1:42 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > > 06/02/2020 15:36, Jerin Jacob:
> > > > > On Thu, Feb 6, 2020 at 7:44 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > > > > 21/01/2020 09:00, jerinj@marvell.com:
> > > > > > > From: Jerin Jacob <jerinj@marvell.com>
> > > > > > >
> > > > > > > Some machines may have a lot of PCI devices, logs from PCI probe
> > > > > > > creates a lot of clutter on boot-up, typically one needs
> > > > > > > to scroll the screen to find other issues in boot-up.
> > > > > > >
> > > > > > > This patch changes the loglevel of PCI probes to `debug`
> > > > > > > to reduce the clutter on default boot-up logs
> > > > > >
> > > > > > I think the PCI probe informations are... informational.
> > > > > > Maybe you are just not interested in info logs.
> > > > > > If this is the case, I suggest to change the log level at runtime.
> > > > >
> > > > > I am wondering, what would be the right balance, Following is DPDK
> > > > > startup output from octeontx2[1]
> > > > > It creates a lot of clutter in the "default" boot up. Why not enable
> > > > > below prints using log level at runtime?
> > > > > I believe it comes as a debug category, i.e information required to
> > > > > debug if something is not working,
> > > > > dpdk bind script already lists what is bound to DPDK.
> > > > >
> > > > > Suggestion to remove clutter?
> > > >
> > > > I suggest using dynamic log level in the PCI driver.
> > > > Unfortunately a lot of old DPDK code is still using the old log macros.
> > > > Some cleanup work is needed here.
> > >
> > > Sent an alternative fix to skip probing the devices with RTE_KDRV_NONE.
> >
> > No, a PCI PMD can work without a known kernel driver.
> > This is the case of mlx4/mlx5.
> 
> Yes. it can work with UNKNOWN, But It not with NONE.
> 
> > > I think that is the source of the problem.
> > > http://patches.dpdk.org/patch/69351/
> >
> > The source of the problem is just changing log levels dynamically
> > is not possible currently with PCI driver logs.
> 
> Assuming if we add, dynamic stuff what would the default log level for
> RTE_LOG(INFO, EAL, "PCI device "PCI_PRI_FMT" on NUMA socket %i\n",
> 
> If it is INFO, Still the problem persist in the default bootup. Right?

Yes

We need to know in INFO level which devices are successfully probed.
You want to decrease to DEBUG the level of logs announcing a probe.
I think it would be OK if adding an INFO log after probe success.




^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [dpdk-dev] [PATCH] bus/pci: set boot-up log prints to absolute minimum
  2020-04-26 19:56             ` Thomas Monjalon
@ 2020-04-27 18:02               ` Jerin Jacob
  0 siblings, 0 replies; 13+ messages in thread
From: Jerin Jacob @ 2020-04-27 18:02 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: Jerin Jacob, dpdk-dev, Olivier Matz

On Mon, Apr 27, 2020 at 1:26 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 26/04/2020 20:48, Jerin Jacob:
> > On Sun, Apr 26, 2020 at 11:37 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > 26/04/2020 19:42, Jerin Jacob:
> > > > On Sun, Apr 26, 2020 at 1:42 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > > > 06/02/2020 15:36, Jerin Jacob:
> > > > > > On Thu, Feb 6, 2020 at 7:44 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > > > > > 21/01/2020 09:00, jerinj@marvell.com:
> > > > > > > > From: Jerin Jacob <jerinj@marvell.com>
> > > > > > > >
> > > > > > > > Some machines may have a lot of PCI devices, logs from PCI probe
> > > > > > > > creates a lot of clutter on boot-up, typically one needs
> > > > > > > > to scroll the screen to find other issues in boot-up.
> > > > > > > >
> > > > > > > > This patch changes the loglevel of PCI probes to `debug`
> > > > > > > > to reduce the clutter on default boot-up logs
> > > > > > >
> > > > > > > I think the PCI probe informations are... informational.
> > > > > > > Maybe you are just not interested in info logs.
> > > > > > > If this is the case, I suggest to change the log level at runtime.
> > > > > >
> > > > > > I am wondering, what would be the right balance, Following is DPDK
> > > > > > startup output from octeontx2[1]
> > > > > > It creates a lot of clutter in the "default" boot up. Why not enable
> > > > > > below prints using log level at runtime?
> > > > > > I believe it comes as a debug category, i.e information required to
> > > > > > debug if something is not working,
> > > > > > dpdk bind script already lists what is bound to DPDK.
> > > > > >
> > > > > > Suggestion to remove clutter?
> > > > >
> > > > > I suggest using dynamic log level in the PCI driver.
> > > > > Unfortunately a lot of old DPDK code is still using the old log macros.
> > > > > Some cleanup work is needed here.
> > > >
> > > > Sent an alternative fix to skip probing the devices with RTE_KDRV_NONE.
> > >
> > > No, a PCI PMD can work without a known kernel driver.
> > > This is the case of mlx4/mlx5.
> >
> > Yes. it can work with UNKNOWN, But It not with NONE.
> >
> > > > I think that is the source of the problem.
> > > > http://patches.dpdk.org/patch/69351/
> > >
> > > The source of the problem is just changing log levels dynamically
> > > is not possible currently with PCI driver logs.
> >
> > Assuming if we add, dynamic stuff what would the default log level for
> > RTE_LOG(INFO, EAL, "PCI device "PCI_PRI_FMT" on NUMA socket %i\n",
> >
> > If it is INFO, Still the problem persist in the default bootup. Right?
>
> Yes
>
> We need to know in INFO level which devices are successfully probed.
> You want to decrease to DEBUG the level of logs announcing a probe.
> I think it would be OK if adding an INFO log after probe success.

OK. I will send the v2 by changing the existing one as DEBUG and a
successful probe as INFO.



>
>
>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [dpdk-dev] [PATCH v2] bus/pci: set boot-up log prints to absolute minimum
  2020-01-21  8:00 [dpdk-dev] [PATCH] bus/pci: set boot-up log prints to absolute minimum jerinj
  2020-02-06 14:14 ` Thomas Monjalon
@ 2020-05-04 13:26 ` jerinj
  2020-05-07 13:54   ` Jerin Jacob
  1 sibling, 1 reply; 13+ messages in thread
From: jerinj @ 2020-05-04 13:26 UTC (permalink / raw)
  Cc: dev, thomas, david.marchand, Jerin Jacob

From: Jerin Jacob <jerinj@marvell.com>

Some machines may have a lot of PCI devices and all of them are
not bound to DPDK. In such case the logs from EAL creates a lot of
clutter on boot-up, typically one needs to scroll the screen to
find other issues in boot-up.

This patch changes the following to reduce the clutter in
the default boot-up logs.

- Change the log-level of PCI probes to `debug`
- Introduce new driver probe as `info` log-level for the successful probe.

Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
v2:
- Introduce new driver probe as `info` log-level for the successful
  probe(Thomas)

 drivers/bus/pci/pci_common.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
index 3f5542076..6585a4b47 100644
--- a/drivers/bus/pci/pci_common.c
+++ b/drivers/bus/pci/pci_common.c
@@ -136,7 +136,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
 		/* Match of device and driver failed */
 		return 1;

-	RTE_LOG(INFO, EAL, "PCI device "PCI_PRI_FMT" on NUMA socket %i\n",
+	RTE_LOG(DEBUG, EAL, "PCI device "PCI_PRI_FMT" on NUMA socket %i\n",
 			loc->domain, loc->bus, loc->devid, loc->function,
 			dev->device.numa_node);

@@ -161,7 +161,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
 		return -EEXIST;
 	}

-	RTE_LOG(INFO, EAL, "  probe driver: %x:%x %s\n", dev->id.vendor_id,
+	RTE_LOG(DEBUG, EAL, "  probe driver: %x:%x %s\n", dev->id.vendor_id,
 		dev->id.device_id, dr->driver.name);

 	/*
@@ -195,6 +195,10 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
 		}
 	}

+	RTE_LOG(INFO, EAL, "Probe PCI driver: %s (%x:%x) device: "PCI_PRI_FMT" (socket %i)\n",
+			dr->driver.name, dev->id.vendor_id, dev->id.device_id,
+			loc->domain, loc->bus, loc->devid, loc->function,
+			dev->device.numa_node);
 	/* call the driver probe() function */
 	ret = dr->probe(dr, dev);
 	if (already_probed)
--
2.26.2


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [dpdk-dev] [PATCH v2] bus/pci: set boot-up log prints to absolute minimum
  2020-05-04 13:26 ` [dpdk-dev] [PATCH v2] " jerinj
@ 2020-05-07 13:54   ` Jerin Jacob
  2020-05-07 15:36     ` Thomas Monjalon
  0 siblings, 1 reply; 13+ messages in thread
From: Jerin Jacob @ 2020-05-07 13:54 UTC (permalink / raw)
  To: Jerin Jacob; +Cc: dpdk-dev, Thomas Monjalon, David Marchand

On Mon, May 4, 2020 at 6:56 PM <jerinj@marvell.com> wrote:
>
> From: Jerin Jacob <jerinj@marvell.com>
>
> Some machines may have a lot of PCI devices and all of them are
> not bound to DPDK. In such case the logs from EAL creates a lot of
> clutter on boot-up, typically one needs to scroll the screen to
> find other issues in boot-up.
>
> This patch changes the following to reduce the clutter in
> the default boot-up logs.
>
> - Change the log-level of PCI probes to `debug`
> - Introduce new driver probe as `info` log-level for the successful probe.
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
> v2:
> - Introduce new driver probe as `info` log-level for the successful
>   probe(Thomas)


Thomas,
Could you review and merge this for RC2.
I have addressed the comments. Limited the default prints to successful probe().


>
>  drivers/bus/pci/pci_common.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
> index 3f5542076..6585a4b47 100644
> --- a/drivers/bus/pci/pci_common.c
> +++ b/drivers/bus/pci/pci_common.c
> @@ -136,7 +136,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
>                 /* Match of device and driver failed */
>                 return 1;
>
> -       RTE_LOG(INFO, EAL, "PCI device "PCI_PRI_FMT" on NUMA socket %i\n",
> +       RTE_LOG(DEBUG, EAL, "PCI device "PCI_PRI_FMT" on NUMA socket %i\n",
>                         loc->domain, loc->bus, loc->devid, loc->function,
>                         dev->device.numa_node);
>
> @@ -161,7 +161,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
>                 return -EEXIST;
>         }
>
> -       RTE_LOG(INFO, EAL, "  probe driver: %x:%x %s\n", dev->id.vendor_id,
> +       RTE_LOG(DEBUG, EAL, "  probe driver: %x:%x %s\n", dev->id.vendor_id,
>                 dev->id.device_id, dr->driver.name);
>
>         /*
> @@ -195,6 +195,10 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
>                 }
>         }
>
> +       RTE_LOG(INFO, EAL, "Probe PCI driver: %s (%x:%x) device: "PCI_PRI_FMT" (socket %i)\n",
> +                       dr->driver.name, dev->id.vendor_id, dev->id.device_id,
> +                       loc->domain, loc->bus, loc->devid, loc->function,
> +                       dev->device.numa_node);
>         /* call the driver probe() function */
>         ret = dr->probe(dr, dev);
>         if (already_probed)
> --
> 2.26.2
>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [dpdk-dev] [PATCH v2] bus/pci: set boot-up log prints to absolute minimum
  2020-05-07 13:54   ` Jerin Jacob
@ 2020-05-07 15:36     ` Thomas Monjalon
  2020-05-11 14:39       ` Thomas Monjalon
  0 siblings, 1 reply; 13+ messages in thread
From: Thomas Monjalon @ 2020-05-07 15:36 UTC (permalink / raw)
  To: Jerin Jacob, Jerin Jacob; +Cc: dpdk-dev, David Marchand

07/05/2020 15:54, Jerin Jacob:
> On Mon, May 4, 2020 at 6:56 PM <jerinj@marvell.com> wrote:
> >
> > From: Jerin Jacob <jerinj@marvell.com>
> >
> > Some machines may have a lot of PCI devices and all of them are
> > not bound to DPDK. In such case the logs from EAL creates a lot of
> > clutter on boot-up, typically one needs to scroll the screen to
> > find other issues in boot-up.
> >
> > This patch changes the following to reduce the clutter in
> > the default boot-up logs.
> >
> > - Change the log-level of PCI probes to `debug`
> > - Introduce new driver probe as `info` log-level for the successful probe.
> >
> > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> > ---
> > v2:
> > - Introduce new driver probe as `info` log-level for the successful
> >   probe(Thomas)
> 
> 
> Thomas,
> Could you review and merge this for RC2.
> I have addressed the comments. Limited the default prints to successful probe().

Yes it's in my list for -rc2.



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [dpdk-dev] [PATCH v2] bus/pci: set boot-up log prints to absolute minimum
  2020-05-07 15:36     ` Thomas Monjalon
@ 2020-05-11 14:39       ` Thomas Monjalon
  0 siblings, 0 replies; 13+ messages in thread
From: Thomas Monjalon @ 2020-05-11 14:39 UTC (permalink / raw)
  To: Jerin Jacob, Jerin Jacob; +Cc: dev, David Marchand

07/05/2020 17:36, Thomas Monjalon:
> 07/05/2020 15:54, Jerin Jacob:
> > On Mon, May 4, 2020 at 6:56 PM <jerinj@marvell.com> wrote:
> > >
> > > From: Jerin Jacob <jerinj@marvell.com>
> > >
> > > Some machines may have a lot of PCI devices and all of them are
> > > not bound to DPDK. In such case the logs from EAL creates a lot of
> > > clutter on boot-up, typically one needs to scroll the screen to
> > > find other issues in boot-up.
> > >
> > > This patch changes the following to reduce the clutter in
> > > the default boot-up logs.
> > >
> > > - Change the log-level of PCI probes to `debug`
> > > - Introduce new driver probe as `info` log-level for the successful probe.
> > >
> > > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> > > ---
> > > v2:
> > > - Introduce new driver probe as `info` log-level for the successful
> > >   probe(Thomas)
> > 
> > 
> > Thomas,
> > Could you review and merge this for RC2.
> > I have addressed the comments. Limited the default prints to successful probe().
> 
> Yes it's in my list for -rc2.

Applied, thanks



^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2020-05-11 14:39 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-21  8:00 [dpdk-dev] [PATCH] bus/pci: set boot-up log prints to absolute minimum jerinj
2020-02-06 14:14 ` Thomas Monjalon
2020-02-06 14:36   ` Jerin Jacob
2020-04-25 20:12     ` Thomas Monjalon
2020-04-26 17:42       ` Jerin Jacob
2020-04-26 18:06         ` Thomas Monjalon
2020-04-26 18:48           ` Jerin Jacob
2020-04-26 19:56             ` Thomas Monjalon
2020-04-27 18:02               ` Jerin Jacob
2020-05-04 13:26 ` [dpdk-dev] [PATCH v2] " jerinj
2020-05-07 13:54   ` Jerin Jacob
2020-05-07 15:36     ` Thomas Monjalon
2020-05-11 14:39       ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git