From: "Varghese, Vipin" <vipin.varghese@intel.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] app/pdump: add check for PCAP PMD
Date: Mon, 12 Mar 2018 17:46:13 +0000 [thread overview]
Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D19F6BB@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A2A642D@irsmsx110.ger.corp.intel.com>
Hi Reshma,
I tried your suggestion, but the build fails even using warning or not using warning. The reason is DPDK build expects pdump to be build.
I am looking at other alternatives, how to get this done. In last effort, we may need to disable PDUMP to be build default from '.config' file.
Thanks
Vipin Varghese
> -----Original Message-----
> From: Pattan, Reshma
> Sent: Tuesday, March 6, 2018 5:42 PM
> To: Varghese, Vipin <vipin.varghese@intel.com>; dev@dpdk.org
> Cc: Mcnamara, John <john.mcnamara@intel.com>
> Subject: RE: [PATCH v1] app/pdump: add check for PCAP PMD
>
> >
> > +ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),n) $(error "Please enable
> > +CONFIG_RTE_LIBRTE_PMD_PCAP") endif
> > +
>
> How about combining If(($(CONFIG_RTE_LIBRTE_PMD_PCAP),y) check with
> below existing if check?
> with this, dpdk-pdump will be compiled only when both the flags are enabled.
>
> > ifeq ($(CONFIG_RTE_LIBRTE_PDUMP),y)
> >
> > APP = dpdk-pdump
> > --
> > 1.9.1
prev parent reply other threads:[~2018-03-12 17:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 7:57 Vipin Varghese
2018-03-05 14:32 ` Ferruh Yigit
2018-03-06 8:45 ` Varghese, Vipin
2018-03-06 11:57 ` Ferruh Yigit
2018-03-06 12:12 ` Pattan, Reshma
2018-03-12 17:46 ` Varghese, Vipin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9E0AB70F954A408CC4ADDBF0F8FA7D4D19F6BB@BGSMSX101.gar.corp.intel.com \
--to=vipin.varghese@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).