Re: [dpdk-dev] [PATCH] doc/qos_meter: update application information

["Varghese, Vipin" <vipin.varghese@intel.com>]

Hi Cristian,

If rewording for 0 to GREEN was required option 'changes requested' would have been set. But since the state is been set to 'Rejected' I am confused what are the comments requesting for GREEN?

Thanks
Vipin Varghese

> -----Original Message-----
> From: Dumitrescu, Cristian
> Sent: Monday, October 15, 2018 9:25 PM
> To: Varghese, Vipin <vipin.varghese@intel.com>; dev@dpdk.org; Singh,
> Jasvinder <jasvinder.singh@intel.com>
> Cc: Byrne, Stephen1 <stephen1.byrne@intel.com>
> Subject: RE: [PATCH] doc/qos_meter: update application information
> 
> 
> 
> > -----Original Message-----
> > From: Varghese, Vipin
> > Sent: Friday, October 12, 2018 3:04 PM
> > To: dev@dpdk.org; Dumitrescu, Cristian
> > <cristian.dumitrescu@intel.com>; Singh, Jasvinder
> > <jasvinder.singh@intel.com>
> > Cc: Byrne, Stephen1 <stephen1.byrne@intel.com>; Varghese, Vipin
> > <vipin.varghese@intel.com>
> > Subject: [PATCH] doc/qos_meter: update application information
> >
> > THe change adds special note for colour blind and porfile_table
> > actions. In colour blind mode, the previous colour value is always 0.
> > For DROP action, one needs to edit the profile_table entries
> > apporpiately.
> >
> > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> > ---
> >  doc/guides/sample_app_ug/qos_metering.rst | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/doc/guides/sample_app_ug/qos_metering.rst
> > b/doc/guides/sample_app_ug/qos_metering.rst
> > index 6391841c6..1ec94b0b3 100644
> > --- a/doc/guides/sample_app_ug/qos_metering.rst
> > +++ b/doc/guides/sample_app_ug/qos_metering.rst
> > @@ -149,3 +149,8 @@ In this particular case:
> >  *   Every packet which color has improved is dropped (this particular case
> > can't happen, so these values will not be used).
> >
> >  *   For the rest of the cases, the color is changed to red.
> > +
> > +
> > +.. note::
> > +	* In color blind mode, first row is only valid as previous colour is 0.
> 
> Available colors are GREEN, YELLOW and RED, the color is not encoded with a
> numeric value such as 0. You might want to say GREEN?
> 
> > +	* To drop the packet, policer_table action has to be set to DROP.
> > --
> > 2.17.1