DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/mlx5: reduce log level in hlist registration
@ 2020-11-23 15:56 Matan Azrad
  2020-11-23 16:01 ` Asaf Penso
  2020-11-23 21:47 ` Slava Ovsiienko
  0 siblings, 2 replies; 4+ messages in thread
From: Matan Azrad @ 2020-11-23 15:56 UTC (permalink / raw)
  To: Viacheslav Ovsiienko; +Cc: dev, Thomas Monjalon

In mlx5 internal hash list tool, there is a log print when an entry
allocation is failed: Can't allocate hash list entry.

Some initialization checks triggers hash list registration in order to
check some capabilities. Here, the failure in registration doesn't
lead to failure in the initialization flow, that is why the log level
can be lower.

Move the entry allocation failure log to debug level.

Signed-off-by: Matan Azrad <matan@nvidia.com>
---
 drivers/net/mlx5/mlx5_utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_utils.c b/drivers/net/mlx5/mlx5_utils.c
index 9889437..848d108 100644
--- a/drivers/net/mlx5/mlx5_utils.c
+++ b/drivers/net/mlx5/mlx5_utils.c
@@ -156,7 +156,7 @@ struct mlx5_hlist_entry*
 	entry = h->cb_create(h, key, ctx);
 	if (!entry) {
 		rte_errno = ENOMEM;
-		DRV_LOG(ERR, "Can't allocate hash list %s entry.", h->name);
+		DRV_LOG(DEBUG, "Can't allocate hash list %s entry.", h->name);
 		goto done;
 	}
 	entry->key = key;
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: reduce log level in hlist registration
  2020-11-23 15:56 [dpdk-dev] [PATCH] net/mlx5: reduce log level in hlist registration Matan Azrad
@ 2020-11-23 16:01 ` Asaf Penso
  2020-11-23 21:47 ` Slava Ovsiienko
  1 sibling, 0 replies; 4+ messages in thread
From: Asaf Penso @ 2020-11-23 16:01 UTC (permalink / raw)
  To: Matan Azrad, Slava Ovsiienko; +Cc: dev, NBU-Contact-Thomas Monjalon



Regards,
Asaf Penso

>-----Original Message-----
>From: dev <dev-bounces@dpdk.org> On Behalf Of Matan Azrad
>Sent: Monday, November 23, 2020 5:57 PM
>To: Slava Ovsiienko <viacheslavo@nvidia.com>
>Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
>Subject: [dpdk-dev] [PATCH] net/mlx5: reduce log level in hlist registration
>
>In mlx5 internal hash list tool, there is a log print when an entry allocation is
>failed: Can't allocate hash list entry.
>
>Some initialization checks triggers hash list registration in order to check some
>capabilities. Here, the failure in registration doesn't lead to failure in the
>initialization flow, that is why the log level can be lower.
>
>Move the entry allocation failure log to debug level.
>
>Signed-off-by: Matan Azrad <matan@nvidia.com>
Reviewed-by: Asaf Penso <asafp@nvidia.com>

>---
> drivers/net/mlx5/mlx5_utils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/mlx5/mlx5_utils.c b/drivers/net/mlx5/mlx5_utils.c
>index 9889437..848d108 100644
>--- a/drivers/net/mlx5/mlx5_utils.c
>+++ b/drivers/net/mlx5/mlx5_utils.c
>@@ -156,7 +156,7 @@ struct mlx5_hlist_entry*
> 	entry = h->cb_create(h, key, ctx);
> 	if (!entry) {
> 		rte_errno = ENOMEM;
>-		DRV_LOG(ERR, "Can't allocate hash list %s entry.", h->name);
>+		DRV_LOG(DEBUG, "Can't allocate hash list %s entry.", h-
>>name);
> 		goto done;
> 	}
> 	entry->key = key;
>--
>1.8.3.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: reduce log level in hlist registration
  2020-11-23 15:56 [dpdk-dev] [PATCH] net/mlx5: reduce log level in hlist registration Matan Azrad
  2020-11-23 16:01 ` Asaf Penso
@ 2020-11-23 21:47 ` Slava Ovsiienko
  2020-11-24 22:29   ` Thomas Monjalon
  1 sibling, 1 reply; 4+ messages in thread
From: Slava Ovsiienko @ 2020-11-23 21:47 UTC (permalink / raw)
  To: Matan Azrad; +Cc: dev, NBU-Contact-Thomas Monjalon

> -----Original Message-----
> From: Matan Azrad <matan@nvidia.com>
> Sent: Monday, November 23, 2020 17:57
> To: Slava Ovsiienko <viacheslavo@nvidia.com>
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
> Subject: [PATCH] net/mlx5: reduce log level in hlist registration
> 
> In mlx5 internal hash list tool, there is a log print when an entry allocation is
> failed: Can't allocate hash list entry.
> 
> Some initialization checks triggers hash list registration in order to check some
> capabilities. Here, the failure in registration doesn't lead to failure in the
> initialization flow, that is why the log level can be lower.
> 
> Move the entry allocation failure log to debug level.
> 
> Signed-off-by: Matan Azrad <matan@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: reduce log level in hlist registration
  2020-11-23 21:47 ` Slava Ovsiienko
@ 2020-11-24 22:29   ` Thomas Monjalon
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2020-11-24 22:29 UTC (permalink / raw)
  To: Matan Azrad; +Cc: dev, Slava Ovsiienko, asafp

> > In mlx5 internal hash list tool, there is a log print when an entry allocation is
> > failed: Can't allocate hash list entry.
> > 
> > Some initialization checks triggers hash list registration in order to check some
> > capabilities. Here, the failure in registration doesn't lead to failure in the
> > initialization flow, that is why the log level can be lower.
> > 
> > Move the entry allocation failure log to debug level.
> > 
> > Signed-off-by: Matan Azrad <matan@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

Applied, thanks




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-11-24 22:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-23 15:56 [dpdk-dev] [PATCH] net/mlx5: reduce log level in hlist registration Matan Azrad
2020-11-23 16:01 ` Asaf Penso
2020-11-23 21:47 ` Slava Ovsiienko
2020-11-24 22:29   ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git