DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Chengchang Tang <tangchengchang@huawei.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
	dev@dpdk.org, linuxarm@huawei.com, arybchenko@solarflare.com
Subject: Re: [dpdk-dev] [RFC v2 0/3] add rx buffer size for rte_eth_rxq_info
Date: Tue, 28 Jul 2020 17:27:56 +0200
Message-ID: <6655202.xMAYDfDikD@thomas> (raw)
In-Reply-To: <e4237572-654b-699e-927a-9936a16022cd@huawei.com>

You're right pinging for reviews. That's the right time to look at
next features for those who have completed their 20.08 tasks.

Feel free to review other pending patches in the meantime.
Some of the next features are classified as "Deferred" in patchwork:
	https://patches.dpdk.org/project/dpdk/list/?state=10


28/07/2020 13:39, Chengchang Tang:
> Hi Ferruh,
> 
> Thank you for your reply. I'm sorry to bother you while you are busy with
> the release. I know this change may only be accepted in the next release.
> I'd like to know what the community thinks about it. If there is no
> objection, I will send the patch after current release out.
> 
> On 2020/7/28 17:30, Ferruh Yigit wrote:
> > On 7/28/2020 7:29 AM, Chengchang Tang wrote:
> >> Friendly ping
> > 
> > Hi Tang,
> > 
> > Sorry for not making it clear, since it is a library change, the change is
> > already late for this release (20.08), and it will be considered for next
> > release. As current release out, we can continue the discussions.
> > 
> >>
> >> On 2020/7/22 14:38, Chengchang Tang wrote:
> >>> In common practice, PMD configure the rx buffer size which indicate the
> >>> buffer length could be used for hw in receiving packts according to the
> >>> data room size of the object in mempool. But in fact the final value is
> >>> related to the specifications of hw, and its values will affect the number
> >>> of fragments in recieving pkts when scatter is enabled. By the way, some
> >>> PMDs may force to enable scatter when the MTU is bigger than the hw rx
> >>> buffer size.
> >>>
> >>> At present, we seem to have no way to expose relevant information to upper
> >>> layer users.
> >>>
> >>> So, add a field named rx_buf_size in rte_eth_rxq_info to indicate the
> >>> buffer size used in recieving pkts for hw. And this patchset also add hns3
> >>> PMD implementation and update the testpmd to clarify intention.
> >>>
> >>> v2:
> >>> Add hns3 implementation and update testpmd.
> >>>
> >>> Chengchang Tang (2):
> >>>   ethdev: add a field for rte_eth_rxq_info
> >>>   app/testpmd: Add RX buffer size dispaly in queue info querry
> >>>
> >>> Huisong Li (1):
> >>>   net/hns3: add support for query of rx/tx queue info
> >>>
> >>>  app/test-pmd/config.c             |  1 +
> >>>  drivers/net/hns3/hns3_ethdev.c    |  2 ++
> >>>  drivers/net/hns3/hns3_ethdev_vf.c |  2 ++
> >>>  drivers/net/hns3/hns3_rxtx.c      | 48 +++++++++++++++++++++++++++++++++++++++
> >>>  drivers/net/hns3/hns3_rxtx.h      |  4 ++++
> >>>  lib/librte_ethdev/rte_ethdev.h    |  2 ++
> >>>  6 files changed, 59 insertions(+)
> >>>
> >>> --
> >>> 2.7.4
> >>>
> >>> _______________________________________________
> >>> Linuxarm mailing list
> >>> Linuxarm@huawei.com
> >>> http://hulk.huawei.com/mailman/listinfo/linuxarm
> >>>
> >>> .
> >>>
> >>
> > 
> > 
> > .
> > 
> 
> 






      reply	other threads:[~2020-07-28 15:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-23  6:48 [dpdk-dev] [RFC] ethdev: add a field " Chengchang Tang
2020-06-23  9:30 ` Andrew Rybchenko
2020-06-24  3:48   ` Chengchang Tang
2020-06-24  8:52     ` Ferruh Yigit
2020-06-24 18:32       ` Ferruh Yigit
2020-06-25  9:06         ` Andrew Rybchenko
2020-06-23 14:48 ` Stephen Hemminger
2020-06-23 15:22   ` Andrew Rybchenko
2020-07-22  6:38 ` [dpdk-dev] [RFC v2 0/3] add rx buffer size " Chengchang Tang
2020-07-22  6:38   ` [dpdk-dev] [RFC v2 1/3] ethdev: add a field " Chengchang Tang
2020-07-22  6:38   ` [dpdk-dev] [RFC v2 2/3] net/hns3: add support for query of rx/tx queue info Chengchang Tang
2020-07-22  6:38   ` [dpdk-dev] [RFC v2 3/3] app/testpmd: Add RX buffer size dispaly in queue info querry Chengchang Tang
2020-07-28  6:29   ` [dpdk-dev] [RFC v2 0/3] add rx buffer size for rte_eth_rxq_info Chengchang Tang
2020-07-28  9:30     ` Ferruh Yigit
2020-07-28 11:39       ` Chengchang Tang
2020-07-28 15:27         ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6655202.xMAYDfDikD@thomas \
    --to=thomas@monjalon.net \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=linuxarm@huawei.com \
    --cc=tangchengchang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git