* [dpdk-dev] [PATCH v1] net/tap: fix report on multi segments capability
@ 2018-02-05 10:59 Ophir Munk
2018-02-05 14:53 ` Pascal Mazon
0 siblings, 1 reply; 3+ messages in thread
From: Ophir Munk @ 2018-02-05 10:59 UTC (permalink / raw)
To: dev, Pascal Mazon; +Cc: Thomas Monjalon, Olga Shern, Ophir Munk, stable
TAP device is supporting multi segments Tx, however this capability is
not reported when querying the TAP device.
This commit adds this capability report.
Fixes: 818fe14a9891 ("net/tap: use new Tx offloads API")
Cc: stable@dpdk.org
Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
---
drivers/net/tap/rte_eth_tap.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index dc3847e..ac43db4 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -390,7 +390,8 @@ tap_tx_offload_get_port_capa(void)
* In order to support legacy apps,
* report capabilities also as port capabilities.
*/
- return DEV_TX_OFFLOAD_IPV4_CKSUM |
+ return DEV_TX_OFFLOAD_MULTI_SEGS |
+ DEV_TX_OFFLOAD_IPV4_CKSUM |
DEV_TX_OFFLOAD_UDP_CKSUM |
DEV_TX_OFFLOAD_TCP_CKSUM;
}
@@ -398,7 +399,8 @@ tap_tx_offload_get_port_capa(void)
static uint64_t
tap_tx_offload_get_queue_capa(void)
{
- return DEV_TX_OFFLOAD_IPV4_CKSUM |
+ return DEV_TX_OFFLOAD_MULTI_SEGS |
+ DEV_TX_OFFLOAD_IPV4_CKSUM |
DEV_TX_OFFLOAD_UDP_CKSUM |
DEV_TX_OFFLOAD_TCP_CKSUM;
}
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH v1] net/tap: fix report on multi segments capability
2018-02-05 10:59 [dpdk-dev] [PATCH v1] net/tap: fix report on multi segments capability Ophir Munk
@ 2018-02-05 14:53 ` Pascal Mazon
2018-02-05 18:02 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Pascal Mazon @ 2018-02-05 14:53 UTC (permalink / raw)
To: Ophir Munk, dev; +Cc: Thomas Monjalon, Olga Shern, stable
Acked-by: Pascal Mazon <pascal.mazon@6wind.com>
On 05/02/2018 11:59, Ophir Munk wrote:
> TAP device is supporting multi segments Tx, however this capability is
> not reported when querying the TAP device.
> This commit adds this capability report.
>
> Fixes: 818fe14a9891 ("net/tap: use new Tx offloads API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> ---
> drivers/net/tap/rte_eth_tap.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index dc3847e..ac43db4 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -390,7 +390,8 @@ tap_tx_offload_get_port_capa(void)
> * In order to support legacy apps,
> * report capabilities also as port capabilities.
> */
> - return DEV_TX_OFFLOAD_IPV4_CKSUM |
> + return DEV_TX_OFFLOAD_MULTI_SEGS |
> + DEV_TX_OFFLOAD_IPV4_CKSUM |
> DEV_TX_OFFLOAD_UDP_CKSUM |
> DEV_TX_OFFLOAD_TCP_CKSUM;
> }
> @@ -398,7 +399,8 @@ tap_tx_offload_get_port_capa(void)
> static uint64_t
> tap_tx_offload_get_queue_capa(void)
> {
> - return DEV_TX_OFFLOAD_IPV4_CKSUM |
> + return DEV_TX_OFFLOAD_MULTI_SEGS |
> + DEV_TX_OFFLOAD_IPV4_CKSUM |
> DEV_TX_OFFLOAD_UDP_CKSUM |
> DEV_TX_OFFLOAD_TCP_CKSUM;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH v1] net/tap: fix report on multi segments capability
2018-02-05 14:53 ` Pascal Mazon
@ 2018-02-05 18:02 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-02-05 18:02 UTC (permalink / raw)
To: Pascal Mazon, Ophir Munk, dev; +Cc: Thomas Monjalon, Olga Shern, stable
On 2/5/2018 2:53 PM, Pascal Mazon wrote:
>
> On 05/02/2018 11:59, Ophir Munk wrote:
>> TAP device is supporting multi segments Tx, however this capability is
>> not reported when querying the TAP device.
>> This commit adds this capability report.
>>
>> Fixes: 818fe14a9891 ("net/tap: use new Tx offloads API")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> Acked-by: Pascal Mazon <pascal.mazon@6wind.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-05 18:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-05 10:59 [dpdk-dev] [PATCH v1] net/tap: fix report on multi segments capability Ophir Munk
2018-02-05 14:53 ` Pascal Mazon
2018-02-05 18:02 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).