Re: [dpdk-dev] [PATCH] test/ipsec: fix test suite setup function

["Iremonger, Bernard" <bernard.iremonger@intel.com>]

Hi Konstantin,

<snip>

> > > > > I think you need to check driver capabilities, instead of
> > > > > relying on driver
> > > name.
> > > >
> > > > I don't think it is necessary to check the driver capabilities.
> > >
> > > I still think that the valid way to check supported algorithms is to
> > > check device capabilities, not the driver name.
> >
> > In the testsuite_setup() function the parameters for the
> > check_cryptodev_capability() are not setup. They are setup in the test
> functions of the testsuite.
> 
> Ok, so what prevents us to setup them earlier?

This will require some refactoring of the tests, I will investigate.

<snip>

> > As discussed offline it should be sufficient to test with the crypto_dev NULL
> PMD.
> 
> As we discussed  offline - yes, I don't think it's too excessive to verify
> ipsec_autotest with each existing driver that supports _NULL algs, but I don't
> see the reason why it shouldn't support anything except crypto_null.
> Konstantin

Ok, I will investigate what needs to be done.

Regards,

Bernard.