DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: oulijun <oulijun@huawei.com>, David Marchand <david.marchand@redhat.com>
Cc: Van Haaren Harry <harry.van.haaren@intel.com>, dev <dev@dpdk.org>,
	David Hunt <david.hunt@intel.com>,
	"Pattan, Reshma" <reshma.pattan@intel.com>
Subject: Re: [dpdk-dev] 【BUG REPORT】l3fwd-power can not exit by ctrl+c
Date: Fri, 22 May 2020 10:00:20 +0100
Message-ID: <8e8d4052-7d2d-6e1a-6cac-0c04f8d236f0@intel.com> (raw)
In-Reply-To: <b334130d-29cd-98f3-65f0-a9925d1c73cb@huawei.com>

On 22-May-20 9:17 AM, oulijun wrote:
> 
> 
> 在 2020/5/20 15:22, David Marchand 写道:
>> Hello,
>>
>> On Wed, May 20, 2020 at 5:18 AM oulijun <oulijun@huawei.com> wrote:
>>>      I am using 20.05-rc2 version to test based on HNS3 NIC hardware, 
>>> and
>>> found that after starting l3fwd-power,
>>>
>>> using ctrl+c cannot force quit. But I revert the patch(33666b4 service:
>>> fix crash on exit) and it is ok.
>>
>> We had a fix in rc1 that is supposed to fix this.
>> https://git.dpdk.org/dpdk/commit?id=613ce6691c0d5ac0f99d7995f1e8e4ac86643882 
>>
>>
>> Copying Anatoly and David H. too.
>>
> Hi, David Marchand
>     I am only merged the patch(examples/l3fwd-power: implement proper 
> shutdown) based on 20.05-rc0 and test.

Why are you testing 20.05-rc0 when there is a later version that already 
has all of this fixed? What's the point of creating additional 
difficulties for yourself, and, more importantly, reporting bugs to the 
community that are already fixed while also not testing the version that 
has those fixes? What are you trying to do that requires you to use rc0 
instead of rc2 or later?

We know rc0 was buggy. We had one patch (linked to by David above) in 
rc1 that fixed it. We had another one in rc2 (linked by myself in 
another email: 
https://git.dpdk.org/dpdk/commit/?id=f4d1e19c293dc95073614f630ea729cf0bfb57b7) 
which completed the fix. Both of these patches are present in rc2 and 
later. So why not try and test rc2 or laster, instead of cherry-picking 
patches on top of rc0?

  the bug is not resolved.
> Can you provide me with complete solution?  I want to understand the 
> cause of the whole problem
> 

The cause of the problem is described in the commit messages for the 
patches. The one David linked to was because l3fwd was exiting 
incorrectly and was relying on particulars of implementation of 
rte_exit() which exited the application straight away, without waiting 
for threads to finish. The one i linked to fixed an additional issue 
related to waiting for interrupts - there was no timeout, so the thread 
never woke up if there was no traffic, and thus rte_exit() couldn't 
finish as well.

All of the above was fixed by rc2, and later versions have these fixes 
as well. So, why are you insisting on using an outdated version for testing?

-- 
Thanks,
Anatoly

  reply	other threads:[~2020-05-22  9:00 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-20  3:18 oulijun
2020-05-20  7:22 ` David Marchand
2020-05-20  8:41   ` oulijun
2020-05-20  8:49     ` David Marchand
2020-05-20 11:37     ` Burakov, Anatoly
2020-05-22  8:17   ` oulijun
2020-05-22  9:00     ` Burakov, Anatoly [this message]
2020-05-22  9:02     ` Hunt, David
2020-05-26  3:50       ` oulijun
2020-05-26  8:36         ` Hunt, David
2020-05-26  9:11           ` oulijun
2020-05-27  6:10           ` oulijun
2020-05-27  8:21             ` Hunt, David
2020-05-26  9:24         ` Burakov, Anatoly
2020-05-27  6:04           ` oulijun
2020-05-27  8:57             ` Burakov, Anatoly
2020-05-20  9:45 ` Burakov, Anatoly
2020-05-21  1:26   ` oulijun
2020-05-21 10:46     ` Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e8d4052-7d2d-6e1a-6cac-0c04f8d236f0@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=david.hunt@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    --cc=oulijun@huawei.com \
    --cc=reshma.pattan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git