* [RFC] fix semicolon at the end of RTE_LOG_REGISTER_DEFAULT
@ 2024-04-20 0:08 Stephen Hemminger
2024-04-20 7:48 ` Morten Brørup
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2024-04-20 0:08 UTC (permalink / raw)
To: dev
Cc: Stephen Hemminger, Nicolas Chautru, Gagandeep Singh,
Hemant Agrawal, Parav Pandit, Xueming Li, Nipun Gupta,
Nikhil Agarwal, Sachin Saxena, Rosen Xu, Tomasz Duszynski,
Chengwen Feng, Long Li, Nithin Dabilpuram, Kiran Kumar K,
Sunil Kumar Kori, Satha Rao, Harman Kalra, Jingjing Wu,
Nagadheeraj Rottela, Srikanth Jampala, Andrew Rybchenko,
Lee Daly, Pablo de Lara, Fan Zhang, Ashish Gupta, Sunila Sahu,
Ruifeng Wang, Michael Shamis, Liron Himi, Kai Ji, Anoob Joseph,
Zhangfei Gao, Bruce Richardson, Kevin Laatz, Conor Walsh,
Abdullah Sevincer, Jerin Jacob, Harry van Haaren, Elena Agostini,
John W. Linville, Ciara Loftus, Shepard Siegel, Ed Czeck,
John Miller, Rahul Lakkireddy, Apeksha Gupta, John Daley,
Hyong Youb Kim, Ziyang Xuan, Xiaoyun Wang, Guoyang Zhou,
Andrew Boyer, Jakub Grajciar, Zyta Szpak, Martin Spinler,
Tetsuya Mukawa, Vamsi Attunuru, Cristian Dumitrescu, Matan Azrad,
Maxime Coquelin, Chenbo Xia, Konstantin Ananyev, Akhil Goyal,
Byron Marohn, Yipeng Wang, Thomas Monjalon, Ferruh Yigit,
Vladimir Medvedkin, Zhirun Yan, Sameh Gobriel, Reshma Pattan,
Morten Brørup, Srikanth Yalavarthi, Jasvinder Singh,
Pavan Nikhilesh, Anatoly Burakov, David Hunt, Sivaprasad Tummala,
Honnappa Nagarahalli, Ori Kam, Volodymyr Fialko, Ciara Power
The macro RTE_LOG_REGISTER_DEFAULT emits code for an initialization
function. If a driver (and most do) adds a semicolon after the macro.
RTE_LOG_REGISTER_DEFAULT(logtype_foo, INFO);
Is equivalent to:
int logtype_foo;
static void __logtype_foo(void) {
logtype_foo = rte_log_register_type_and_pick_level(name,
RTE_LOG_INFO);
if (type < 0)
logtype_foo = RTE_LOGTYPE_EAL;
};
The problem is that extra semi-colon after the function.
If code is built with highest level of warnings (pedantic),
then it will generate a warning.
warning: ISO C does not allow extra ‘;’ outside of a function
This is a treewide fix for this.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
.../fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 4 +--
drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 4 +--
drivers/baseband/la12xx/bbdev_la12xx.c | 2 +-
drivers/baseband/null/bbdev_null.c | 2 +-
.../baseband/turbo_sw/bbdev_turbo_software.c | 2 +-
drivers/bus/auxiliary/auxiliary_common.c | 2 +-
drivers/bus/cdx/cdx.c | 2 +-
drivers/bus/dpaa/dpaa_bus.c | 2 +-
drivers/bus/fslmc/fslmc_bus.c | 2 +-
drivers/bus/ifpga/ifpga_bus.c | 2 +-
drivers/bus/platform/platform.c | 2 +-
drivers/bus/uacce/uacce.c | 2 +-
drivers/bus/vdev/vdev.c | 2 +-
drivers/bus/vmbus/vmbus_common.c | 2 +-
drivers/common/cnxk/roc_platform.c | 28 +++++++++----------
drivers/common/dpaax/dpaax_iova_table.c | 2 +-
drivers/common/iavf/iavf_impl.c | 2 +-
drivers/common/idpf/base/idpf_common.c | 2 +-
drivers/common/nitrox/nitrox_logs.c | 2 +-
drivers/common/sfc_efx/sfc_efx.c | 2 +-
drivers/compress/isal/isal_compress_pmd.c | 2 +-
drivers/compress/octeontx/otx_zip_pmd.c | 2 +-
drivers/compress/zlib/zlib_pmd.c | 2 +-
drivers/crypto/armv8/rte_armv8_pmd.c | 2 +-
drivers/crypto/mvsam/rte_mrvl_pmd.c | 2 +-
drivers/crypto/null/null_crypto_pmd.c | 2 +-
drivers/crypto/octeontx/otx_cryptodev.c | 2 +-
drivers/crypto/openssl/rte_openssl_pmd.c | 2 +-
.../scheduler/rte_cryptodev_scheduler.c | 2 +-
drivers/crypto/uadk/uadk_crypto_pmd.c | 2 +-
drivers/dma/dpaa/dpaa_qdma.c | 2 +-
drivers/dma/dpaa2/dpaa2_qdma.c | 2 +-
drivers/dma/hisilicon/hisi_dmadev.c | 2 +-
drivers/dma/idxd/idxd_common.c | 2 +-
drivers/dma/ioat/ioat_dmadev.c | 2 +-
drivers/dma/skeleton/skeleton_dmadev.c | 2 +-
drivers/event/dlb2/dlb2.c | 2 +-
drivers/event/dpaa/dpaa_eventdev.c | 2 +-
drivers/event/dpaa2/dpaa2_eventdev.c | 2 +-
drivers/event/octeontx/ssovf_evdev.c | 2 +-
drivers/event/skeleton/skeleton_eventdev.c | 2 +-
drivers/event/sw/sw_evdev.c | 2 +-
drivers/gpu/cuda/cuda.c | 2 +-
drivers/mempool/dpaa/dpaa_mempool.c | 2 +-
drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 2 +-
drivers/net/af_packet/rte_eth_af_packet.c | 2 +-
drivers/net/af_xdp/rte_eth_af_xdp.c | 2 +-
drivers/net/ark/ark_ethdev.c | 2 +-
drivers/net/cxgbe/cxgbe_ethdev.c | 2 +-
drivers/net/dpaa/dpaa_ethdev.c | 2 +-
drivers/net/dpaa2/dpaa2_ethdev.c | 2 +-
drivers/net/enetc/enetc_ethdev.c | 2 +-
drivers/net/enetfec/enet_ethdev.c | 2 +-
drivers/net/enic/enic_ethdev.c | 2 +-
drivers/net/hinic/hinic_pmd_ethdev.c | 2 +-
drivers/net/ionic/ionic_ethdev.c | 2 +-
drivers/net/ipn3ke/ipn3ke_ethdev.c | 2 +-
drivers/net/memif/rte_eth_memif.c | 2 +-
drivers/net/mvneta/mvneta_ethdev.c | 2 +-
drivers/net/mvpp2/mrvl_ethdev.c | 2 +-
drivers/net/nfb/nfb_ethdev.c | 2 +-
drivers/net/null/rte_eth_null.c | 2 +-
drivers/net/octeon_ep/otx_ep_ethdev.c | 2 +-
drivers/net/pcap/pcap_ethdev.c | 2 +-
drivers/net/pfe/pfe_ethdev.c | 2 +-
drivers/net/ring/rte_eth_ring.c | 2 +-
drivers/net/softnic/rte_eth_softnic.c | 2 +-
drivers/net/tap/rte_eth_tap.c | 2 +-
drivers/net/vdev_netvsc/vdev_netvsc.c | 2 +-
drivers/net/vhost/rte_eth_vhost.c | 2 +-
drivers/raw/ifpga/ifpga_rawdev.c | 2 +-
drivers/raw/ntb/ntb.c | 2 +-
drivers/raw/skeleton/skeleton_rawdev.c | 2 +-
lib/acl/rte_acl.c | 2 +-
lib/argparse/rte_argparse.c | 2 +-
lib/bbdev/rte_bbdev.c | 2 +-
lib/bpf/bpf.c | 2 +-
lib/cfgfile/rte_cfgfile.c | 2 +-
lib/compressdev/rte_compressdev.c | 2 +-
lib/cryptodev/rte_cryptodev.c | 2 +-
lib/dmadev/rte_dmadev.c | 2 +-
lib/efd/rte_efd.c | 2 +-
lib/ethdev/rte_ethdev.c | 2 +-
lib/eventdev/rte_eventdev.c | 2 +-
lib/fib/rte_fib.c | 2 +-
lib/gpudev/gpudev.c | 2 +-
lib/graph/graph.c | 2 +-
lib/hash/rte_cuckoo_hash.c | 2 +-
lib/ip_frag/rte_ip_frag_common.c | 2 +-
lib/latencystats/rte_latencystats.c | 2 +-
lib/lpm/rte_lpm.c | 2 +-
lib/mbuf/rte_mbuf.c | 2 +-
lib/member/rte_member.c | 2 +-
lib/mempool/rte_mempool.c | 2 +-
lib/metrics/rte_metrics_telemetry.c | 2 +-
lib/mldev/rte_mldev.c | 2 +-
lib/net/rte_net_crc.c | 2 +-
lib/node/log.c | 2 +-
lib/pdump/rte_pdump.c | 2 +-
lib/pipeline/rte_pipeline.c | 2 +-
lib/port/port_log.c | 2 +-
lib/power/power_common.c | 2 +-
lib/rawdev/rte_rawdev.c | 2 +-
lib/rcu/rte_rcu_qsbr.c | 2 +-
lib/regexdev/rte_regexdev.c | 2 +-
lib/reorder/rte_reorder.c | 2 +-
lib/rib/rte_rib.c | 2 +-
lib/ring/rte_ring.c | 2 +-
lib/sched/rte_sched.c | 2 +-
lib/stack/rte_stack.c | 2 +-
lib/table/table_log.c | 2 +-
lib/telemetry/telemetry.c | 2 +-
112 files changed, 127 insertions(+), 127 deletions(-)
diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
index 9b253cde28..d9a138ac93 100644
--- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
+++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
@@ -23,9 +23,9 @@
#include "fpga_5gnr_fec.h"
#ifdef RTE_LIBRTE_BBDEV_DEBUG
-RTE_LOG_REGISTER_DEFAULT(fpga_5gnr_fec_logtype, DEBUG);
+RTE_LOG_REGISTER_DEFAULT(fpga_5gnr_fec_logtype, DEBUG)
#else
-RTE_LOG_REGISTER_DEFAULT(fpga_5gnr_fec_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(fpga_5gnr_fec_logtype, NOTICE)
#endif
#ifdef RTE_LIBRTE_BBDEV_DEBUG
diff --git a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
index a4a963f74d..370f199cca 100644
--- a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
+++ b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
@@ -21,9 +21,9 @@
#include "fpga_lte_fec.h"
#ifdef RTE_LIBRTE_BBDEV_DEBUG
-RTE_LOG_REGISTER_DEFAULT(fpga_lte_fec_logtype, DEBUG);
+RTE_LOG_REGISTER_DEFAULT(fpga_lte_fec_logtype, DEBUG)
#else
-RTE_LOG_REGISTER_DEFAULT(fpga_lte_fec_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(fpga_lte_fec_logtype, NOTICE)
#endif
/* Helper macro for logging */
diff --git a/drivers/baseband/la12xx/bbdev_la12xx.c b/drivers/baseband/la12xx/bbdev_la12xx.c
index bb754a5395..669036d601 100644
--- a/drivers/baseband/la12xx/bbdev_la12xx.c
+++ b/drivers/baseband/la12xx/bbdev_la12xx.c
@@ -1109,4 +1109,4 @@ RTE_PMD_REGISTER_VDEV(DRIVER_NAME, bbdev_la12xx_pmd_drv);
RTE_PMD_REGISTER_PARAM_STRING(DRIVER_NAME,
LA12XX_MAX_NB_QUEUES_ARG"=<int>"
LA12XX_VDEV_MODEM_ID_ARG "=<int> ");
-RTE_LOG_REGISTER_DEFAULT(bbdev_la12xx_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(bbdev_la12xx_logtype, NOTICE)
diff --git a/drivers/baseband/null/bbdev_null.c b/drivers/baseband/null/bbdev_null.c
index 662663c0c8..f5bf05abd3 100644
--- a/drivers/baseband/null/bbdev_null.c
+++ b/drivers/baseband/null/bbdev_null.c
@@ -16,7 +16,7 @@
#define DRIVER_NAME baseband_null
-RTE_LOG_REGISTER_DEFAULT(bbdev_null_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(bbdev_null_logtype, NOTICE)
/* Helper macro for logging */
#define rte_bbdev_log(level, fmt, ...) \
diff --git a/drivers/baseband/turbo_sw/bbdev_turbo_software.c b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
index 8ddc7ff05f..963d716741 100644
--- a/drivers/baseband/turbo_sw/bbdev_turbo_software.c
+++ b/drivers/baseband/turbo_sw/bbdev_turbo_software.c
@@ -36,7 +36,7 @@
#define DRIVER_NAME baseband_turbo_sw
-RTE_LOG_REGISTER_DEFAULT(bbdev_turbo_sw_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(bbdev_turbo_sw_logtype, NOTICE)
/* Helper macro for logging */
#define rte_bbdev_log(level, fmt, ...) \
diff --git a/drivers/bus/auxiliary/auxiliary_common.c b/drivers/bus/auxiliary/auxiliary_common.c
index 29f99342a7..6004de5c0e 100644
--- a/drivers/bus/auxiliary/auxiliary_common.c
+++ b/drivers/bus/auxiliary/auxiliary_common.c
@@ -440,4 +440,4 @@ struct rte_auxiliary_bus auxiliary_bus = {
};
RTE_REGISTER_BUS(auxiliary, auxiliary_bus.bus);
-RTE_LOG_REGISTER_DEFAULT(auxiliary_bus_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(auxiliary_bus_logtype, NOTICE)
diff --git a/drivers/bus/cdx/cdx.c b/drivers/bus/cdx/cdx.c
index 62b108e082..c6b88624fd 100644
--- a/drivers/bus/cdx/cdx.c
+++ b/drivers/bus/cdx/cdx.c
@@ -667,4 +667,4 @@ struct rte_cdx_bus rte_cdx_bus = {
};
RTE_REGISTER_BUS(cdx, rte_cdx_bus.bus);
-RTE_LOG_REGISTER_DEFAULT(cdx_logtype_bus, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(cdx_logtype_bus, NOTICE)
diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c
index 5d4352bb3c..0320347bf1 100644
--- a/drivers/bus/dpaa/dpaa_bus.c
+++ b/drivers/bus/dpaa/dpaa_bus.c
@@ -834,4 +834,4 @@ static struct rte_dpaa_bus rte_dpaa_bus = {
};
RTE_REGISTER_BUS(FSL_DPAA_BUS_NAME, rte_dpaa_bus.bus);
-RTE_LOG_REGISTER_DEFAULT(dpaa_logtype_bus, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(dpaa_logtype_bus, NOTICE)
diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
index c155f4a2fd..166089b7d7 100644
--- a/drivers/bus/fslmc/fslmc_bus.c
+++ b/drivers/bus/fslmc/fslmc_bus.c
@@ -677,4 +677,4 @@ struct rte_fslmc_bus rte_fslmc_bus = {
};
RTE_REGISTER_BUS(FSLMC_BUS_NAME, rte_fslmc_bus.bus);
-RTE_LOG_REGISTER_DEFAULT(dpaa2_logtype_bus, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(dpaa2_logtype_bus, NOTICE)
diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
index ffb0c61214..cecd182d51 100644
--- a/drivers/bus/ifpga/ifpga_bus.c
+++ b/drivers/bus/ifpga/ifpga_bus.c
@@ -513,4 +513,4 @@ static struct rte_bus rte_ifpga_bus = {
};
RTE_REGISTER_BUS(IFPGA_BUS_NAME, rte_ifpga_bus);
-RTE_LOG_REGISTER_DEFAULT(ifpga_bus_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(ifpga_bus_logtype, NOTICE)
diff --git a/drivers/bus/platform/platform.c b/drivers/bus/platform/platform.c
index 7e24bb96a1..b56f60b85f 100644
--- a/drivers/bus/platform/platform.c
+++ b/drivers/bus/platform/platform.c
@@ -643,6 +643,6 @@ struct rte_platform_bus platform_bus = {
};
RTE_REGISTER_BUS(platform, platform_bus.bus);
-RTE_LOG_REGISTER_DEFAULT(platform_bus_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(platform_bus_logtype, NOTICE)
#endif /* VFIO_PRESENT */
diff --git a/drivers/bus/uacce/uacce.c b/drivers/bus/uacce/uacce.c
index 8b666c4e30..6d5ad256b8 100644
--- a/drivers/bus/uacce/uacce.c
+++ b/drivers/bus/uacce/uacce.c
@@ -698,4 +698,4 @@ static struct rte_uacce_bus uacce_bus = {
};
RTE_REGISTER_BUS(uacce, uacce_bus.bus);
-RTE_LOG_REGISTER_DEFAULT(uacce_bus_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(uacce_bus_logtype, NOTICE)
diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
index 14cf856237..6d7966752b 100644
--- a/drivers/bus/vdev/vdev.c
+++ b/drivers/bus/vdev/vdev.c
@@ -691,4 +691,4 @@ static struct rte_bus rte_vdev_bus = {
};
RTE_REGISTER_BUS(vdev, rte_vdev_bus);
-RTE_LOG_REGISTER_DEFAULT(vdev_logtype_bus, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(vdev_logtype_bus, NOTICE)
diff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c
index b9139c6e6c..526c471dc8 100644
--- a/drivers/bus/vmbus/vmbus_common.c
+++ b/drivers/bus/vmbus/vmbus_common.c
@@ -350,4 +350,4 @@ struct rte_vmbus_bus rte_vmbus_bus = {
};
RTE_REGISTER_BUS(vmbus, rte_vmbus_bus.bus);
-RTE_LOG_REGISTER_DEFAULT(vmbus_logtype_bus, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(vmbus_logtype_bus, NOTICE)
diff --git a/drivers/common/cnxk/roc_platform.c b/drivers/common/cnxk/roc_platform.c
index 181902a585..9ceea99009 100644
--- a/drivers/common/cnxk/roc_platform.c
+++ b/drivers/common/cnxk/roc_platform.c
@@ -85,17 +85,17 @@ roc_plt_init(void)
return 0;
}
-RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_base, NOTICE);
-RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_mbox, NOTICE);
-RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_cpt, NOTICE);
-RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_ml, NOTICE);
-RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_npa, NOTICE);
-RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_nix, NOTICE);
-RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_npc, NOTICE);
-RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_sso, NOTICE);
-RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_tim, NOTICE);
-RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_tm, NOTICE);
-RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_dpi, NOTICE);
-RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_rep, NOTICE);
-RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_esw, NOTICE);
-RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_ree, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_base, NOTICE)
+RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_mbox, NOTICE)
+RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_cpt, NOTICE)
+RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_ml, NOTICE)
+RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_npa, NOTICE)
+RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_nix, NOTICE)
+RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_npc, NOTICE)
+RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_sso, NOTICE)
+RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_tim, NOTICE)
+RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_tm, NOTICE)
+RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_dpi, NOTICE)
+RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_rep, NOTICE)
+RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_esw, NOTICE)
+RTE_LOG_REGISTER_DEFAULT(cnxk_logtype_ree, NOTICE)
diff --git a/drivers/common/dpaax/dpaax_iova_table.c b/drivers/common/dpaax/dpaax_iova_table.c
index 9daac4bc03..e227ce6a24 100644
--- a/drivers/common/dpaax/dpaax_iova_table.c
+++ b/drivers/common/dpaax/dpaax_iova_table.c
@@ -462,4 +462,4 @@ dpaax_handle_memevents(void)
dpaax_memevent_cb, NULL);
}
-RTE_LOG_REGISTER_DEFAULT(dpaax_logger, ERR);
+RTE_LOG_REGISTER_DEFAULT(dpaax_logger, ERR)
diff --git a/drivers/common/iavf/iavf_impl.c b/drivers/common/iavf/iavf_impl.c
index 8919b0e7c3..8300953d58 100644
--- a/drivers/common/iavf/iavf_impl.c
+++ b/drivers/common/iavf/iavf_impl.c
@@ -86,4 +86,4 @@ iavf_free_virt_mem_d(__rte_unused struct iavf_hw *hw,
return IAVF_SUCCESS;
}
-RTE_LOG_REGISTER_DEFAULT(iavf_common_logger, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(iavf_common_logger, NOTICE)
diff --git a/drivers/common/idpf/base/idpf_common.c b/drivers/common/idpf/base/idpf_common.c
index 7181a7f14c..f27919237f 100644
--- a/drivers/common/idpf/base/idpf_common.c
+++ b/drivers/common/idpf/base/idpf_common.c
@@ -379,4 +379,4 @@ int idpf_set_rss_key(struct idpf_hw *hw, u16 vsi_id,
return idpf_get_set_rss_key(hw, vsi_id, key, true);
}
-RTE_LOG_REGISTER_DEFAULT(idpf_common_logger, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(idpf_common_logger, NOTICE)
diff --git a/drivers/common/nitrox/nitrox_logs.c b/drivers/common/nitrox/nitrox_logs.c
index 0e0a94648c..6059c9e7ff 100644
--- a/drivers/common/nitrox/nitrox_logs.c
+++ b/drivers/common/nitrox/nitrox_logs.c
@@ -4,4 +4,4 @@
#include <rte_log.h>
-RTE_LOG_REGISTER_DEFAULT(nitrox_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(nitrox_logtype, NOTICE)
diff --git a/drivers/common/sfc_efx/sfc_efx.c b/drivers/common/sfc_efx/sfc_efx.c
index 5eeffb065b..2db37f7d3a 100644
--- a/drivers/common/sfc_efx/sfc_efx.c
+++ b/drivers/common/sfc_efx/sfc_efx.c
@@ -117,4 +117,4 @@ sfc_efx_family(struct rte_pci_device *pci_dev,
return rc;
}
-RTE_LOG_REGISTER_DEFAULT(sfc_efx_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(sfc_efx_logtype, NOTICE)
diff --git a/drivers/compress/isal/isal_compress_pmd.c b/drivers/compress/isal/isal_compress_pmd.c
index cb23e929ed..c7d1e59b43 100644
--- a/drivers/compress/isal/isal_compress_pmd.c
+++ b/drivers/compress/isal/isal_compress_pmd.c
@@ -754,4 +754,4 @@ static struct rte_vdev_driver compdev_isal_pmd_drv = {
RTE_PMD_REGISTER_VDEV(COMPDEV_NAME_ISAL_PMD, compdev_isal_pmd_drv);
RTE_PMD_REGISTER_PARAM_STRING(COMPDEV_NAME_ISAL_PMD,
"socket_id=<int>");
-RTE_LOG_REGISTER_DEFAULT(isal_logtype_driver, INFO);
+RTE_LOG_REGISTER_DEFAULT(isal_logtype_driver, INFO)
diff --git a/drivers/compress/octeontx/otx_zip_pmd.c b/drivers/compress/octeontx/otx_zip_pmd.c
index fd20139da6..477cc87acb 100644
--- a/drivers/compress/octeontx/otx_zip_pmd.c
+++ b/drivers/compress/octeontx/otx_zip_pmd.c
@@ -719,4 +719,4 @@ static struct rte_pci_driver octtx_zip_pmd = {
RTE_PMD_REGISTER_PCI(COMPRESSDEV_NAME_ZIP_PMD, octtx_zip_pmd);
RTE_PMD_REGISTER_PCI_TABLE(COMPRESSDEV_NAME_ZIP_PMD, pci_id_octtx_zipvf_table);
-RTE_LOG_REGISTER_DEFAULT(octtx_zip_logtype_driver, INFO);
+RTE_LOG_REGISTER_DEFAULT(octtx_zip_logtype_driver, INFO)
diff --git a/drivers/compress/zlib/zlib_pmd.c b/drivers/compress/zlib/zlib_pmd.c
index 98abd41013..989e786805 100644
--- a/drivers/compress/zlib/zlib_pmd.c
+++ b/drivers/compress/zlib/zlib_pmd.c
@@ -426,4 +426,4 @@ static struct rte_vdev_driver zlib_pmd_drv = {
};
RTE_PMD_REGISTER_VDEV(COMPRESSDEV_NAME_ZLIB_PMD, zlib_pmd_drv);
-RTE_LOG_REGISTER_DEFAULT(zlib_logtype_driver, INFO);
+RTE_LOG_REGISTER_DEFAULT(zlib_logtype_driver, INFO)
diff --git a/drivers/crypto/armv8/rte_armv8_pmd.c b/drivers/crypto/armv8/rte_armv8_pmd.c
index 320e2d4b3b..3a761908b9 100644
--- a/drivers/crypto/armv8/rte_armv8_pmd.c
+++ b/drivers/crypto/armv8/rte_armv8_pmd.c
@@ -851,7 +851,7 @@ static struct rte_vdev_driver armv8_crypto_pmd_drv = {
static struct cryptodev_driver armv8_crypto_drv;
-RTE_LOG_REGISTER_DEFAULT(crypto_armv8_log_type, ERR);
+RTE_LOG_REGISTER_DEFAULT(crypto_armv8_log_type, ERR)
RTE_PMD_REGISTER_VDEV(CRYPTODEV_NAME_ARMV8_PMD, armv8_crypto_pmd_drv);
RTE_PMD_REGISTER_ALIAS(CRYPTODEV_NAME_ARMV8_PMD, cryptodev_armv8_pmd);
diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd.c b/drivers/crypto/mvsam/rte_mrvl_pmd.c
index 1641da9ca6..4bb9ffc747 100644
--- a/drivers/crypto/mvsam/rte_mrvl_pmd.c
+++ b/drivers/crypto/mvsam/rte_mrvl_pmd.c
@@ -1290,4 +1290,4 @@ RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_MRVL_PMD,
"socket_id=<int>");
RTE_PMD_REGISTER_CRYPTO_DRIVER(mrvl_crypto_drv, cryptodev_mrvl_pmd_drv.driver,
cryptodev_driver_id);
-RTE_LOG_REGISTER_DEFAULT(mrvl_logtype_driver, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(mrvl_logtype_driver, NOTICE)
diff --git a/drivers/crypto/null/null_crypto_pmd.c b/drivers/crypto/null/null_crypto_pmd.c
index 8458306556..bb8f68233a 100644
--- a/drivers/crypto/null/null_crypto_pmd.c
+++ b/drivers/crypto/null/null_crypto_pmd.c
@@ -240,4 +240,4 @@ RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_NULL_PMD,
"socket_id=<int>");
RTE_PMD_REGISTER_CRYPTO_DRIVER(null_crypto_drv, cryptodev_null_pmd_drv.driver,
cryptodev_driver_id);
-RTE_LOG_REGISTER_DEFAULT(null_logtype_driver, INFO);
+RTE_LOG_REGISTER_DEFAULT(null_logtype_driver, INFO)
diff --git a/drivers/crypto/octeontx/otx_cryptodev.c b/drivers/crypto/octeontx/otx_cryptodev.c
index b5ab937c3a..59c77020a9 100644
--- a/drivers/crypto/octeontx/otx_cryptodev.c
+++ b/drivers/crypto/octeontx/otx_cryptodev.c
@@ -119,4 +119,4 @@ RTE_PMD_REGISTER_PCI_TABLE(CRYPTODEV_NAME_OCTEONTX_PMD, pci_id_cpt_table);
RTE_PMD_REGISTER_KMOD_DEP(CRYPTODEV_NAME_OCTEONTX_PMD, "vfio-pci");
RTE_PMD_REGISTER_CRYPTO_DRIVER(otx_cryptodev_drv, otx_cryptodev_pmd.driver,
otx_cryptodev_driver_id);
-RTE_LOG_REGISTER_DEFAULT(otx_cpt_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(otx_cpt_logtype, NOTICE)
diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c
index e8cb09defc..c851992660 100644
--- a/drivers/crypto/openssl/rte_openssl_pmd.c
+++ b/drivers/crypto/openssl/rte_openssl_pmd.c
@@ -3319,4 +3319,4 @@ RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_OPENSSL_PMD,
"socket_id=<int>");
RTE_PMD_REGISTER_CRYPTO_DRIVER(openssl_crypto_drv,
cryptodev_openssl_pmd_drv.driver, cryptodev_driver_id);
-RTE_LOG_REGISTER_DEFAULT(openssl_logtype_driver, INFO);
+RTE_LOG_REGISTER_DEFAULT(openssl_logtype_driver, INFO)
diff --git a/drivers/crypto/scheduler/rte_cryptodev_scheduler.c b/drivers/crypto/scheduler/rte_cryptodev_scheduler.c
index 9a21edd32a..2b3aaa2f44 100644
--- a/drivers/crypto/scheduler/rte_cryptodev_scheduler.c
+++ b/drivers/crypto/scheduler/rte_cryptodev_scheduler.c
@@ -779,4 +779,4 @@ rte_cryptodev_scheduler_option_get(uint8_t scheduler_id,
}
-RTE_LOG_REGISTER_DEFAULT(scheduler_logtype_driver, INFO);
+RTE_LOG_REGISTER_DEFAULT(scheduler_logtype_driver, INFO)
diff --git a/drivers/crypto/uadk/uadk_crypto_pmd.c b/drivers/crypto/uadk/uadk_crypto_pmd.c
index 824383512e..cc2302a721 100644
--- a/drivers/crypto/uadk/uadk_crypto_pmd.c
+++ b/drivers/crypto/uadk/uadk_crypto_pmd.c
@@ -1092,4 +1092,4 @@ RTE_PMD_REGISTER_CRYPTO_DRIVER(uadk_crypto_drv, uadk_crypto_pmd.driver,
uadk_cryptodev_driver_id);
RTE_PMD_REGISTER_PARAM_STRING(UADK_CRYPTO_DRIVER_NAME,
"max_nb_queue_pairs=<int>");
-RTE_LOG_REGISTER_DEFAULT(uadk_crypto_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(uadk_crypto_logtype, INFO)
diff --git a/drivers/dma/dpaa/dpaa_qdma.c b/drivers/dma/dpaa/dpaa_qdma.c
index 10e65ef1d7..160c93f545 100644
--- a/drivers/dma/dpaa/dpaa_qdma.c
+++ b/drivers/dma/dpaa/dpaa_qdma.c
@@ -1078,4 +1078,4 @@ static struct rte_dpaa_driver rte_dpaa_qdma_pmd = {
};
RTE_PMD_REGISTER_DPAA(dpaa_qdma, rte_dpaa_qdma_pmd);
-RTE_LOG_REGISTER_DEFAULT(dpaa_qdma_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(dpaa_qdma_logtype, INFO)
diff --git a/drivers/dma/dpaa2/dpaa2_qdma.c b/drivers/dma/dpaa2/dpaa2_qdma.c
index 2c91ceec13..41fb3447e3 100644
--- a/drivers/dma/dpaa2/dpaa2_qdma.c
+++ b/drivers/dma/dpaa2/dpaa2_qdma.c
@@ -1696,4 +1696,4 @@ static struct rte_dpaa2_driver rte_dpaa2_qdma_pmd = {
RTE_PMD_REGISTER_DPAA2(dpaa2_qdma, rte_dpaa2_qdma_pmd);
RTE_PMD_REGISTER_PARAM_STRING(dpaa2_qdma,
"no_prefetch=<int> ");
-RTE_LOG_REGISTER_DEFAULT(dpaa2_qdma_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(dpaa2_qdma_logtype, INFO)
diff --git a/drivers/dma/hisilicon/hisi_dmadev.c b/drivers/dma/hisilicon/hisi_dmadev.c
index 22303e7bef..8dabd5c544 100644
--- a/drivers/dma/hisilicon/hisi_dmadev.c
+++ b/drivers/dma/hisilicon/hisi_dmadev.c
@@ -17,7 +17,7 @@
#include "hisi_dmadev.h"
-RTE_LOG_REGISTER_DEFAULT(hisi_dma_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(hisi_dma_logtype, INFO)
#define HISI_DMA_LOG(level, fmt, args...) \
rte_log(RTE_LOG_ ## level, hisi_dma_logtype, \
"%s(): " fmt "\n", __func__, ##args)
diff --git a/drivers/dma/idxd/idxd_common.c b/drivers/dma/idxd/idxd_common.c
index 83d53942eb..8603fd8794 100644
--- a/drivers/dma/idxd/idxd_common.c
+++ b/drivers/dma/idxd/idxd_common.c
@@ -636,4 +636,4 @@ idxd_dmadev_create(const char *name, struct rte_device *dev,
int idxd_pmd_logtype;
-RTE_LOG_REGISTER_DEFAULT(idxd_pmd_logtype, WARNING);
+RTE_LOG_REGISTER_DEFAULT(idxd_pmd_logtype, WARNING)
diff --git a/drivers/dma/ioat/ioat_dmadev.c b/drivers/dma/ioat/ioat_dmadev.c
index 5fc14bcf22..10c20252c2 100644
--- a/drivers/dma/ioat/ioat_dmadev.c
+++ b/drivers/dma/ioat/ioat_dmadev.c
@@ -12,7 +12,7 @@
static struct rte_pci_driver ioat_pmd_drv;
-RTE_LOG_REGISTER_DEFAULT(ioat_pmd_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(ioat_pmd_logtype, INFO)
#define DESC_SZ sizeof(struct ioat_dma_hw_desc)
diff --git a/drivers/dma/skeleton/skeleton_dmadev.c b/drivers/dma/skeleton/skeleton_dmadev.c
index 48f88f9fc1..92b5ccd43b 100644
--- a/drivers/dma/skeleton/skeleton_dmadev.c
+++ b/drivers/dma/skeleton/skeleton_dmadev.c
@@ -20,7 +20,7 @@
#include "skeleton_dmadev.h"
-RTE_LOG_REGISTER_DEFAULT(skeldma_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(skeldma_logtype, INFO)
#define SKELDMA_LOG(level, fmt, args...) \
rte_log(RTE_LOG_ ## level, skeldma_logtype, "%s(): " fmt "\n", \
__func__, ##args)
diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
index 628ddef649..2cdc19c674 100644
--- a/drivers/event/dlb2/dlb2.c
+++ b/drivers/event/dlb2/dlb2.c
@@ -4945,4 +4945,4 @@ dlb2_parse_params(const char *params,
}
return ret;
}
-RTE_LOG_REGISTER_DEFAULT(eventdev_dlb2_log_level, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(eventdev_dlb2_log_level, NOTICE)
diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa_eventdev.c
index 919e922298..d7d676c39a 100644
--- a/drivers/event/dpaa/dpaa_eventdev.c
+++ b/drivers/event/dpaa/dpaa_eventdev.c
@@ -47,7 +47,7 @@
* Eventqueue = Channel Instance
* 1 Eventdev can have N Eventqueue
*/
-RTE_LOG_REGISTER_DEFAULT(dpaa_logtype_eventdev, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(dpaa_logtype_eventdev, NOTICE)
#define DISABLE_INTR_MODE "disable_intr"
diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c
index 1273455673..4d6fe823bd 100644
--- a/drivers/event/dpaa2/dpaa2_eventdev.c
+++ b/drivers/event/dpaa2/dpaa2_eventdev.c
@@ -1214,4 +1214,4 @@ static struct rte_vdev_driver vdev_eventdev_dpaa2_pmd = {
};
RTE_PMD_REGISTER_VDEV(EVENTDEV_NAME_DPAA2_PMD, vdev_eventdev_dpaa2_pmd);
-RTE_LOG_REGISTER_DEFAULT(dpaa2_logtype_event, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(dpaa2_logtype_event, NOTICE)
diff --git a/drivers/event/octeontx/ssovf_evdev.c b/drivers/event/octeontx/ssovf_evdev.c
index 3a933b1db7..1098ab6758 100644
--- a/drivers/event/octeontx/ssovf_evdev.c
+++ b/drivers/event/octeontx/ssovf_evdev.c
@@ -25,7 +25,7 @@
static uint8_t timvf_enable_stats;
-RTE_LOG_REGISTER_DEFAULT(otx_logtype_ssovf, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(otx_logtype_ssovf, NOTICE)
/* SSOPF Mailbox messages */
diff --git a/drivers/event/skeleton/skeleton_eventdev.c b/drivers/event/skeleton/skeleton_eventdev.c
index 848b3be82c..36fcc94592 100644
--- a/drivers/event/skeleton/skeleton_eventdev.c
+++ b/drivers/event/skeleton/skeleton_eventdev.c
@@ -478,4 +478,4 @@ static struct rte_vdev_driver vdev_eventdev_skeleton_pmd = {
};
RTE_PMD_REGISTER_VDEV(EVENTDEV_NAME_SKELETON_PMD, vdev_eventdev_skeleton_pmd);
-RTE_LOG_REGISTER_DEFAULT(skeleton_eventdev_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(skeleton_eventdev_logtype, INFO)
diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
index 1c01b069fe..72c2f5581b 100644
--- a/drivers/event/sw/sw_evdev.c
+++ b/drivers/event/sw/sw_evdev.c
@@ -1152,4 +1152,4 @@ RTE_PMD_REGISTER_PARAM_STRING(event_sw, NUMA_NODE_ARG "=<int> "
SCHED_QUANTA_ARG "=<int>" CREDIT_QUANTA_ARG "=<int>"
MIN_BURST_SIZE_ARG "=<int>" DEQ_BURST_SIZE_ARG "=<int>"
REFIL_ONCE_ARG "=<int>");
-RTE_LOG_REGISTER_DEFAULT(eventdev_sw_log_level, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(eventdev_sw_log_level, NOTICE)
diff --git a/drivers/gpu/cuda/cuda.c b/drivers/gpu/cuda/cuda.c
index a552aabeb8..b79ae30680 100644
--- a/drivers/gpu/cuda/cuda.c
+++ b/drivers/gpu/cuda/cuda.c
@@ -59,7 +59,7 @@ static gdr_t gdrc_h;
#define GPU_PAGE_SHIFT 16
#define GPU_PAGE_SIZE (1UL << GPU_PAGE_SHIFT)
-RTE_LOG_REGISTER_DEFAULT(cuda_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(cuda_logtype, NOTICE)
/* NVIDIA GPU address map */
static const struct rte_pci_id pci_id_cuda_map[] = {
diff --git a/drivers/mempool/dpaa/dpaa_mempool.c b/drivers/mempool/dpaa/dpaa_mempool.c
index 0b484b3d9c..a5bb0c83f4 100644
--- a/drivers/mempool/dpaa/dpaa_mempool.c
+++ b/drivers/mempool/dpaa/dpaa_mempool.c
@@ -37,7 +37,7 @@ struct dpaa_memseg_list rte_dpaa_memsegs
struct dpaa_bp_info *rte_dpaa_bpid_info;
-RTE_LOG_REGISTER_DEFAULT(dpaa_logtype_mempool, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(dpaa_logtype_mempool, NOTICE)
#define RTE_LOGTYPE_DPAA_MEMPOOL dpaa_logtype_mempool
static int
diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
index 4c9245cb81..11a7985d7d 100644
--- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
+++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c
@@ -480,4 +480,4 @@ static const struct rte_mempool_ops dpaa2_mpool_ops = {
RTE_MEMPOOL_REGISTER_OPS(dpaa2_mpool_ops);
-RTE_LOG_REGISTER_DEFAULT(dpaa2_logtype_mempool, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(dpaa2_logtype_mempool, NOTICE)
diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c
index 397a32db58..b539c1c5ac 100644
--- a/drivers/net/af_packet/rte_eth_af_packet.c
+++ b/drivers/net/af_packet/rte_eth_af_packet.c
@@ -100,7 +100,7 @@ static struct rte_eth_link pmd_link = {
.link_autoneg = RTE_ETH_LINK_FIXED,
};
-RTE_LOG_REGISTER_DEFAULT(af_packet_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(af_packet_logtype, NOTICE)
#define PMD_LOG(level, fmt, args...) \
rte_log(RTE_LOG_ ## level, af_packet_logtype, \
diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c
index 268a130c49..70e3210328 100644
--- a/drivers/net/af_xdp/rte_eth_af_xdp.c
+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
@@ -62,7 +62,7 @@
#define PF_XDP AF_XDP
#endif
-RTE_LOG_REGISTER_DEFAULT(af_xdp_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(af_xdp_logtype, NOTICE)
#define AF_XDP_LOG(level, fmt, args...) \
rte_log(RTE_LOG_ ## level, af_xdp_logtype, \
diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index c029dc46b3..f7f4cdc6f6 100644
--- a/drivers/net/ark/ark_ethdev.c
+++ b/drivers/net/ark/ark_ethdev.c
@@ -1011,4 +1011,4 @@ RTE_PMD_REGISTER_PARAM_STRING(net_ark,
ARK_PKTGEN_ARG "=<filename> "
ARK_PKTCHKR_ARG "=<filename> "
ARK_PKTDIR_ARG "=<bitmap>");
-RTE_LOG_REGISTER_DEFAULT(ark_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(ark_logtype, NOTICE)
diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c
index a27b9b266e..043566e5e2 100644
--- a/drivers/net/cxgbe/cxgbe_ethdev.c
+++ b/drivers/net/cxgbe/cxgbe_ethdev.c
@@ -1803,5 +1803,5 @@ RTE_PMD_REGISTER_PARAM_STRING(net_cxgbe,
CXGBE_DEVARG_CMN_TX_MODE_LATENCY "=<0|1> "
CXGBE_DEVARG_PF_FILTER_MODE "=<uint32> "
CXGBE_DEVARG_PF_FILTER_MASK "=<uint32> ");
-RTE_LOG_REGISTER_DEFAULT(cxgbe_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(cxgbe_logtype, NOTICE)
RTE_LOG_REGISTER_SUFFIX(cxgbe_mbox_logtype, mbox, NOTICE);
diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index 935a4f2ada..95a51af9ee 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -2323,4 +2323,4 @@ static struct rte_dpaa_driver rte_dpaa_pmd = {
};
RTE_PMD_REGISTER_DPAA(net_dpaa, rte_dpaa_pmd);
-RTE_LOG_REGISTER_DEFAULT(dpaa_logtype_pmd, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(dpaa_logtype_pmd, NOTICE)
diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
index 97edc00420..eaa0befbdc 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.c
+++ b/drivers/net/dpaa2/dpaa2_ethdev.c
@@ -2972,4 +2972,4 @@ RTE_PMD_REGISTER_PARAM_STRING(NET_DPAA2_PMD_DRIVER_NAME,
DRIVER_NO_PREFETCH_MODE "=<int>"
DRIVER_TX_CONF "=<int>"
DRIVER_ERROR_QUEUE "=<int>");
-RTE_LOG_REGISTER_DEFAULT(dpaa2_logtype_pmd, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(dpaa2_logtype_pmd, NOTICE)
diff --git a/drivers/net/enetc/enetc_ethdev.c b/drivers/net/enetc/enetc_ethdev.c
index d02ee206f1..49be6da908 100644
--- a/drivers/net/enetc/enetc_ethdev.c
+++ b/drivers/net/enetc/enetc_ethdev.c
@@ -968,4 +968,4 @@ static struct rte_pci_driver rte_enetc_pmd = {
RTE_PMD_REGISTER_PCI(net_enetc, rte_enetc_pmd);
RTE_PMD_REGISTER_PCI_TABLE(net_enetc, pci_id_enetc_map);
RTE_PMD_REGISTER_KMOD_DEP(net_enetc, "* vfio-pci");
-RTE_LOG_REGISTER_DEFAULT(enetc_logtype_pmd, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(enetc_logtype_pmd, NOTICE)
diff --git a/drivers/net/enetfec/enet_ethdev.c b/drivers/net/enetfec/enet_ethdev.c
index 898aad1c37..c7802ee3af 100644
--- a/drivers/net/enetfec/enet_ethdev.c
+++ b/drivers/net/enetfec/enet_ethdev.c
@@ -702,4 +702,4 @@ static struct rte_vdev_driver pmd_enetfec_drv = {
};
RTE_PMD_REGISTER_VDEV(ENETFEC_NAME_PMD, pmd_enetfec_drv);
-RTE_LOG_REGISTER_DEFAULT(enetfec_logtype_pmd, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(enetfec_logtype_pmd, NOTICE)
diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c
index cad8db2f6f..7be481cda2 100644
--- a/drivers/net/enic/enic_ethdev.c
+++ b/drivers/net/enic/enic_ethdev.c
@@ -71,7 +71,7 @@ static const struct vic_speed_capa {
#define ENIC_DEVARG_IG_VLAN_REWRITE "ig-vlan-rewrite"
#define ENIC_DEVARG_REPRESENTOR "representor"
-RTE_LOG_REGISTER_DEFAULT(enic_pmd_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(enic_pmd_logtype, INFO)
static int
enicpmd_dev_flow_ops_get(struct rte_eth_dev *dev,
diff --git a/drivers/net/hinic/hinic_pmd_ethdev.c b/drivers/net/hinic/hinic_pmd_ethdev.c
index d4978e0649..bdfa48443a 100644
--- a/drivers/net/hinic/hinic_pmd_ethdev.c
+++ b/drivers/net/hinic/hinic_pmd_ethdev.c
@@ -3257,4 +3257,4 @@ static struct rte_pci_driver rte_hinic_pmd = {
RTE_PMD_REGISTER_PCI(net_hinic, rte_hinic_pmd);
RTE_PMD_REGISTER_PCI_TABLE(net_hinic, pci_id_hinic_map);
-RTE_LOG_REGISTER_DEFAULT(hinic_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(hinic_logtype, INFO)
diff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c
index aa22b6a70d..f9c76a03da 100644
--- a/drivers/net/ionic/ionic_ethdev.c
+++ b/drivers/net/ionic/ionic_ethdev.c
@@ -1284,4 +1284,4 @@ eth_ionic_dev_remove(struct rte_device *rte_dev)
return ret;
}
-RTE_LOG_REGISTER_DEFAULT(ionic_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(ionic_logtype, NOTICE)
diff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.c b/drivers/net/ipn3ke/ipn3ke_ethdev.c
index 2c15611a23..3ea996b6d9 100644
--- a/drivers/net/ipn3ke/ipn3ke_ethdev.c
+++ b/drivers/net/ipn3ke/ipn3ke_ethdev.c
@@ -580,4 +580,4 @@ static struct rte_afu_driver afu_ipn3ke_driver = {
};
RTE_PMD_REGISTER_AFU(net_ipn3ke_afu, afu_ipn3ke_driver);
-RTE_LOG_REGISTER_DEFAULT(ipn3ke_afu_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(ipn3ke_afu_logtype, NOTICE)
diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c
index 18377d9caf..8556ef64f2 100644
--- a/drivers/net/memif/rte_eth_memif.c
+++ b/drivers/net/memif/rte_eth_memif.c
@@ -2080,4 +2080,4 @@ RTE_PMD_REGISTER_PARAM_STRING(net_memif,
ETH_MEMIF_ZC_ARG "=yes|no"
ETH_MEMIF_SECRET_ARG "=<string>");
-RTE_LOG_REGISTER_DEFAULT(memif_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(memif_logtype, NOTICE)
diff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/net/mvneta/mvneta_ethdev.c
index 3841c1ebe9..13a0731d0e 100644
--- a/drivers/net/mvneta/mvneta_ethdev.c
+++ b/drivers/net/mvneta/mvneta_ethdev.c
@@ -989,4 +989,4 @@ static struct rte_vdev_driver pmd_mvneta_drv = {
RTE_PMD_REGISTER_VDEV(net_mvneta, pmd_mvneta_drv);
RTE_PMD_REGISTER_PARAM_STRING(net_mvneta, "iface=<ifc>");
-RTE_LOG_REGISTER_DEFAULT(mvneta_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(mvneta_logtype, NOTICE)
diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c
index 36be79b9a5..55c8c938ee 100644
--- a/drivers/net/mvpp2/mrvl_ethdev.c
+++ b/drivers/net/mvpp2/mrvl_ethdev.c
@@ -3321,4 +3321,4 @@ static struct rte_vdev_driver pmd_mrvl_drv = {
RTE_PMD_REGISTER_VDEV(net_mvpp2, pmd_mrvl_drv);
RTE_PMD_REGISTER_ALIAS(net_mvpp2, eth_mvpp2);
-RTE_LOG_REGISTER_DEFAULT(mrvl_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(mrvl_logtype, NOTICE)
diff --git a/drivers/net/nfb/nfb_ethdev.c b/drivers/net/nfb/nfb_ethdev.c
index 98119d70fd..4bf5798e8c 100644
--- a/drivers/net/nfb/nfb_ethdev.c
+++ b/drivers/net/nfb/nfb_ethdev.c
@@ -671,4 +671,4 @@ static struct rte_pci_driver nfb_eth_driver = {
RTE_PMD_REGISTER_PCI(RTE_NFB_DRIVER_NAME, nfb_eth_driver);
RTE_PMD_REGISTER_PCI_TABLE(RTE_NFB_DRIVER_NAME, nfb_pci_id_table);
RTE_PMD_REGISTER_KMOD_DEP(RTE_NFB_DRIVER_NAME, "* nfb");
-RTE_LOG_REGISTER_DEFAULT(nfb_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(nfb_logtype, NOTICE)
diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
index 7c46004f1e..111a81305b 100644
--- a/drivers/net/null/rte_eth_null.c
+++ b/drivers/net/null/rte_eth_null.c
@@ -75,7 +75,7 @@ static struct rte_eth_link pmd_link = {
.link_autoneg = RTE_ETH_LINK_FIXED,
};
-RTE_LOG_REGISTER_DEFAULT(eth_null_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(eth_null_logtype, NOTICE)
#define PMD_LOG(level, fmt, args...) \
rte_log(RTE_LOG_ ## level, eth_null_logtype, \
diff --git a/drivers/net/octeon_ep/otx_ep_ethdev.c b/drivers/net/octeon_ep/otx_ep_ethdev.c
index 46211361a0..6f0af310fe 100644
--- a/drivers/net/octeon_ep/otx_ep_ethdev.c
+++ b/drivers/net/octeon_ep/otx_ep_ethdev.c
@@ -879,6 +879,6 @@ static struct rte_pci_driver rte_otx_ep_pmd = {
RTE_PMD_REGISTER_PCI(net_otx_ep, rte_otx_ep_pmd);
RTE_PMD_REGISTER_PCI_TABLE(net_otx_ep, pci_id_otx_ep_map);
RTE_PMD_REGISTER_KMOD_DEP(net_otx_ep, "* igb_uio | vfio-pci");
-RTE_LOG_REGISTER_DEFAULT(otx_net_ep_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(otx_net_ep_logtype, NOTICE)
RTE_PMD_REGISTER_PARAM_STRING(net_otx_ep,
OTX_ISM_ENABLE "=<0|1>");
diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/pcap_ethdev.c
index bfec085045..ac956828e7 100644
--- a/drivers/net/pcap/pcap_ethdev.c
+++ b/drivers/net/pcap/pcap_ethdev.c
@@ -143,7 +143,7 @@ static struct rte_eth_link pmd_link = {
.link_autoneg = RTE_ETH_LINK_FIXED,
};
-RTE_LOG_REGISTER_DEFAULT(eth_pcap_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(eth_pcap_logtype, NOTICE)
static struct queue_missed_stat*
queue_missed_stat_update(struct rte_eth_dev *dev, unsigned int qid)
diff --git a/drivers/net/pfe/pfe_ethdev.c b/drivers/net/pfe/pfe_ethdev.c
index eccaaa2448..23175f4008 100644
--- a/drivers/net/pfe/pfe_ethdev.c
+++ b/drivers/net/pfe/pfe_ethdev.c
@@ -1147,4 +1147,4 @@ struct rte_vdev_driver pmd_pfe_drv = {
RTE_PMD_REGISTER_VDEV(PFE_NAME_PMD, pmd_pfe_drv);
RTE_PMD_REGISTER_PARAM_STRING(PFE_NAME_PMD, PFE_VDEV_GEM_ID_ARG "=<int> ");
-RTE_LOG_REGISTER_DEFAULT(pfe_logtype_pmd, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(pfe_logtype_pmd, NOTICE)
diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index 48953dd7a0..bafd5277ae 100644
--- a/drivers/net/ring/rte_eth_ring.c
+++ b/drivers/net/ring/rte_eth_ring.c
@@ -66,7 +66,7 @@ static struct rte_eth_link pmd_link = {
.link_autoneg = RTE_ETH_LINK_FIXED,
};
-RTE_LOG_REGISTER_DEFAULT(eth_ring_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(eth_ring_logtype, NOTICE)
#define PMD_LOG(level, fmt, args...) \
rte_log(RTE_LOG_ ## level, eth_ring_logtype, \
diff --git a/drivers/net/softnic/rte_eth_softnic.c b/drivers/net/softnic/rte_eth_softnic.c
index 1b90cf7a21..b8c779acb6 100644
--- a/drivers/net/softnic/rte_eth_softnic.c
+++ b/drivers/net/softnic/rte_eth_softnic.c
@@ -50,7 +50,7 @@ static const struct softnic_conn_params conn_params_default = {
.msg_handle_arg = NULL,
};
-RTE_LOG_REGISTER_DEFAULT(pmd_softnic_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(pmd_softnic_logtype, NOTICE)
#define PMD_LOG(level, fmt, args...) \
rte_log(RTE_LOG_ ## level, pmd_softnic_logtype, \
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 69d9da695b..df7a213974 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -2598,4 +2598,4 @@ RTE_PMD_REGISTER_PARAM_STRING(net_tap,
ETH_TAP_IFACE_ARG "=<string> "
ETH_TAP_MAC_ARG "=" ETH_TAP_MAC_ARG_FMT " "
ETH_TAP_REMOTE_ARG "=<string>");
-RTE_LOG_REGISTER_DEFAULT(tap_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(tap_logtype, NOTICE)
diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c
index c3e045d892..bdb7e1b5e6 100644
--- a/drivers/net/vdev_netvsc/vdev_netvsc.c
+++ b/drivers/net/vdev_netvsc/vdev_netvsc.c
@@ -48,7 +48,7 @@
#define NETVSC_CLASS_ID "{f8615163-df3e-46c5-913f-f2d2f965ed0e}"
#define NETVSC_MAX_ROUTE_LINE_SIZE 300
-RTE_LOG_REGISTER_DEFAULT(vdev_netvsc_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(vdev_netvsc_logtype, NOTICE)
#define DRV_LOG(level, ...) \
rte_log(RTE_LOG_ ## level, \
diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
index 21bbb008e0..2aa9483205 100644
--- a/drivers/net/vhost/rte_eth_vhost.c
+++ b/drivers/net/vhost/rte_eth_vhost.c
@@ -21,7 +21,7 @@
#include "rte_eth_vhost.h"
-RTE_LOG_REGISTER_DEFAULT(vhost_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(vhost_logtype, NOTICE)
#define VHOST_LOG(level, ...) \
rte_log(RTE_LOG_ ## level, vhost_logtype, __VA_ARGS__)
diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c
index f89bd3f9e2..433b11512b 100644
--- a/drivers/raw/ifpga/ifpga_rawdev.c
+++ b/drivers/raw/ifpga/ifpga_rawdev.c
@@ -1689,7 +1689,7 @@ static struct rte_pci_driver rte_ifpga_rawdev_pmd = {
RTE_PMD_REGISTER_PCI(ifpga_rawdev_pci_driver, rte_ifpga_rawdev_pmd);
RTE_PMD_REGISTER_PCI_TABLE(ifpga_rawdev_pci_driver, rte_ifpga_rawdev_pmd);
RTE_PMD_REGISTER_KMOD_DEP(ifpga_rawdev_pci_driver, "* igb_uio | uio_pci_generic | vfio-pci");
-RTE_LOG_REGISTER_DEFAULT(ifpga_rawdev_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(ifpga_rawdev_logtype, NOTICE)
static const char * const valid_args[] = {
#define IFPGA_ARG_NAME "ifpga"
diff --git a/drivers/raw/ntb/ntb.c b/drivers/raw/ntb/ntb.c
index 0ed4c14592..d0bc8d4fd2 100644
--- a/drivers/raw/ntb/ntb.c
+++ b/drivers/raw/ntb/ntb.c
@@ -1553,4 +1553,4 @@ static struct rte_pci_driver rte_ntb_pmd = {
RTE_PMD_REGISTER_PCI(raw_ntb, rte_ntb_pmd);
RTE_PMD_REGISTER_PCI_TABLE(raw_ntb, pci_id_ntb_map);
RTE_PMD_REGISTER_KMOD_DEP(raw_ntb, "* igb_uio | uio_pci_generic | vfio-pci");
-RTE_LOG_REGISTER_DEFAULT(ntb_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(ntb_logtype, INFO)
diff --git a/drivers/raw/skeleton/skeleton_rawdev.c b/drivers/raw/skeleton/skeleton_rawdev.c
index 6e99d35536..8c8ddc0baa 100644
--- a/drivers/raw/skeleton/skeleton_rawdev.c
+++ b/drivers/raw/skeleton/skeleton_rawdev.c
@@ -775,4 +775,4 @@ static struct rte_vdev_driver skeleton_pmd_drv = {
};
RTE_PMD_REGISTER_VDEV(SKELETON_PMD_RAWDEV_NAME, skeleton_pmd_drv);
-RTE_LOG_REGISTER_DEFAULT(skeleton_pmd_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(skeleton_pmd_logtype, INFO)
diff --git a/lib/acl/rte_acl.c b/lib/acl/rte_acl.c
index 245b9b6d7a..b26358737e 100644
--- a/lib/acl/rte_acl.c
+++ b/lib/acl/rte_acl.c
@@ -10,7 +10,7 @@
#include "acl.h"
#include "acl_log.h"
-RTE_LOG_REGISTER_DEFAULT(acl_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(acl_logtype, INFO)
TAILQ_HEAD(rte_acl_list, rte_tailq_entry);
diff --git a/lib/argparse/rte_argparse.c b/lib/argparse/rte_argparse.c
index 2d953f1694..4e417491fb 100644
--- a/lib/argparse/rte_argparse.c
+++ b/lib/argparse/rte_argparse.c
@@ -10,7 +10,7 @@
#include "rte_argparse.h"
-RTE_LOG_REGISTER_DEFAULT(rte_argparse_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(rte_argparse_logtype, INFO)
#define RTE_LOGTYPE_ARGPARSE rte_argparse_logtype
#define ARGPARSE_LOG(level, ...) \
RTE_LOG_LINE(level, ARGPARSE, "" __VA_ARGS__)
diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c
index 13bde3c25b..25f11157c1 100644
--- a/lib/bbdev/rte_bbdev.c
+++ b/lib/bbdev/rte_bbdev.c
@@ -27,7 +27,7 @@
#define BBDEV_OP_TYPE_COUNT 7
/* BBDev library logging ID */
-RTE_LOG_REGISTER_DEFAULT(bbdev_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(bbdev_logtype, NOTICE)
#define RTE_LOGTYPE_BBDEV bbdev_logtype
/* Helper macro for logging */
diff --git a/lib/bpf/bpf.c b/lib/bpf/bpf.c
index bbe75c8bfe..6840828e8b 100644
--- a/lib/bpf/bpf.c
+++ b/lib/bpf/bpf.c
@@ -49,4 +49,4 @@ __rte_bpf_jit(struct rte_bpf *bpf)
return rc;
}
-RTE_LOG_REGISTER_DEFAULT(rte_bpf_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(rte_bpf_logtype, INFO)
diff --git a/lib/cfgfile/rte_cfgfile.c b/lib/cfgfile/rte_cfgfile.c
index 13ba3957bc..a6b79827b7 100644
--- a/lib/cfgfile/rte_cfgfile.c
+++ b/lib/cfgfile/rte_cfgfile.c
@@ -28,7 +28,7 @@ struct rte_cfgfile {
};
/* Setting up dynamic logging 8< */
-RTE_LOG_REGISTER_DEFAULT(cfgfile_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(cfgfile_logtype, INFO)
#define RTE_LOGTYPE_CFGFILE cfgfile_logtype
#define CFG_LOG(level, ...) \
diff --git a/lib/compressdev/rte_compressdev.c b/lib/compressdev/rte_compressdev.c
index cf2c20a704..b1a584cfd9 100644
--- a/lib/compressdev/rte_compressdev.c
+++ b/lib/compressdev/rte_compressdev.c
@@ -775,4 +775,4 @@ rte_compressdev_name_get(uint8_t dev_id)
return dev->data->name;
}
-RTE_LOG_REGISTER_DEFAULT(compressdev_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(compressdev_logtype, NOTICE)
diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c
index 886eb7adc4..4e540aed0c 100644
--- a/lib/cryptodev/rte_cryptodev.c
+++ b/lib/cryptodev/rte_cryptodev.c
@@ -49,7 +49,7 @@ struct rte_crypto_fp_ops rte_crypto_fp_ops[RTE_CRYPTO_MAX_DEVS];
/* spinlock for crypto device callbacks */
static rte_spinlock_t rte_cryptodev_cb_lock = RTE_SPINLOCK_INITIALIZER;
-RTE_LOG_REGISTER_DEFAULT(rte_cryptodev_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(rte_cryptodev_logtype, INFO)
/**
* The user application callback description.
diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c
index e64b279bac..0265938def 100644
--- a/lib/dmadev/rte_dmadev.c
+++ b/lib/dmadev/rte_dmadev.c
@@ -31,7 +31,7 @@ static struct {
struct rte_dma_dev_data data[0];
} *dma_devices_shared_data;
-RTE_LOG_REGISTER_DEFAULT(rte_dma_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(rte_dma_logtype, INFO)
#define RTE_LOGTYPE_DMADEV rte_dma_logtype
#define RTE_DMA_LOG(level, ...) \
diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c
index d3b732f2e8..0d05b86016 100644
--- a/lib/efd/rte_efd.c
+++ b/lib/efd/rte_efd.c
@@ -29,7 +29,7 @@
#include "rte_efd_arm64.h"
#endif
-RTE_LOG_REGISTER_DEFAULT(efd_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(efd_logtype, INFO)
#define RTE_LOGTYPE_EFD efd_logtype
#define EFD_LOG(level, ...) \
RTE_LOG_LINE(level, EFD, "" __VA_ARGS__)
diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index f1c658f49e..be32f08cda 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -7008,4 +7008,4 @@ int rte_eth_dev_map_aggr_tx_affinity(uint16_t port_id, uint16_t tx_queue_id,
return ret;
}
-RTE_LOG_REGISTER_DEFAULT(rte_eth_dev_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(rte_eth_dev_logtype, INFO)
diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c
index ca295c87c4..c5d0c2ebce 100644
--- a/lib/eventdev/rte_eventdev.c
+++ b/lib/eventdev/rte_eventdev.c
@@ -29,7 +29,7 @@
#include "eventdev_pmd.h"
#include "eventdev_trace.h"
-RTE_LOG_REGISTER_DEFAULT(rte_event_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(rte_event_logtype, INFO)
static struct rte_eventdev rte_event_devices[RTE_EVENT_MAX_DEVS];
diff --git a/lib/fib/rte_fib.c b/lib/fib/rte_fib.c
index 4f9fba5a4f..cef8bf736d 100644
--- a/lib/fib/rte_fib.c
+++ b/lib/fib/rte_fib.c
@@ -19,7 +19,7 @@
#include "dir24_8.h"
#include "fib_log.h"
-RTE_LOG_REGISTER_DEFAULT(fib_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(fib_logtype, INFO)
TAILQ_HEAD(rte_fib_list, rte_tailq_entry);
static struct rte_tailq_elem rte_fib_tailq = {
diff --git a/lib/gpudev/gpudev.c b/lib/gpudev/gpudev.c
index 1c2011b856..685caa36c4 100644
--- a/lib/gpudev/gpudev.c
+++ b/lib/gpudev/gpudev.c
@@ -16,7 +16,7 @@
#include "gpudev_driver.h"
/* Logging */
-RTE_LOG_REGISTER_DEFAULT(gpu_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(gpu_logtype, NOTICE)
#define RTE_LOGTYPE_GPUDEV gpu_logtype
#define GPU_LOG(level, ...) \
diff --git a/lib/graph/graph.c b/lib/graph/graph.c
index 26f0968a97..ebdef92b56 100644
--- a/lib/graph/graph.c
+++ b/lib/graph/graph.c
@@ -761,4 +761,4 @@ rte_graph_max_count(void)
return graph_id;
}
-RTE_LOG_REGISTER_DEFAULT(rte_graph_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(rte_graph_logtype, INFO)
diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
index 9cf94645f6..5a1019d68d 100644
--- a/lib/hash/rte_cuckoo_hash.c
+++ b/lib/hash/rte_cuckoo_hash.c
@@ -26,7 +26,7 @@
#include "rte_hash.h"
/* needs to be before rte_cuckoo_hash.h */
-RTE_LOG_REGISTER_DEFAULT(hash_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(hash_logtype, INFO)
#define RTE_LOGTYPE_HASH hash_logtype
#define HASH_LOG(level, ...) \
RTE_LOG_LINE(level, HASH, "" __VA_ARGS__)
diff --git a/lib/ip_frag/rte_ip_frag_common.c b/lib/ip_frag/rte_ip_frag_common.c
index 05f9e479c2..f84b226c93 100644
--- a/lib/ip_frag/rte_ip_frag_common.c
+++ b/lib/ip_frag/rte_ip_frag_common.c
@@ -7,7 +7,7 @@
#include <rte_log.h>
-RTE_LOG_REGISTER_DEFAULT(ipfrag_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(ipfrag_logtype, INFO)
#include "ip_frag_common.h"
diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c
index 4ea9b0d75b..d0a1597466 100644
--- a/lib/latencystats/rte_latencystats.c
+++ b/lib/latencystats/rte_latencystats.c
@@ -25,7 +25,7 @@ latencystat_cycles_per_ns(void)
return rte_get_timer_hz() / NS_PER_SEC;
}
-RTE_LOG_REGISTER_DEFAULT(latencystat_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(latencystat_logtype, INFO)
#define RTE_LOGTYPE_LATENCY_STATS latencystat_logtype
#define LATENCY_STATS_LOG(level, ...) \
RTE_LOG_LINE(level, LATENCY_STATS, "" __VA_ARGS__)
diff --git a/lib/lpm/rte_lpm.c b/lib/lpm/rte_lpm.c
index 9633d637c7..c58c34f29c 100644
--- a/lib/lpm/rte_lpm.c
+++ b/lib/lpm/rte_lpm.c
@@ -20,7 +20,7 @@
#include "rte_lpm.h"
#include "lpm_log.h"
-RTE_LOG_REGISTER_DEFAULT(lpm_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(lpm_logtype, INFO)
TAILQ_HEAD(rte_lpm_list, rte_tailq_entry);
diff --git a/lib/mbuf/rte_mbuf.c b/lib/mbuf/rte_mbuf.c
index 559d5ad8a7..0970a96d1e 100644
--- a/lib/mbuf/rte_mbuf.c
+++ b/lib/mbuf/rte_mbuf.c
@@ -22,7 +22,7 @@
#include "mbuf_log.h"
-RTE_LOG_REGISTER_DEFAULT(mbuf_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(mbuf_logtype, INFO)
/*
* pktmbuf pool constructor, given as a callback function to
diff --git a/lib/member/rte_member.c b/lib/member/rte_member.c
index 57eb7affab..23c72ab720 100644
--- a/lib/member/rte_member.c
+++ b/lib/member/rte_member.c
@@ -371,4 +371,4 @@ rte_member_reset(const struct rte_member_setsum *setsum)
}
}
-RTE_LOG_REGISTER_DEFAULT(librte_member_logtype, DEBUG);
+RTE_LOG_REGISTER_DEFAULT(librte_member_logtype, DEBUG)
diff --git a/lib/mempool/rte_mempool.c b/lib/mempool/rte_mempool.c
index 12390a2c81..b4b9f95dd9 100644
--- a/lib/mempool/rte_mempool.c
+++ b/lib/mempool/rte_mempool.c
@@ -31,7 +31,7 @@
#include "mempool_trace.h"
#include "rte_mempool.h"
-RTE_LOG_REGISTER_DEFAULT(rte_mempool_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(rte_mempool_logtype, INFO)
TAILQ_HEAD(rte_mempool_list, rte_tailq_entry);
diff --git a/lib/metrics/rte_metrics_telemetry.c b/lib/metrics/rte_metrics_telemetry.c
index dc43611d29..d673e53796 100644
--- a/lib/metrics/rte_metrics_telemetry.c
+++ b/lib/metrics/rte_metrics_telemetry.c
@@ -528,7 +528,7 @@ handle_ports_stats_values_by_name(const char *cmd __rte_unused,
return used;
}
-RTE_LOG_REGISTER_DEFAULT(metrics_log_level, ERR);
+RTE_LOG_REGISTER_DEFAULT(metrics_log_level, ERR)
RTE_INIT(metrics_ctor)
{
diff --git a/lib/mldev/rte_mldev.c b/lib/mldev/rte_mldev.c
index 196b1850e6..0ca98919f4 100644
--- a/lib/mldev/rte_mldev.c
+++ b/lib/mldev/rte_mldev.c
@@ -907,4 +907,4 @@ rte_ml_op_error_get(int16_t dev_id, struct rte_ml_op *op, struct rte_ml_op_error
return (*dev->op_error_get)(dev, op, error);
}
-RTE_LOG_REGISTER_DEFAULT(rte_ml_dev_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(rte_ml_dev_logtype, INFO)
diff --git a/lib/net/rte_net_crc.c b/lib/net/rte_net_crc.c
index 346c285c15..92e9f8687f 100644
--- a/lib/net/rte_net_crc.c
+++ b/lib/net/rte_net_crc.c
@@ -70,7 +70,7 @@ static const rte_net_crc_handler handlers_neon[] = {
static uint16_t max_simd_bitwidth;
-RTE_LOG_REGISTER_DEFAULT(libnet_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(libnet_logtype, INFO)
#define RTE_LOGTYPE_NET libnet_logtype
#define NET_LOG(level, ...) \
diff --git a/lib/node/log.c b/lib/node/log.c
index a6578ee33b..3ad9766aa7 100644
--- a/lib/node/log.c
+++ b/lib/node/log.c
@@ -4,4 +4,4 @@
#include "node_private.h"
-RTE_LOG_REGISTER_DEFAULT(rte_node_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(rte_node_logtype, INFO)
diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c
index 679c3dd0b5..5bce138e4e 100644
--- a/lib/pdump/rte_pdump.c
+++ b/lib/pdump/rte_pdump.c
@@ -15,7 +15,7 @@
#include "rte_pdump.h"
-RTE_LOG_REGISTER_DEFAULT(pdump_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(pdump_logtype, NOTICE)
#define RTE_LOGTYPE_PDUMP pdump_logtype
#define PDUMP_LOG_LINE(level, ...) \
diff --git a/lib/pipeline/rte_pipeline.c b/lib/pipeline/rte_pipeline.c
index a09a89f746..fb098215d7 100644
--- a/lib/pipeline/rte_pipeline.c
+++ b/lib/pipeline/rte_pipeline.c
@@ -12,7 +12,7 @@
#include "rte_pipeline.h"
-RTE_LOG_REGISTER_DEFAULT(pipeline_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(pipeline_logtype, INFO)
#define RTE_LOGTYPE_PIPELINE pipeline_logtype
#define PIPELINE_LOG(level, ...) \
diff --git a/lib/port/port_log.c b/lib/port/port_log.c
index e7a10d80ef..c1b9467ba4 100644
--- a/lib/port/port_log.c
+++ b/lib/port/port_log.c
@@ -4,4 +4,4 @@
#include <rte_log.h>
-RTE_LOG_REGISTER_DEFAULT(port_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(port_logtype, INFO)
diff --git a/lib/power/power_common.c b/lib/power/power_common.c
index 590986d5ef..339201cd81 100644
--- a/lib/power/power_common.c
+++ b/lib/power/power_common.c
@@ -12,7 +12,7 @@
#include "power_common.h"
-RTE_LOG_REGISTER_DEFAULT(power_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(power_logtype, INFO)
#define POWER_SYSFILE_SCALING_DRIVER \
"/sys/devices/system/cpu/cpu%u/cpufreq/scaling_driver"
diff --git a/lib/rawdev/rte_rawdev.c b/lib/rawdev/rte_rawdev.c
index 4f8897b639..4cc7fdcaf2 100644
--- a/lib/rawdev/rte_rawdev.c
+++ b/lib/rawdev/rte_rawdev.c
@@ -677,7 +677,7 @@ handle_dev_dump(const char *cmd __rte_unused,
return 0;
}
-RTE_LOG_REGISTER_DEFAULT(librawdev_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(librawdev_logtype, INFO)
RTE_INIT(librawdev_init_telemetry)
{
diff --git a/lib/rcu/rte_rcu_qsbr.c b/lib/rcu/rte_rcu_qsbr.c
index f08d974d07..e304ca3867 100644
--- a/lib/rcu/rte_rcu_qsbr.c
+++ b/lib/rcu/rte_rcu_qsbr.c
@@ -476,4 +476,4 @@ rte_rcu_qsbr_dq_delete(struct rte_rcu_qsbr_dq *dq)
return 0;
}
-RTE_LOG_REGISTER_DEFAULT(rte_rcu_log_type, ERR);
+RTE_LOG_REGISTER_DEFAULT(rte_rcu_log_type, ERR)
diff --git a/lib/regexdev/rte_regexdev.c b/lib/regexdev/rte_regexdev.c
index b2c4b49d97..1aa769e86b 100644
--- a/lib/regexdev/rte_regexdev.c
+++ b/lib/regexdev/rte_regexdev.c
@@ -19,7 +19,7 @@ static struct {
struct rte_regexdev_data data[RTE_MAX_REGEXDEV_DEVS];
} *rte_regexdev_shared_data;
-RTE_LOG_REGISTER_DEFAULT(rte_regexdev_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(rte_regexdev_logtype, INFO)
static uint16_t
regexdev_find_free_dev(void)
diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c
index ae97e1a34d..59a38de61e 100644
--- a/lib/reorder/rte_reorder.c
+++ b/lib/reorder/rte_reorder.c
@@ -17,7 +17,7 @@
#include "rte_reorder.h"
-RTE_LOG_REGISTER_DEFAULT(reorder_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(reorder_logtype, INFO)
#define RTE_LOGTYPE_REORDER reorder_logtype
#define REORDER_LOG(level, ...) \
RTE_LOG_LINE(level, REORDER, "" __VA_ARGS__)
diff --git a/lib/rib/rte_rib.c b/lib/rib/rte_rib.c
index aa3296de19..d811d92f6a 100644
--- a/lib/rib/rte_rib.c
+++ b/lib/rib/rte_rib.c
@@ -18,7 +18,7 @@
#include "rib_log.h"
-RTE_LOG_REGISTER_DEFAULT(rib_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(rib_logtype, INFO)
TAILQ_HEAD(rte_rib_list, rte_tailq_entry);
static struct rte_tailq_elem rte_rib_tailq = {
diff --git a/lib/ring/rte_ring.c b/lib/ring/rte_ring.c
index aebb6d6728..826d35147e 100644
--- a/lib/ring/rte_ring.c
+++ b/lib/ring/rte_ring.c
@@ -28,7 +28,7 @@
#include "rte_ring.h"
#include "rte_ring_elem.h"
-RTE_LOG_REGISTER_DEFAULT(ring_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(ring_logtype, INFO)
#define RTE_LOGTYPE_RING ring_logtype
#define RING_LOG(level, ...) \
RTE_LOG_LINE(level, RING, "" __VA_ARGS__)
diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c
index bbdb5d1d86..76c5ce66db 100644
--- a/lib/sched/rte_sched.c
+++ b/lib/sched/rte_sched.c
@@ -3004,4 +3004,4 @@ rte_sched_port_dequeue(struct rte_sched_port *port, struct rte_mbuf **pkts, uint
return count;
}
-RTE_LOG_REGISTER_DEFAULT(sched_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(sched_logtype, INFO)
diff --git a/lib/stack/rte_stack.c b/lib/stack/rte_stack.c
index 7261281dc1..a6e614edb5 100644
--- a/lib/stack/rte_stack.c
+++ b/lib/stack/rte_stack.c
@@ -193,4 +193,4 @@ rte_stack_lookup(const char *name)
return r;
}
-RTE_LOG_REGISTER_DEFAULT(stack_logtype, NOTICE);
+RTE_LOG_REGISTER_DEFAULT(stack_logtype, NOTICE)
diff --git a/lib/table/table_log.c b/lib/table/table_log.c
index b329edd2e6..48a4f2be1d 100644
--- a/lib/table/table_log.c
+++ b/lib/table/table_log.c
@@ -4,4 +4,4 @@
#include <rte_log.h>
-RTE_LOG_REGISTER_DEFAULT(table_logtype, INFO);
+RTE_LOG_REGISTER_DEFAULT(table_logtype, INFO)
diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c
index 1663bd8c68..1a2477729e 100644
--- a/lib/telemetry/telemetry.c
+++ b/lib/telemetry/telemetry.c
@@ -55,7 +55,7 @@ static const char *telemetry_version; /* save rte_version */
static const char *socket_dir; /* runtime directory */
static rte_cpuset_t *thread_cpuset;
-RTE_LOG_REGISTER_DEFAULT(logtype, WARNING);
+RTE_LOG_REGISTER_DEFAULT(logtype, WARNING)
#define RTE_LOGTYPE_TELEMETRY logtype
#define TMTY_LOG_LINE(l, ...) RTE_LOG_LINE(l, TELEMETRY, "" __VA_ARGS__)
--
2.43.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [RFC] fix semicolon at the end of RTE_LOG_REGISTER_DEFAULT
2024-04-20 0:08 [RFC] fix semicolon at the end of RTE_LOG_REGISTER_DEFAULT Stephen Hemminger
@ 2024-04-20 7:48 ` Morten Brørup
2024-04-22 15:13 ` Stephen Hemminger
0 siblings, 1 reply; 6+ messages in thread
From: Morten Brørup @ 2024-04-20 7:48 UTC (permalink / raw)
To: Stephen Hemminger, dev
Cc: Nicolas Chautru, Gagandeep Singh, Hemant Agrawal, Parav Pandit,
Xueming Li, Nipun Gupta, Nikhil Agarwal, Sachin Saxena, Rosen Xu,
Tomasz Duszynski, Chengwen Feng, Long Li, Nithin Dabilpuram,
Kiran Kumar K, Sunil Kumar Kori, Satha Rao, Harman Kalra,
Jingjing Wu, Nagadheeraj Rottela, Srikanth Jampala,
Andrew Rybchenko, Lee Daly, Pablo de Lara, Fan Zhang,
Ashish Gupta, Sunila Sahu, Ruifeng Wang, Michael Shamis,
Liron Himi, Kai Ji, Anoob Joseph, Zhangfei Gao, Bruce Richardson,
Kevin Laatz, Conor Walsh, Abdullah Sevincer, Jerin Jacob,
Harry van Haaren, Elena Agostini, John W. Linville, Ciara Loftus,
Shepard Siegel, Ed Czeck, John Miller, Rahul Lakkireddy,
Apeksha Gupta, John Daley, Hyong Youb Kim, Ziyang Xuan,
Xiaoyun Wang, Guoyang Zhou, Andrew Boyer, Jakub Grajciar,
Zyta Szpak, Martin Spinler, Tetsuya Mukawa, Vamsi Attunuru,
Cristian Dumitrescu, Matan Azrad, Maxime Coquelin, Chenbo Xia,
Konstantin Ananyev, Akhil Goyal, Byron Marohn, Yipeng Wang,
Thomas Monjalon, Ferruh Yigit, Vladimir Medvedkin, Zhirun Yan,
Sameh Gobriel, Reshma Pattan, Srikanth Yalavarthi,
Jasvinder Singh, Pavan Nikhilesh, Anatoly Burakov, David Hunt,
Sivaprasad Tummala, Honnappa Nagarahalli, Ori Kam,
Volodymyr Fialko, Ciara Power
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Saturday, 20 April 2024 02.08
>
> The macro RTE_LOG_REGISTER_DEFAULT emits code for an initialization
> function. If a driver (and most do) adds a semicolon after the macro.
>
> RTE_LOG_REGISTER_DEFAULT(logtype_foo, INFO);
>
> Is equivalent to:
>
> int logtype_foo;
> static void __logtype_foo(void) {
> logtype_foo = rte_log_register_type_and_pick_level(name,
> RTE_LOG_INFO);
> if (type < 0)
> logtype_foo = RTE_LOGTYPE_EAL;
> };
> The problem is that extra semi-colon after the function.
>
> If code is built with highest level of warnings (pedantic),
> then it will generate a warning.
> warning: ISO C does not allow extra ‘;’ outside of a function
>
> This is a treewide fix for this.
It seems weird omitting the semicolon when using this macro.
How about using the same trick as RTE_INIT_PRIO():
#define RTE_INIT_PRIO(name, priority) \
static void name(void); \
static int __cdecl name ## _thunk(void) { name(); return 0; } \
__pragma(const_seg(CTOR_PRIORITY_TO_SECTION(priority))) \
__declspec(allocate(CTOR_PRIORITY_TO_SECTION(priority))) \
_PIFV name ## _pointer = &name ## _thunk; \
__pragma(const_seg()) \
static void name(void)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC] fix semicolon at the end of RTE_LOG_REGISTER_DEFAULT
2024-04-20 7:48 ` Morten Brørup
@ 2024-04-22 15:13 ` Stephen Hemminger
2024-04-22 15:24 ` Morten Brørup
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2024-04-22 15:13 UTC (permalink / raw)
To: Morten Brørup
Cc: dev, Nicolas Chautru, Gagandeep Singh, Hemant Agrawal,
Parav Pandit, Xueming Li, Nipun Gupta, Nikhil Agarwal,
Sachin Saxena, Rosen Xu, Tomasz Duszynski, Chengwen Feng,
Long Li, Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori,
Satha Rao, Harman Kalra, Jingjing Wu, Nagadheeraj Rottela,
Srikanth Jampala, Andrew Rybchenko, Lee Daly, Pablo de Lara,
Fan Zhang, Ashish Gupta, Sunila Sahu, Ruifeng Wang,
Michael Shamis, Liron Himi, Kai Ji, Anoob Joseph, Zhangfei Gao,
Bruce Richardson, Kevin Laatz, Conor Walsh, Abdullah Sevincer,
Jerin Jacob, Harry van Haaren, Elena Agostini, John W. Linville,
Ciara Loftus, Shepard Siegel, Ed Czeck, John Miller,
Rahul Lakkireddy, Apeksha Gupta, John Daley, Hyong Youb Kim,
Ziyang Xuan, Xiaoyun Wang, Guoyang Zhou, Andrew Boyer,
Jakub Grajciar, Zyta Szpak, Martin Spinler, Tetsuya Mukawa,
Vamsi Attunuru, Cristian Dumitrescu, Matan Azrad,
Maxime Coquelin, Chenbo Xia, Konstantin Ananyev, Akhil Goyal,
Byron Marohn, Yipeng Wang, Thomas Monjalon, Ferruh Yigit,
Vladimir Medvedkin, Zhirun Yan, Sameh Gobriel, Reshma Pattan,
Srikanth Yalavarthi, Jasvinder Singh, Pavan Nikhilesh,
Anatoly Burakov, David Hunt, Sivaprasad Tummala,
Honnappa Nagarahalli, Ori Kam, Volodymyr Fialko, Ciara Power
On Sat, 20 Apr 2024 09:48:24 +0200
Morten Brørup <mb@smartsharesystems.com> wrote:
> > From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > Sent: Saturday, 20 April 2024 02.08
> >
> > The macro RTE_LOG_REGISTER_DEFAULT emits code for an initialization
> > function. If a driver (and most do) adds a semicolon after the macro.
> >
> > RTE_LOG_REGISTER_DEFAULT(logtype_foo, INFO);
> >
> > Is equivalent to:
> >
> > int logtype_foo;
> > static void __logtype_foo(void) {
> > logtype_foo = rte_log_register_type_and_pick_level(name,
> > RTE_LOG_INFO);
> > if (type < 0)
> > logtype_foo = RTE_LOGTYPE_EAL;
> > };
> > The problem is that extra semi-colon after the function.
> >
> > If code is built with highest level of warnings (pedantic),
> > then it will generate a warning.
> > warning: ISO C does not allow extra ‘;’ outside of a function
> >
> > This is a treewide fix for this.
>
> It seems weird omitting the semicolon when using this macro.
>
> How about using the same trick as RTE_INIT_PRIO():
>
> #define RTE_INIT_PRIO(name, priority) \
> static void name(void); \
> static int __cdecl name ## _thunk(void) { name(); return 0; } \
> __pragma(const_seg(CTOR_PRIORITY_TO_SECTION(priority))) \
> __declspec(allocate(CTOR_PRIORITY_TO_SECTION(priority))) \
> _PIFV name ## _pointer = &name ## _thunk; \
> __pragma(const_seg()) \
> static void name(void)
RTE_INIT_PRIO is what is causing the problem. My example comes from:
RTE_LOG_REGISTER_DEFAULT() -> RTE_LOG_REGISTER_IMPL() -> RTE_INIT -> RTE_INIT_PRIO
The last line is used as prefix before RTE_LOG_REGISTER_IMPL that defines
the init function full expansion is:
// from RTE_LOG_REGISTER_IMPL
int logtype_foo;
// from RTE_INIT_PRIO
static void __logtype_foo(void);
static int __cdecl __logtype_foo_thunk(void) { __logtype_foo(); return 0; }
__pragma(const_seg(CTOR_PRIORITY_TO_SECTION(priority)))
__declspec(allocate(CTOR_PRIORITY_TO_SECTION(priority)))
_PIFV __logtype_foo ## _pointer = &__logtype_foo_thunk;
__pragma(const_seg())
static void __logtype_foo(void)
// from RTE_LOG_REGISTER_IMPL
logtype_foo = rte_log_register_logtype_foo_and_pick_level(__logtype_foo, RTE_LOG_##level);
if (logtype_foo < 0)
logtype_foo = RTE_LOGLOGTYPE_FOO_EAL;
} // no ; here is allowed
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [RFC] fix semicolon at the end of RTE_LOG_REGISTER_DEFAULT
2024-04-22 15:13 ` Stephen Hemminger
@ 2024-04-22 15:24 ` Morten Brørup
2024-04-22 16:20 ` Stephen Hemminger
0 siblings, 1 reply; 6+ messages in thread
From: Morten Brørup @ 2024-04-22 15:24 UTC (permalink / raw)
To: Stephen Hemminger
Cc: dev, Nicolas Chautru, Gagandeep Singh, Hemant Agrawal,
Parav Pandit, Xueming Li, Nipun Gupta, Nikhil Agarwal,
Sachin Saxena, Rosen Xu, Tomasz Duszynski, Chengwen Feng,
Long Li, Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori,
Satha Rao, Harman Kalra, Jingjing Wu, Nagadheeraj Rottela,
Srikanth Jampala, Andrew Rybchenko, Lee Daly, Pablo de Lara,
Fan Zhang, Ashish Gupta, Sunila Sahu, Ruifeng Wang,
Michael Shamis, Liron Himi, Kai Ji, Anoob Joseph, Zhangfei Gao,
Bruce Richardson, Kevin Laatz, Conor Walsh, Abdullah Sevincer,
Jerin Jacob, Harry van Haaren, Elena Agostini, John W. Linville,
Ciara Loftus, Shepard Siegel, Ed Czeck, John Miller,
Rahul Lakkireddy, Apeksha Gupta, John Daley, Hyong Youb Kim,
Ziyang Xuan, Xiaoyun Wang, Guoyang Zhou, Andrew Boyer,
Jakub Grajciar, Zyta Szpak, Martin Spinler, Tetsuya Mukawa,
Vamsi Attunuru, Cristian Dumitrescu, Matan Azrad,
Maxime Coquelin, Chenbo Xia, Konstantin Ananyev, Akhil Goyal,
Byron Marohn, Yipeng Wang, Thomas Monjalon, Ferruh Yigit,
Vladimir Medvedkin, Zhirun Yan, Sameh Gobriel, Reshma Pattan,
Srikanth Yalavarthi, Jasvinder Singh, Pavan Nikhilesh,
Anatoly Burakov, David Hunt, Sivaprasad Tummala,
Honnappa Nagarahalli, Ori Kam, Volodymyr Fialko, Ciara Power
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Monday, 22 April 2024 17.14
>
> On Sat, 20 Apr 2024 09:48:24 +0200
> Morten Brørup <mb@smartsharesystems.com> wrote:
>
> > > From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > > Sent: Saturday, 20 April 2024 02.08
> > >
> > > The macro RTE_LOG_REGISTER_DEFAULT emits code for an initialization
> > > function. If a driver (and most do) adds a semicolon after the macro.
> > >
> > > RTE_LOG_REGISTER_DEFAULT(logtype_foo, INFO);
> > >
> > > Is equivalent to:
> > >
> > > int logtype_foo;
> > > static void __logtype_foo(void) {
> > > logtype_foo = rte_log_register_type_and_pick_level(name,
> > > RTE_LOG_INFO);
> > > if (type < 0)
> > > logtype_foo = RTE_LOGTYPE_EAL;
> > > };
> > > The problem is that extra semi-colon after the function.
> > >
> > > If code is built with highest level of warnings (pedantic),
> > > then it will generate a warning.
> > > warning: ISO C does not allow extra ‘;’ outside of a function
> > >
> > > This is a treewide fix for this.
> >
> > It seems weird omitting the semicolon when using this macro.
> >
> > How about using the same trick as RTE_INIT_PRIO():
> >
> > #define RTE_INIT_PRIO(name, priority) \
> > static void name(void); \
> > static int __cdecl name ## _thunk(void) { name(); return 0; } \
> > __pragma(const_seg(CTOR_PRIORITY_TO_SECTION(priority))) \
> > __declspec(allocate(CTOR_PRIORITY_TO_SECTION(priority))) \
> > _PIFV name ## _pointer = &name ## _thunk; \
> > __pragma(const_seg()) \
> > static void name(void)
>
>
> RTE_INIT_PRIO is what is causing the problem. My example comes from:
> RTE_LOG_REGISTER_DEFAULT() -> RTE_LOG_REGISTER_IMPL() -> RTE_INIT ->
> RTE_INIT_PRIO
>
> The last line is used as prefix before RTE_LOG_REGISTER_IMPL that defines
> the init function full expansion is:
>
> // from RTE_LOG_REGISTER_IMPL
> int logtype_foo;
> // from RTE_INIT_PRIO
> static void __logtype_foo(void);
> static int __cdecl __logtype_foo_thunk(void) { __logtype_foo(); return 0; }
> __pragma(const_seg(CTOR_PRIORITY_TO_SECTION(priority)))
> __declspec(allocate(CTOR_PRIORITY_TO_SECTION(priority)))
> _PIFV __logtype_foo ## _pointer = &__logtype_foo_thunk;
> __pragma(const_seg())
> static void __logtype_foo(void)
> // from RTE_LOG_REGISTER_IMPL
> logtype_foo = rte_log_register_logtype_foo_and_pick_level(__logtype_foo,
> RTE_LOG_##level);
> if (logtype_foo < 0)
> logtype_foo = RTE_LOGLOGTYPE_FOO_EAL;
> } // no ; here is allowed
>
>
OK.
Perhaps adding a dummy afterwards or moving the global "type" variable down would work:
#define RTE_LOG_REGISTER_IMPL(type, name, level) \
int type; \
RTE_INIT(__##type) \
{ \
type = rte_log_register_type_and_pick_level(name, RTE_LOG_##level); \
if (type < 0) \
type = RTE_LOGTYPE_EAL; \
} \
+ int __dummy_##type
Or:
#define RTE_LOG_REGISTER_IMPL(type, name, level) \
- int type; \
+ extern int type; \
RTE_INIT(__##type) \
{ \
type = rte_log_register_type_and_pick_level(name, RTE_LOG_##level); \
if (type < 0) \
type = RTE_LOGTYPE_EAL; \
} \
+ int type
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC] fix semicolon at the end of RTE_LOG_REGISTER_DEFAULT
2024-04-22 15:24 ` Morten Brørup
@ 2024-04-22 16:20 ` Stephen Hemminger
2024-04-22 16:32 ` Morten Brørup
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2024-04-22 16:20 UTC (permalink / raw)
To: Morten Brørup
Cc: dev, Nicolas Chautru, Gagandeep Singh, Hemant Agrawal,
Parav Pandit, Xueming Li, Nipun Gupta, Nikhil Agarwal,
Sachin Saxena, Rosen Xu, Tomasz Duszynski, Chengwen Feng,
Long Li, Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori,
Satha Rao, Harman Kalra, Jingjing Wu, Nagadheeraj Rottela,
Srikanth Jampala, Andrew Rybchenko, Lee Daly, Pablo de Lara,
Fan Zhang, Ashish Gupta, Sunila Sahu, Ruifeng Wang,
Michael Shamis, Liron Himi, Kai Ji, Anoob Joseph, Zhangfei Gao,
Bruce Richardson, Kevin Laatz, Conor Walsh, Abdullah Sevincer,
Jerin Jacob, Harry van Haaren, Elena Agostini, John W. Linville,
Ciara Loftus, Shepard Siegel, Ed Czeck, John Miller,
Rahul Lakkireddy, Apeksha Gupta, John Daley, Hyong Youb Kim,
Ziyang Xuan, Xiaoyun Wang, Guoyang Zhou, Andrew Boyer,
Jakub Grajciar, Zyta Szpak, Martin Spinler, Tetsuya Mukawa,
Vamsi Attunuru, Cristian Dumitrescu, Matan Azrad,
Maxime Coquelin, Chenbo Xia, Konstantin Ananyev, Akhil Goyal,
Byron Marohn, Yipeng Wang, Thomas Monjalon, Ferruh Yigit,
Vladimir Medvedkin, Zhirun Yan, Sameh Gobriel, Reshma Pattan,
Srikanth Yalavarthi, Jasvinder Singh, Pavan Nikhilesh,
Anatoly Burakov, David Hunt, Sivaprasad Tummala,
Honnappa Nagarahalli, Ori Kam, Volodymyr Fialko, Ciara Power
On Mon, 22 Apr 2024 17:24:43 +0200
Morten Brørup <mb@smartsharesystems.com> wrote:
> #define RTE_LOG_REGISTER_IMPL(type, name, level) \
> - int type; \
> + extern int type; \
> RTE_INIT(__##type) \
> { \
> type = rte_log_register_type_and_pick_level(name, RTE_LOG_##level); \
> if (type < 0) \
> type = RTE_LOGTYPE_EAL; \
> } \
> + int type
Not all logtypes can/should be extern.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [RFC] fix semicolon at the end of RTE_LOG_REGISTER_DEFAULT
2024-04-22 16:20 ` Stephen Hemminger
@ 2024-04-22 16:32 ` Morten Brørup
0 siblings, 0 replies; 6+ messages in thread
From: Morten Brørup @ 2024-04-22 16:32 UTC (permalink / raw)
To: Stephen Hemminger
Cc: dev, Nicolas Chautru, Gagandeep Singh, Hemant Agrawal,
Parav Pandit, Xueming Li, Nipun Gupta, Nikhil Agarwal,
Sachin Saxena, Rosen Xu, Tomasz Duszynski, Chengwen Feng,
Long Li, Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori,
Satha Rao, Harman Kalra, Jingjing Wu, Nagadheeraj Rottela,
Srikanth Jampala, Andrew Rybchenko, Lee Daly, Pablo de Lara,
Fan Zhang, Ashish Gupta, Sunila Sahu, Ruifeng Wang, Liron Himi,
Kai Ji, Anoob Joseph, Zhangfei Gao, Bruce Richardson,
Kevin Laatz, Conor Walsh, Abdullah Sevincer, Jerin Jacob,
Harry van Haaren, Elena Agostini, John W. Linville, Ciara Loftus,
Shepard Siegel, Ed Czeck, John Miller, Rahul Lakkireddy,
Apeksha Gupta, John Daley, Hyong Youb Kim, Ziyang Xuan,
Xiaoyun Wang, Andrew Boyer, Jakub Grajciar, Zyta Szpak,
Martin Spinler, Tetsuya Mukawa, Vamsi Attunuru,
Cristian Dumitrescu, Matan Azrad, Maxime Coquelin, Chenbo Xia,
Konstantin Ananyev, Akhil Goyal, Byron Marohn, Yipeng Wang,
Thomas Monjalon, Ferruh Yigit, Vladimir Medvedkin, Zhirun Yan,
Sameh Gobriel, Reshma Pattan, Srikanth Yalavarthi,
Jasvinder Singh, Pavan Nikhilesh, Anatoly Burakov, David Hunt,
Sivaprasad Tummala, Honnappa Nagarahalli, Ori Kam,
Volodymyr Fialko, Ciara Power
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Monday, 22 April 2024 18.20
>
> On Mon, 22 Apr 2024 17:24:43 +0200
> Morten Brørup <mb@smartsharesystems.com> wrote:
>
> > #define RTE_LOG_REGISTER_IMPL(type, name, level) \
> > - int type; \
> > + extern int type; \
> > RTE_INIT(__##type) \
> > { \
> > type = rte_log_register_type_and_pick_level(name,
> RTE_LOG_##level); \
> > if (type < 0)
> \
> > type = RTE_LOGTYPE_EAL;
> \
> > } \
> > + int type
>
>
> Not all logtypes can/should be extern.
Creativity just kicked in:
#define RTE_LOG_REGISTER_IMPL(type, name, level) \
int type; \
RTE_INIT(__##type) \
{ \
type = rte_log_register_type_and_pick_level(name, RTE_LOG_##level); \
if (type < 0) \
type = RTE_LOGTYPE_EAL; \
} \
+ static_assert(1 == 1, "Dummy for semicolon.")
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-04-22 16:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-20 0:08 [RFC] fix semicolon at the end of RTE_LOG_REGISTER_DEFAULT Stephen Hemminger
2024-04-20 7:48 ` Morten Brørup
2024-04-22 15:13 ` Stephen Hemminger
2024-04-22 15:24 ` Morten Brørup
2024-04-22 16:20 ` Stephen Hemminger
2024-04-22 16:32 ` Morten Brørup
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).