DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] i40evf: fix crash when setup tx queues on vf port
Date: Thu, 30 Jul 2015 00:41:58 +0000	[thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F8C9279F@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1517577.ZUUS3DXQqZ@xps13>



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, July 30, 2015 6:33 AM
> To: Wu, Jingjing
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3] i40evf: fix crash when setup tx queues
> on vf port
> 
> > This patch fixes the issue:
> > Testpmd crashed with Segmentation fault when setup tx queues on vf
> > Steps for reproduce:
> >   - create one vf device from i40e driver
> >   - bind vf device to igb_uio and start testpmd
> >
> > With debugging tools, we saw the struct i40e_vf is cleared after
> > memcpy(&dev->data->dev_conf, dev_conf, sizeof(dev->data->dev_conf))
> in
> > rte_eth_dev_configure, which should not happen, and the pointer to
> > i40e_vf isn't in the range of i40e_adapter.
> >
> > The root cause is the dev_private_size in i40e virtual function driver
> > struct rte_i40evf_pmd was set incorrectly.
> >
> > Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> 
> Applied, thanks
> 
> Does it mean that Tx with i40evf never worked before?

Actually we didn't face crash with previous version, i40vf tx works before, what makes me surprised. Maybe just lucky. 

      reply	other threads:[~2015-07-30  0:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28  1:13 [dpdk-dev] [PATCH] i40e: correct the private data size for i40e vf driver Jingjing Wu
2015-07-28  1:27 ` Liu, Yong
2015-07-28  8:11 ` Thomas Monjalon
2015-07-28  9:01 ` [dpdk-dev] [PATCH V2] i40evf: fix crash when setup tx queues on vf port Jingjing Wu
2015-07-29  0:54   ` [dpdk-dev] [PATCH v3] " Jingjing Wu
2015-07-29 22:33     ` Thomas Monjalon
2015-07-30  0:41       ` Wu, Jingjing [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9BB6961774997848B5B42BEC655768F8C9279F@SHSMSX104.ccr.corp.intel.com \
    --to=jingjing.wu@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).