[dpdk-dev] [PATCH] app test: fix mempool cache_size not match limited cache_size

[dpdk-dev] [PATCH] app test: fix mempool cache_size not match limited cache_size

[Yong Liu]

From: Marvin Liu <yong.liu@intel.com>

In previous setting, mempool size and cache_size are both 32.
This is not satisfied with cache_size checking rule by now.
Cache size should less than CONFIG_RTE_MEMPOOL_CACHE_MAX_SIZE and mempool size / 1.5.

Signed-off-by: Marvin Liu <yong.liu@intel.com>

diff --git a/app/test/test_sched.c b/app/test/test_sched.c
index 1ef6910..7a38db3 100644
--- a/app/test/test_sched.c
+++ b/app/test/test_sched.c
@@ -87,7 +87,7 @@ static struct rte_sched_port_params port_param = {
 
 #define NB_MBUF          32
 #define MBUF_DATA_SZ     (2048 + RTE_PKTMBUF_HEADROOM)
-#define PKT_BURST_SZ     32
+#define PKT_BURST_SZ     0
 #define MEMPOOL_CACHE_SZ PKT_BURST_SZ
 #define SOCKET           0
 
-- 
1.9.3

Re: [dpdk-dev] [PATCH] app test: fix mempool cache_size not match limited cache_size

[Wu, Jingjing]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yong Liu
> Sent: Wednesday, July 29, 2015 11:22 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] app test: fix mempool cache_size not match
> limited cache_size
> 
> From: Marvin Liu <yong.liu@intel.com>
> 
> In previous setting, mempool size and cache_size are both 32.
> This is not satisfied with cache_size checking rule by now.
> Cache size should less than CONFIG_RTE_MEMPOOL_CACHE_MAX_SIZE and
> mempool size / 1.5.
> 
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
> 
Acked-by: Jingjing Wu <jingjing.wu@intel.com>

> diff --git a/app/test/test_sched.c b/app/test/test_sched.c index
> 1ef6910..7a38db3 100644
> --- a/app/test/test_sched.c
> +++ b/app/test/test_sched.c
> @@ -87,7 +87,7 @@ static struct rte_sched_port_params port_param = {
> 
>  #define NB_MBUF          32
>  #define MBUF_DATA_SZ     (2048 + RTE_PKTMBUF_HEADROOM)
> -#define PKT_BURST_SZ     32
> +#define PKT_BURST_SZ     0
>  #define MEMPOOL_CACHE_SZ PKT_BURST_SZ
>  #define SOCKET           0
> 
> --
> 1.9.3

Re: [dpdk-dev] [PATCH] app test: fix mempool cache_size not match limited cache_size

[Thomas Monjalon]

2015-07-29 11:22, Yong Liu:
> In previous setting, mempool size and cache_size are both 32.
> This is not satisfied with cache_size checking rule by now.
> Cache size should less than CONFIG_RTE_MEMPOOL_CACHE_MAX_SIZE and mempool size / 1.5.

Sorry I don't really understand this explanation.

>  #define NB_MBUF          32
>  #define MBUF_DATA_SZ     (2048 + RTE_PKTMBUF_HEADROOM)
> -#define PKT_BURST_SZ     32
> +#define PKT_BURST_SZ     0
>  #define MEMPOOL_CACHE_SZ PKT_BURST_SZ

Shouldn't be MEMPOOL_CACHE_SZ to set to 0?

Re: [dpdk-dev] [PATCH] app test: fix mempool cache_size not match limited cache_size

[Liu, Yong]

Thanks Thomas.

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, August 03, 2015 5:27 AM
> To: Liu, Yong
> Cc: dev@dpdk.org; olivier.matz@6wind.com; Wu, Jingjing
> Subject: Re: [dpdk-dev] [PATCH] app test: fix mempool cache_size not match
> limited cache_size
> 
> 2015-07-29 11:22, Yong Liu:
> > In previous setting, mempool size and cache_size are both 32.
> > This is not satisfied with cache_size checking rule by now.
> > Cache size should less than CONFIG_RTE_MEMPOOL_CACHE_MAX_SIZE and
> mempool size / 1.5.
> 
> Sorry I don't really understand this explanation.
> 

This information is stripped from the description for parameter cache_size of function rte_mempool_create.
Now rte_mempool_create function will check cache_size value less than mempool size /1.5. 

In test_sched.c, mempool size and cache size are all 32 and not match mempool cache size checking rule.
This will cause sched_autotest not work. 


> >  #define NB_MBUF          32
> >  #define MBUF_DATA_SZ     (2048 + RTE_PKTMBUF_HEADROOM)
> > -#define PKT_BURST_SZ     32
> > +#define PKT_BURST_SZ     0
> >  #define MEMPOOL_CACHE_SZ PKT_BURST_SZ
> 
> Shouldn't be MEMPOOL_CACHE_SZ to set to 0?

Macro PKT_BURST_SZ not used in this file, MEMPOOL_CACHE_SZ should be set to 0.

Re: [dpdk-dev] [PATCH] app test: fix mempool cache_size not match limited cache_size

[Thomas Monjalon]

> > From: Marvin Liu <yong.liu@intel.com>
> > 
> > In previous setting, mempool size and cache_size are both 32.
> > This is not satisfied with cache_size checking rule by now.
> > Cache size should less than CONFIG_RTE_MEMPOOL_CACHE_MAX_SIZE and
> > mempool size / 1.5.
> > 
> > Signed-off-by: Marvin Liu <yong.liu@intel.com>
> > 
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>

> >  #define NB_MBUF          32
> >  #define MBUF_DATA_SZ     (2048 + RTE_PKTMBUF_HEADROOM)
> > -#define PKT_BURST_SZ     32
> > +#define PKT_BURST_SZ     0
> >  #define MEMPOOL_CACHE_SZ PKT_BURST_SZ
> >  #define SOCKET           0

Applied after removing PKT_BURST_SZ, thanks