* [dpdk-dev] [PATCH] app test: fix eal --no-huge option should work with -m option
@ 2015-07-29 4:38 Yong Liu
2015-07-30 6:08 ` Wu, Jingjing
0 siblings, 1 reply; 4+ messages in thread
From: Yong Liu @ 2015-07-29 4:38 UTC (permalink / raw)
To: dev
From: Marvin Liu <yong.liu@intel.com>
'--no-huge' option now can workable with -m option.
Unit test for eal flag should change pass criterion.
Signed-off-by: Marvin Liu <yong.liu@intel.com>
diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index 0352f87..e6f7035 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -748,8 +748,8 @@ test_no_hpet_flag(void)
}
/*
- * Test that the app runs with --no-huge and doesn't run when either
- * -m or --socket-mem are specified with --no-huge.
+ * Test that the app runs with --no-huge and doesn't run when --socket-mem are
+ * specified with --no-huge.
*/
static int
test_no_huge_flag(void)
@@ -778,8 +778,8 @@ test_no_huge_flag(void)
printf("Error - process did not run ok with --no-huge flag\n");
return -1;
}
- if (launch_proc(argv2) == 0) {
- printf("Error - process run ok with --no-huge and -m flags\n");
+ if (launch_proc(argv2) != 0) {
+ printf("Error - process did not run ok with --no-huge and -m flags\n");
return -1;
}
#ifdef RTE_EXEC_ENV_BSDAPP
--
1.9.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] app test: fix eal --no-huge option should work with -m option
2015-07-29 4:38 [dpdk-dev] [PATCH] app test: fix eal --no-huge option should work with -m option Yong Liu
@ 2015-07-30 6:08 ` Wu, Jingjing
0 siblings, 0 replies; 4+ messages in thread
From: Wu, Jingjing @ 2015-07-30 6:08 UTC (permalink / raw)
To: Liu, Yong, dev
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yong Liu
> Sent: Wednesday, July 29, 2015 12:38 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] app test: fix eal --no-huge option should work
> with -m option
>
> From: Marvin Liu <yong.liu@intel.com>
>
> '--no-huge' option now can workable with -m option.
> Unit test for eal flag should change pass criterion.
>
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
> diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c index
> 0352f87..e6f7035 100644
> --- a/app/test/test_eal_flags.c
> +++ b/app/test/test_eal_flags.c
> @@ -748,8 +748,8 @@ test_no_hpet_flag(void) }
>
> /*
> - * Test that the app runs with --no-huge and doesn't run when either
> - * -m or --socket-mem are specified with --no-huge.
> + * Test that the app runs with --no-huge and doesn't run when
> + --socket-mem are
> + * specified with --no-huge.
> */
> static int
> test_no_huge_flag(void)
> @@ -778,8 +778,8 @@ test_no_huge_flag(void)
> printf("Error - process did not run ok with --no-huge flag\n");
> return -1;
> }
> - if (launch_proc(argv2) == 0) {
> - printf("Error - process run ok with --no-huge and -m flags\n");
> + if (launch_proc(argv2) != 0) {
> + printf("Error - process did not run ok with --no-huge and -m
> +flags\n");
> return -1;
> }
> #ifdef RTE_EXEC_ENV_BSDAPP
> --
> 1.9.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] app test: fix eal --no-huge option should work with -m option
2015-07-29 3:54 Yong Liu
@ 2015-08-03 21:58 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2015-08-03 21:58 UTC (permalink / raw)
To: Yong Liu; +Cc: dev
2015-07-29 11:54, Yong Liu:
> From: Marvin Liu <yong.liu@intel.com>
>
> '--no-huge' option now can workable with -m option.
> Unit test for eal flag should change pass criterion.
>
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
Fixes: a7de7e6beb69 ("eal: allow combining -m and --no-huge")
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH] app test: fix eal --no-huge option should work with -m option
@ 2015-07-29 3:54 Yong Liu
2015-08-03 21:58 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Yong Liu @ 2015-07-29 3:54 UTC (permalink / raw)
To: dev
From: Marvin Liu <yong.liu@intel.com>
'--no-huge' option now can workable with -m option.
Unit test for eal flag should change pass criterion.
Signed-off-by: Marvin Liu <yong.liu@intel.com>
diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index 0352f87..e6f7035 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -748,8 +748,8 @@ test_no_hpet_flag(void)
}
/*
- * Test that the app runs with --no-huge and doesn't run when either
- * -m or --socket-mem are specified with --no-huge.
+ * Test that the app runs with --no-huge and doesn't run when --socket-mem are
+ * specified with --no-huge.
*/
static int
test_no_huge_flag(void)
@@ -778,8 +778,8 @@ test_no_huge_flag(void)
printf("Error - process did not run ok with --no-huge flag\n");
return -1;
}
- if (launch_proc(argv2) == 0) {
- printf("Error - process run ok with --no-huge and -m flags\n");
+ if (launch_proc(argv2) != 0) {
+ printf("Error - process did not run ok with --no-huge and -m flags\n");
return -1;
}
#ifdef RTE_EXEC_ENV_BSDAPP
--
1.9.3
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-08-03 21:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-29 4:38 [dpdk-dev] [PATCH] app test: fix eal --no-huge option should work with -m option Yong Liu
2015-07-30 6:08 ` Wu, Jingjing
-- strict thread matches above, loose matches on Subject: below --
2015-07-29 3:54 Yong Liu
2015-08-03 21:58 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).