* [dpdk-dev] [PATCH] ixgbe: fix the wrong prompt for VF TSO
@ 2015-09-11 2:00 Wenzhuo Lu
2015-10-14 8:29 ` Wu, Jingjing
0 siblings, 1 reply; 3+ messages in thread
From: Wenzhuo Lu @ 2015-09-11 2:00 UTC (permalink / raw)
To: dev
When setting TSO on VF ixgbe NICs, for example, 82599, x550, the
prompt that TSO is not supported will be printed. But TSO is
supported by VF ixgbe NICs.
We should add TSO to the capability flag, so, we will not see the
wrong prompt.
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index b8ee1e9..23eeacc 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -2444,7 +2444,8 @@ ixgbevf_dev_info_get(struct rte_eth_dev *dev,
DEV_TX_OFFLOAD_IPV4_CKSUM |
DEV_TX_OFFLOAD_UDP_CKSUM |
DEV_TX_OFFLOAD_TCP_CKSUM |
- DEV_TX_OFFLOAD_SCTP_CKSUM;
+ DEV_TX_OFFLOAD_SCTP_CKSUM |
+ DEV_TX_OFFLOAD_TCP_TSO;
dev_info->default_rxconf = (struct rte_eth_rxconf) {
.rx_thresh = {
--
1.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] ixgbe: fix the wrong prompt for VF TSO
2015-09-11 2:00 [dpdk-dev] [PATCH] ixgbe: fix the wrong prompt for VF TSO Wenzhuo Lu
@ 2015-10-14 8:29 ` Wu, Jingjing
2015-10-28 13:18 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Wu, Jingjing @ 2015-10-14 8:29 UTC (permalink / raw)
To: Lu, Wenzhuo, dev
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> Sent: Friday, September 11, 2015 10:00 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] ixgbe: fix the wrong prompt for VF TSO
>
> When setting TSO on VF ixgbe NICs, for example, 82599, x550, the prompt
> that TSO is not supported will be printed. But TSO is supported by VF ixgbe
> NICs.
> We should add TSO to the capability flag, so, we will not see the wrong
> prompt.
>
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index b8ee1e9..23eeacc 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2444,7 +2444,8 @@ ixgbevf_dev_info_get(struct rte_eth_dev *dev,
> DEV_TX_OFFLOAD_IPV4_CKSUM |
> DEV_TX_OFFLOAD_UDP_CKSUM |
> DEV_TX_OFFLOAD_TCP_CKSUM |
> - DEV_TX_OFFLOAD_SCTP_CKSUM;
> + DEV_TX_OFFLOAD_SCTP_CKSUM |
> + DEV_TX_OFFLOAD_TCP_TSO;
>
> dev_info->default_rxconf = (struct rte_eth_rxconf) {
> .rx_thresh = {
> --
> 1.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] ixgbe: fix the wrong prompt for VF TSO
2015-10-14 8:29 ` Wu, Jingjing
@ 2015-10-28 13:18 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-10-28 13:18 UTC (permalink / raw)
To: Lu, Wenzhuo; +Cc: dev
> > When setting TSO on VF ixgbe NICs, for example, 82599, x550, the prompt
> > that TSO is not supported will be printed. But TSO is supported by VF ixgbe
> > NICs.
> > We should add TSO to the capability flag, so, we will not see the wrong
> > prompt.
> >
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-28 13:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-11 2:00 [dpdk-dev] [PATCH] ixgbe: fix the wrong prompt for VF TSO Wenzhuo Lu
2015-10-14 8:29 ` Wu, Jingjing
2015-10-28 13:18 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).