DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: Gareth Bradshaw <gareth@vectra.ai>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] RSS hashing support on ixgbevf
Date: Mon, 25 Feb 2019 02:28:35 +0000	[thread overview]
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA07EB705C@PGSMSX103.gar.corp.intel.com> (raw)
In-Reply-To: <BYAPR08MB4951652D2A75701D5FBD0636C67F0@BYAPR08MB4951.namprd08.prod.outlook.com>

Hi, Gareth Bradshaw

   What you said is not a missing or code bug, because ixgbe do not support vf port to config his own RSS hash type.
It is control by his pf host, it has the same hash type enable configuration as his pf host, so we do not need to expose
That in vf code by " dev_info->flow_type_rss_offloads = IXGBE_RSS_OFFLOAD_ALL; " in ixgbevf_dev_info_get.
But you can make a reference of i40evf_dev_info_get(), it has " dev_info->flow_type_rss_offloads = ...........", that because 
I40evf can control his own hash type, and not related to his pf host.
These NICs are different in this point.

  
  

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Gareth Bradshaw
> Sent: Friday, February 22, 2019 8:01 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] RSS hashing support on ixgbevf
> 
> Hi all,
> 
> Does the IXGBE PMD support RSS in the VF?  The value of
> "dev_info.flow_type_rss_offloads" is 0 for ixgbevf_dev_info_get and
> triggers the "invalid argument" check added to rte_eth_dev_configure
> (@line 1243).
> 
> The PF equivalent (ixbge_dev_info_get) sets flow_type_rss_offloads to
> IXGBE_RSS_OFFLOAD_ALL.
> 
> Wondering if it's just a missing field in dev_info as the eth_dev_ops struct for
> IXBGEVF exposes the same RSS ops as the PF:
> 
> static const struct eth_dev_ops ixgbevf_eth_dev_ops = {
>               ...
> .reta_update                   = ixgbe_dev_rss_reta_update,
>               .reta_query                      = ixgbe_dev_rss_reta_query,
>               .rss_hash_update            = ixgbe_dev_rss_hash_update,
>               .rss_hash_update            = ixgbe_dev_rss_hash_update,
>               .rss_hash_conf_get         = ixgbe_dev_rss_hash_conf_get,
>               .rss_hash_conf_get         = ixgbe_dev_rss_hash_conf_get,
>               };
> 
> Thanks
> Gareth
> 
> 
> Technology Strategist
> Vectra.AI

      reply	other threads:[~2019-02-25  2:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-22 12:01 Gareth Bradshaw
2019-02-25  2:28 ` Zhao1, Wei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A2573D2ACFCADC41BB3BE09C6DE313CA07EB705C@PGSMSX103.gar.corp.intel.com \
    --to=wei.zhao1@intel.com \
    --cc=dev@dpdk.org \
    --cc=gareth@vectra.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).