DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] RSS hashing support on ixgbevf
@ 2019-02-22 12:01 Gareth Bradshaw
  2019-02-25  2:28 ` Zhao1, Wei
  0 siblings, 1 reply; 2+ messages in thread
From: Gareth Bradshaw @ 2019-02-22 12:01 UTC (permalink / raw)
  To: dev

Hi all,

Does the IXGBE PMD support RSS in the VF?  The value of "dev_info.flow_type_rss_offloads" is 0 for ixgbevf_dev_info_get and triggers the "invalid argument" check added to rte_eth_dev_configure (@line 1243).

The PF equivalent (ixbge_dev_info_get) sets flow_type_rss_offloads to IXGBE_RSS_OFFLOAD_ALL.

Wondering if it's just a missing field in dev_info as the eth_dev_ops struct for IXBGEVF exposes the same RSS ops as the PF:

static const struct eth_dev_ops ixgbevf_eth_dev_ops = {
              ...
.reta_update                   = ixgbe_dev_rss_reta_update,
              .reta_query                      = ixgbe_dev_rss_reta_query,
              .rss_hash_update            = ixgbe_dev_rss_hash_update,
              .rss_hash_update            = ixgbe_dev_rss_hash_update,
              .rss_hash_conf_get         = ixgbe_dev_rss_hash_conf_get,
              .rss_hash_conf_get         = ixgbe_dev_rss_hash_conf_get,
              };

Thanks
Gareth


Technology Strategist
Vectra.AI

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] RSS hashing support on ixgbevf
  2019-02-22 12:01 [dpdk-dev] RSS hashing support on ixgbevf Gareth Bradshaw
@ 2019-02-25  2:28 ` Zhao1, Wei
  0 siblings, 0 replies; 2+ messages in thread
From: Zhao1, Wei @ 2019-02-25  2:28 UTC (permalink / raw)
  To: Gareth Bradshaw, dev

Hi, Gareth Bradshaw

   What you said is not a missing or code bug, because ixgbe do not support vf port to config his own RSS hash type.
It is control by his pf host, it has the same hash type enable configuration as his pf host, so we do not need to expose
That in vf code by " dev_info->flow_type_rss_offloads = IXGBE_RSS_OFFLOAD_ALL; " in ixgbevf_dev_info_get.
But you can make a reference of i40evf_dev_info_get(), it has " dev_info->flow_type_rss_offloads = ...........", that because 
I40evf can control his own hash type, and not related to his pf host.
These NICs are different in this point.

  
  

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Gareth Bradshaw
> Sent: Friday, February 22, 2019 8:01 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] RSS hashing support on ixgbevf
> 
> Hi all,
> 
> Does the IXGBE PMD support RSS in the VF?  The value of
> "dev_info.flow_type_rss_offloads" is 0 for ixgbevf_dev_info_get and
> triggers the "invalid argument" check added to rte_eth_dev_configure
> (@line 1243).
> 
> The PF equivalent (ixbge_dev_info_get) sets flow_type_rss_offloads to
> IXGBE_RSS_OFFLOAD_ALL.
> 
> Wondering if it's just a missing field in dev_info as the eth_dev_ops struct for
> IXBGEVF exposes the same RSS ops as the PF:
> 
> static const struct eth_dev_ops ixgbevf_eth_dev_ops = {
>               ...
> .reta_update                   = ixgbe_dev_rss_reta_update,
>               .reta_query                      = ixgbe_dev_rss_reta_query,
>               .rss_hash_update            = ixgbe_dev_rss_hash_update,
>               .rss_hash_update            = ixgbe_dev_rss_hash_update,
>               .rss_hash_conf_get         = ixgbe_dev_rss_hash_conf_get,
>               .rss_hash_conf_get         = ixgbe_dev_rss_hash_conf_get,
>               };
> 
> Thanks
> Gareth
> 
> 
> Technology Strategist
> Vectra.AI

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-02-25  2:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-22 12:01 [dpdk-dev] RSS hashing support on ixgbevf Gareth Bradshaw
2019-02-25  2:28 ` Zhao1, Wei

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).