From: Ophir Munk <ophirmu@mellanox.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Pascal Mazon <pascal.mazon@6wind.com>,
"Olga Shern" <olgas@mellanox.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v1] net/tap: fix CRC stripping capability report
Date: Mon, 12 Feb 2018 22:34:55 +0000 [thread overview]
Message-ID: <AM6PR0502MB3877D3C8947746F6E6A1B9A8D1F70@AM6PR0502MB3877.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <5072632.Aql229SuCI@xps>
Will issue v2 with commit message updated
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, February 12, 2018 7:55 PM
> To: Ophir Munk <ophirmu@mellanox.com>
> Cc: dev@dpdk.org; Pascal Mazon <pascal.mazon@6wind.com>; Olga Shern
> <olgas@mellanox.com>
> Subject: Re: [dpdk-stable] [PATCH v1] net/tap: fix CRC stripping capability
> report
>
> The title should be "add CRC stripping capability".
>
> 12/02/2018 15:43, Ophir Munk:
> > CRC stripping is executed outside of TAP PMD scope. There is no
> > prevention that TAP reports on Rx CRC stripping capability.
>
> We could mention that the CRC stripping is done in the kernel.
>
> > It is especially required when TAP is operating as failsafe sub-device
> > with another PCI sub-device which supports CRC stripping.
> > In the corrupted code TAP did not report on this capability which
> > caused failsafe to not report on it as well.
>
> You discover the bug with failsafe but it is not related at all.
> I think you squeeze this part of the explanation.
>
> > The fix is for TAP to report that Rx CRC stripping is supported.
> >
> > Fixes: 95ae196ae10b ("net/tap: use new Rx offloads API")
>
> I don't think it is a root cause.
> This capability is missing from day one:
> Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD")
>
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
prev parent reply other threads:[~2018-02-12 22:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 14:43 [dpdk-dev] " Ophir Munk
2018-02-12 17:55 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-02-12 22:34 ` Ophir Munk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR0502MB3877D3C8947746F6E6A1B9A8D1F70@AM6PR0502MB3877.eurprd05.prod.outlook.com \
--to=ophirmu@mellanox.com \
--cc=dev@dpdk.org \
--cc=olgas@mellanox.com \
--cc=pascal.mazon@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).