[dpdk-dev] [PATCH] doc: add deprecation note for rework of PCI in EAL

[dpdk-dev] [PATCH] doc: add deprecation note for rework of PCI in EAL

[Shreyansh Jain]

EAL PCI layer is planned to be restructured in 17.05 to unlink it from
generic structures like eth_driver, rte_cryptodev_driver, and also move
it into a PCI Bus.

Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
 doc/guides/rel_notes/deprecation.rst | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index fbe2fcb..b12d435 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -13,10 +13,14 @@ Deprecation Notices
   has exposed, like the way we have done with uio-pci-generic. This change
   targets release 17.05.
 
-* ``eth_driver`` is planned to be removed in 17.02. This currently serves as
-  a placeholder for PMDs to register themselves. Changes for ``rte_bus`` will
-  provide a way to handle device initialization currently being done in
-  ``eth_driver``.
+* ABI/API changes are planned for 17.05 for PCI subsystem. This is to
+  unlink EAL dependency on PCI and to move PCI devices to a PCI specific
+  bus.
+
+* ``rte_pci_driver`` is planned to be removed from ``eth_driver`` in 17.05.
+  This is to unlink the ethernet driver from PCI dependencies.
+  Similarly, ``rte_pci_driver`` in planned to be removed from
+  ``rte_cryptodev_driver`` in 17.05.
 
 * In 17.02 ABI changes are planned: the ``rte_eth_dev`` structure will be
   extended with new function pointer ``tx_pkt_prepare`` allowing verification
-- 
2.7.4

Re: [dpdk-dev] [PATCH] doc: add deprecation note for rework of PCI in EAL

[Shreyansh Jain]

On Monday 13 February 2017 05:25 PM, Shreyansh Jain wrote:
> EAL PCI layer is planned to be restructured in 17.05 to unlink it from
> generic structures like eth_driver, rte_cryptodev_driver, and also move
> it into a PCI Bus.
>
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index fbe2fcb..b12d435 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -13,10 +13,14 @@ Deprecation Notices
>    has exposed, like the way we have done with uio-pci-generic. This change
>    targets release 17.05.
>
> -* ``eth_driver`` is planned to be removed in 17.02. This currently serves as
> -  a placeholder for PMDs to register themselves. Changes for ``rte_bus`` will
> -  provide a way to handle device initialization currently being done in
> -  ``eth_driver``.

Just to highlight, above statement was added by me in 16.11.
As of now I plan to work on removing rte_pci_driver from eth_driver,
rather than removing eth_driver all together (which, probably, was
better idea).
If someone still wishes to work on its complete removal, we can keep
the above. (and probably remove the below).

> +* ABI/API changes are planned for 17.05 for PCI subsystem. This is to
> +  unlink EAL dependency on PCI and to move PCI devices to a PCI specific
> +  bus.
> +
> +* ``rte_pci_driver`` is planned to be removed from ``eth_driver`` in 17.05.
> +  This is to unlink the ethernet driver from PCI dependencies.
> +  Similarly, ``rte_pci_driver`` in planned to be removed from
> +  ``rte_cryptodev_driver`` in 17.05.
>
>  * In 17.02 ABI changes are planned: the ``rte_eth_dev`` structure will be
>    extended with new function pointer ``tx_pkt_prepare`` allowing verification
>

Re: [dpdk-dev] [PATCH] doc: add deprecation note for rework of PCI in EAL

[Thomas Monjalon]

2017-02-13 17:30, Shreyansh Jain:
> On Monday 13 February 2017 05:25 PM, Shreyansh Jain wrote:
> > EAL PCI layer is planned to be restructured in 17.05 to unlink it from
> > generic structures like eth_driver, rte_cryptodev_driver, and also move
> > it into a PCI Bus.
> >
> > Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> > ---
> >  doc/guides/rel_notes/deprecation.rst | 12 ++++++++----
> >  1 file changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> > index fbe2fcb..b12d435 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -13,10 +13,14 @@ Deprecation Notices
> >    has exposed, like the way we have done with uio-pci-generic. This change
> >    targets release 17.05.
> >
> > -* ``eth_driver`` is planned to be removed in 17.02. This currently serves as
> > -  a placeholder for PMDs to register themselves. Changes for ``rte_bus`` will
> > -  provide a way to handle device initialization currently being done in
> > -  ``eth_driver``.
> 
> Just to highlight, above statement was added by me in 16.11.
> As of now I plan to work on removing rte_pci_driver from eth_driver,
> rather than removing eth_driver all together (which, probably, was
> better idea).
> If someone still wishes to work on its complete removal, we can keep
> the above. (and probably remove the below).

Yes I think we should keep the original idea.
I will work on it with Jan Blunck and Stephen Hemminger I think.

> > +* ABI/API changes are planned for 17.05 for PCI subsystem. This is to
> > +  unlink EAL dependency on PCI and to move PCI devices to a PCI specific
> > +  bus.
> > +
> > +* ``rte_pci_driver`` is planned to be removed from ``eth_driver`` in 17.05.
> > +  This is to unlink the ethernet driver from PCI dependencies.
> > +  Similarly, ``rte_pci_driver`` in planned to be removed from
> > +  ``rte_cryptodev_driver`` in 17.05.

I am going to reword it in a v2.

[dpdk-dev] [PATCH v2] doc: announce API changes to implement the bus model

[Thomas Monjalon]

The new bus model has been proposed in 17.02 without being used.
The big rework should happen in 17.05.

Suggested-by: Shreyansh Jain <shreyansh.jain@nxp.com>
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 doc/guides/rel_notes/deprecation.rst | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index f0b5329..8b66407 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -13,10 +13,14 @@ Deprecation Notices
   has exposed, like the way we have done with uio-pci-generic. This change
   targets release 17.05.
 
-* ``eth_driver`` is planned to be removed in 17.02. This currently serves as
+* The PCI and VDEV subsystems will be converted as drivers of the new bus model.
+  It will imply some EAL API changes in 17.05.
+
+* ``eth_driver`` is planned to be removed in 17.05. This currently serves as
   a placeholder for PMDs to register themselves. Changes for ``rte_bus`` will
   provide a way to handle device initialization currently being done in
-  ``eth_driver``.
+  ``eth_driver``. Similarly, ``rte_pci_driver`` is planned to be removed from
+  ``rte_cryptodev_driver`` in 17.05.
 
 * ethdev: an API change is planned for 17.02 for the function
   ``_rte_eth_dev_callback_process``. In 17.02 the function will return an ``int``
-- 
2.7.0

Re: [dpdk-dev] [PATCH v2] doc: announce API changes to implement the bus model

[Jan Blunck]

On Mon, Feb 13, 2017 at 5:20 PM, Thomas Monjalon
<thomas.monjalon@6wind.com> wrote:
> The new bus model has been proposed in 17.02 without being used.
> The big rework should happen in 17.05.
>
> Suggested-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index f0b5329..8b66407 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -13,10 +13,14 @@ Deprecation Notices
>    has exposed, like the way we have done with uio-pci-generic. This change
>    targets release 17.05.
>
> -* ``eth_driver`` is planned to be removed in 17.02. This currently serves as
> +* The PCI and VDEV subsystems will be converted as drivers of the new bus model.
> +  It will imply some EAL API changes in 17.05.
> +
> +* ``eth_driver`` is planned to be removed in 17.05. This currently serves as
>    a placeholder for PMDs to register themselves. Changes for ``rte_bus`` will
>    provide a way to handle device initialization currently being done in
> -  ``eth_driver``.
> +  ``eth_driver``. Similarly, ``rte_pci_driver`` is planned to be removed from
> +  ``rte_cryptodev_driver`` in 17.05.
>
>  * ethdev: an API change is planned for 17.02 for the function
>    ``_rte_eth_dev_callback_process``. In 17.02 the function will return an ``int``
> --
> 2.7.0
>

Acked-by: Jan Blunck <jblunck@infradead.org>

Re: [dpdk-dev] [PATCH] doc: add deprecation note for rework of PCI in EAL

[Jan Blunck]

On Mon, Feb 13, 2017 at 1:00 PM, Shreyansh Jain <shreyansh.jain@nxp.com> wrote:
> On Monday 13 February 2017 05:25 PM, Shreyansh Jain wrote:
>>
>> EAL PCI layer is planned to be restructured in 17.05 to unlink it from
>> generic structures like eth_driver, rte_cryptodev_driver, and also move
>> it into a PCI Bus.
>>
>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
>> ---
>>  doc/guides/rel_notes/deprecation.rst | 12 ++++++++----
>>  1 file changed, 8 insertions(+), 4 deletions(-)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst
>> b/doc/guides/rel_notes/deprecation.rst
>> index fbe2fcb..b12d435 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -13,10 +13,14 @@ Deprecation Notices
>>    has exposed, like the way we have done with uio-pci-generic. This
>> change
>>    targets release 17.05.
>>
>> -* ``eth_driver`` is planned to be removed in 17.02. This currently serves
>> as
>> -  a placeholder for PMDs to register themselves. Changes for ``rte_bus``
>> will
>> -  provide a way to handle device initialization currently being done in
>> -  ``eth_driver``.
>
>
> Just to highlight, above statement was added by me in 16.11.
> As of now I plan to work on removing rte_pci_driver from eth_driver,
> rather than removing eth_driver all together (which, probably, was
> better idea).
> If someone still wishes to work on its complete removal, we can keep
> the above. (and probably remove the below).
>

There is no benefit in keeping eth_driver and removing rte_pci_driver
from it. Technically it isn't even needed today.

>
>> +* ABI/API changes are planned for 17.05 for PCI subsystem. This is to
>> +  unlink EAL dependency on PCI and to move PCI devices to a PCI specific
>> +  bus.
>> +
>> +* ``rte_pci_driver`` is planned to be removed from ``eth_driver`` in
>> 17.05.
>> +  This is to unlink the ethernet driver from PCI dependencies.
>> +  Similarly, ``rte_pci_driver`` in planned to be removed from
>> +  ``rte_cryptodev_driver`` in 17.05.
>>
>>  * In 17.02 ABI changes are planned: the ``rte_eth_dev`` structure will be
>>    extended with new function pointer ``tx_pkt_prepare`` allowing
>> verification
>>
>

Re: [dpdk-dev] [PATCH v2] doc: announce API changes to implement the bus model

[Hemant Agrawal]

On 2/13/2017 3:53 PM, Jan Blunck wrote:
> On Mon, Feb 13, 2017 at 5:20 PM, Thomas Monjalon
> <thomas.monjalon@6wind.com> wrote:
>> The new bus model has been proposed in 17.02 without being used.
>> The big rework should happen in 17.05.
>>
>> Suggested-by: Shreyansh Jain <shreyansh.jain@nxp.com>
>> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
>> ---
>>  doc/guides/rel_notes/deprecation.rst | 8 ++++++--
>>  1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
>> index f0b5329..8b66407 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -13,10 +13,14 @@ Deprecation Notices
>>    has exposed, like the way we have done with uio-pci-generic. This change
>>    targets release 17.05.
>>
>> -* ``eth_driver`` is planned to be removed in 17.02. This currently serves as
>> +* The PCI and VDEV subsystems will be converted as drivers of the new bus model.
>> +  It will imply some EAL API changes in 17.05.
>> +
>> +* ``eth_driver`` is planned to be removed in 17.05. This currently serves as
>>    a placeholder for PMDs to register themselves. Changes for ``rte_bus`` will
>>    provide a way to handle device initialization currently being done in
>> -  ``eth_driver``.
>> +  ``eth_driver``. Similarly, ``rte_pci_driver`` is planned to be removed from
>> +  ``rte_cryptodev_driver`` in 17.05.
>>
>>  * ethdev: an API change is planned for 17.02 for the function
>>    ``_rte_eth_dev_callback_process``. In 17.02 the function will return an ``int``
>> --
>> 2.7.0
>>
>
> Acked-by: Jan Blunck <jblunck@infradead.org>
>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Re: [dpdk-dev] [PATCH v2] doc: announce API changes to implement the bus model

[Mcnamara, John]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Monday, February 13, 2017 4:21 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] doc: announce API changes to implement the
> bus model
> 
> The new bus model has been proposed in 17.02 without being used.
> The big rework should happen in 17.05.
> 
> Suggested-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Acked-by: John McNamara <john.mcnamara@intel.com>

Re: [dpdk-dev] [PATCH] doc: add deprecation note for rework of PCI in EAL

[Shreyansh Jain]

On Tuesday 14 February 2017 03:26 AM, Jan Blunck wrote:
> On Mon, Feb 13, 2017 at 1:00 PM, Shreyansh Jain <shreyansh.jain@nxp.com> wrote:
>> On Monday 13 February 2017 05:25 PM, Shreyansh Jain wrote:
>>>
>>> EAL PCI layer is planned to be restructured in 17.05 to unlink it from
>>> generic structures like eth_driver, rte_cryptodev_driver, and also move
>>> it into a PCI Bus.
>>>
>>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
>>> ---
>>>  doc/guides/rel_notes/deprecation.rst | 12 ++++++++----
>>>  1 file changed, 8 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/doc/guides/rel_notes/deprecation.rst
>>> b/doc/guides/rel_notes/deprecation.rst
>>> index fbe2fcb..b12d435 100644
>>> --- a/doc/guides/rel_notes/deprecation.rst
>>> +++ b/doc/guides/rel_notes/deprecation.rst
>>> @@ -13,10 +13,14 @@ Deprecation Notices
>>>    has exposed, like the way we have done with uio-pci-generic. This
>>> change
>>>    targets release 17.05.
>>>
>>> -* ``eth_driver`` is planned to be removed in 17.02. This currently serves
>>> as
>>> -  a placeholder for PMDs to register themselves. Changes for ``rte_bus``
>>> will
>>> -  provide a way to handle device initialization currently being done in
>>> -  ``eth_driver``.
>>
>>
>> Just to highlight, above statement was added by me in 16.11.
>> As of now I plan to work on removing rte_pci_driver from eth_driver,
>> rather than removing eth_driver all together (which, probably, was
>> better idea).
>> If someone still wishes to work on its complete removal, we can keep
>> the above. (and probably remove the below).
>>
>
> There is no benefit in keeping eth_driver and removing rte_pci_driver
> from it. Technically it isn't even needed today.

I agree with you.
I stopped working on it because I realized that removing it means making
pci_probe call eth_dev_init handlers directly. Or, restructure the whole
of pci probe stack - which, because of pending PCI bus implementation,
was slightly tentative.

Changes are already expected in EAL PCI code for bus movement, probably
this task can be combined with that.

>
>>
>>> +* ABI/API changes are planned for 17.05 for PCI subsystem. This is to
>>> +  unlink EAL dependency on PCI and to move PCI devices to a PCI specific
>>> +  bus.
>>> +
>>> +* ``rte_pci_driver`` is planned to be removed from ``eth_driver`` in
>>> 17.05.
>>> +  This is to unlink the ethernet driver from PCI dependencies.
>>> +  Similarly, ``rte_pci_driver`` in planned to be removed from
>>> +  ``rte_cryptodev_driver`` in 17.05.
>>>
>>>  * In 17.02 ABI changes are planned: the ``rte_eth_dev`` structure will be
>>>    extended with new function pointer ``tx_pkt_prepare`` allowing
>>> verification
>>>
>>
>

Re: [dpdk-dev] [PATCH v2] doc: announce API changes to implement the bus model

[Thomas Monjalon]

Applied