Re: [dpdk-dev] [v4 3/3] EM config file read option.

["Mcnamara, John" <john.mcnamara@intel.com>]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ravi Kerur
> Sent: Sunday, March 5, 2017 7:47 PM
> To: dev@dpdk.org
> Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; Ravi Kerur <rkerur@gmail.com>
> Subject: [dpdk-dev] [v4 3/3] EM config file read option.
> 
> v4:
> 	> No changes.
> 
> v3:
> 	> Fix additional checkpatch coding style issues.
> 
> v2:
> 	> Fix checkpatch warnings.
> 
> v1:
> 	> Remove static array configuration of Dest IP,Src IP, Dest
> 		port, Src port, Proto and IF_OUT for EM and EM6 config.
> 	> Add reading configuration from a file.
> 	> Format of configuration file is as follows
> 		#EM route entries,
> 		#Dest-IP Src-IP Dest-port Src-port Proto IF_OUT
> 		E101.0.0.0 100.10.0.0 101 11 0x06 0
> 		E201.0.0.0 200.20.0.0 102 12 0x06 1
> 		E111.0.0.0 211.30.0.0 101 11 0x06 2
> 		...
> 
> 		#EM6 route entries
> 		#Dest-IP Src-IP Dest-port Src-port Proto IF_OUT
> 		Efe80:0000:0000:0000:021e:67ff:fe00:0000
> 			fe80:0000:0000:0000:021b:21ff:fe91:3805 101 11 0x06 0
> 		Efe90:0000:0000:0000:021e:67ff:fe00:0000
> 			fe90:0000:0000:0000:021b:21ff:fe91:3805 102 12 0x06 1
>                 ...

Hi Ravi,

Just a note on the structure of the commit message for this and the other
patches. The first thing to do if you are new to contributing to DPDK is
to have a read through the guidelines on "Contributing Code to DPDK":

   http://dpdk.org/doc/guides/contributing/patches.html

In particular the subject line should contain the component that is being
modified. Something like:

    examples/l3fwd: add config file support for exact match

Do a git log examples/l3fwd to see some other examples and have a look at
the following "Commit Messages: Subject Line" section of the above guidelines

    http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-subject-line

The body of the message should contain a short description of what you are changing,
at a high level, and why you are changing it. See also:

    http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-body

The version information in your commit message is good but that should be included
after the --- line so that it is part of the patch but not part of the commit
message.

John.