* [dpdk-dev] [PATCH] mk: add silvermont to replace atom as a target
@ 2017-09-08 3:28 Xiaoyun Li
2017-09-08 9:07 ` Bruce Richardson
0 siblings, 1 reply; 4+ messages in thread
From: Xiaoyun Li @ 2017-09-08 3:28 UTC (permalink / raw)
To: bruce.richardson; +Cc: dev, helin.zhang, Xiaoyun Li
The -march=atom flag is for older atom CPUs and don't support SSE4 which
is the minimum reqiurement for DPDK. And in fact, the current atom CPUs
support SSE4. So this patch removes atom as a target for DPDK builds and
adds a silvermont replacement instead.
Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
---
mk/machine/atm/rte.vars.mk | 58 ---------------------------------------
mk/machine/silvermont/rte.vars.mk | 58 +++++++++++++++++++++++++++++++++++++++
2 files changed, 58 insertions(+), 58 deletions(-)
delete mode 100644 mk/machine/atm/rte.vars.mk
create mode 100644 mk/machine/silvermont/rte.vars.mk
diff --git a/mk/machine/atm/rte.vars.mk b/mk/machine/atm/rte.vars.mk
deleted file mode 100644
index cfed110..0000000
--- a/mk/machine/atm/rte.vars.mk
+++ /dev/null
@@ -1,58 +0,0 @@
-# BSD LICENSE
-#
-# Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
-# All rights reserved.
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions
-# are met:
-#
-# * Redistributions of source code must retain the above copyright
-# notice, this list of conditions and the following disclaimer.
-# * Redistributions in binary form must reproduce the above copyright
-# notice, this list of conditions and the following disclaimer in
-# the documentation and/or other materials provided with the
-# distribution.
-# * Neither the name of Intel Corporation nor the names of its
-# contributors may be used to endorse or promote products derived
-# from this software without specific prior written permission.
-#
-# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-#
-# machine:
-#
-# - can define ARCH variable (overridden by cmdline value)
-# - can define CROSS variable (overridden by cmdline value)
-# - define MACHINE_CFLAGS variable (overridden by cmdline value)
-# - define MACHINE_LDFLAGS variable (overridden by cmdline value)
-# - define MACHINE_ASFLAGS variable (overridden by cmdline value)
-# - can define CPU_CFLAGS variable (overridden by cmdline value) that
-# overrides the one defined in arch.
-# - can define CPU_LDFLAGS variable (overridden by cmdline value) that
-# overrides the one defined in arch.
-# - can define CPU_ASFLAGS variable (overridden by cmdline value) that
-# overrides the one defined in arch.
-# - may override any previously defined variable
-#
-
-# ARCH =
-# CROSS =
-# MACHINE_CFLAGS =
-# MACHINE_LDFLAGS =
-# MACHINE_ASFLAGS =
-# CPU_CFLAGS =
-# CPU_LDFLAGS =
-# CPU_ASFLAGS =
-
-MACHINE_CFLAGS = -march=atom
diff --git a/mk/machine/silvermont/rte.vars.mk b/mk/machine/silvermont/rte.vars.mk
new file mode 100644
index 0000000..2079d54
--- /dev/null
+++ b/mk/machine/silvermont/rte.vars.mk
@@ -0,0 +1,58 @@
+# BSD LICENSE
+#
+# Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
+# All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+#
+# * Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# * Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in
+# the documentation and/or other materials provided with the
+# distribution.
+# * Neither the name of Intel Corporation nor the names of its
+# contributors may be used to endorse or promote products derived
+# from this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+#
+# machine:
+#
+# - can define ARCH variable (overridden by cmdline value)
+# - can define CROSS variable (overridden by cmdline value)
+# - define MACHINE_CFLAGS variable (overridden by cmdline value)
+# - define MACHINE_LDFLAGS variable (overridden by cmdline value)
+# - define MACHINE_ASFLAGS variable (overridden by cmdline value)
+# - can define CPU_CFLAGS variable (overridden by cmdline value) that
+# overrides the one defined in arch.
+# - can define CPU_LDFLAGS variable (overridden by cmdline value) that
+# overrides the one defined in arch.
+# - can define CPU_ASFLAGS variable (overridden by cmdline value) that
+# overrides the one defined in arch.
+# - may override any previously defined variable
+#
+
+# ARCH =
+# CROSS =
+# MACHINE_CFLAGS =
+# MACHINE_LDFLAGS =
+# MACHINE_ASFLAGS =
+# CPU_CFLAGS =
+# CPU_LDFLAGS =
+# CPU_ASFLAGS =
+
+MACHINE_CFLAGS = -march=silvermont
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] mk: add silvermont to replace atom as a target
2017-09-08 3:28 [dpdk-dev] [PATCH] mk: add silvermont to replace atom as a target Xiaoyun Li
@ 2017-09-08 9:07 ` Bruce Richardson
2017-09-11 2:06 ` Li, Xiaoyun
2017-10-02 21:37 ` Ferruh Yigit
0 siblings, 2 replies; 4+ messages in thread
From: Bruce Richardson @ 2017-09-08 9:07 UTC (permalink / raw)
To: Xiaoyun Li; +Cc: dev, helin.zhang
On Fri, Sep 08, 2017 at 11:28:52AM +0800, Xiaoyun Li wrote:
> The -march=atom flag is for older atom CPUs and don't support SSE4 which
> is the minimum reqiurement for DPDK. And in fact, the current atom CPUs
> support SSE4. So this patch removes atom as a target for DPDK builds and
> adds a silvermont replacement instead.
>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> ---
Ideally this should be posted as a v2 replacing the previous patch
solution you proposed so that it's threaded with that email discussion.
However, that doesn't affect the patch itself which looks reasonable.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] mk: add silvermont to replace atom as a target
2017-09-08 9:07 ` Bruce Richardson
@ 2017-09-11 2:06 ` Li, Xiaoyun
2017-10-02 21:37 ` Ferruh Yigit
1 sibling, 0 replies; 4+ messages in thread
From: Li, Xiaoyun @ 2017-09-11 2:06 UTC (permalink / raw)
To: Richardson, Bruce; +Cc: dev, Zhang, Helin
Sorry about that, but can link it manually.
The discussion can be seen on: https://www.mail-archive.com/dev@dpdk.org/msg74600.html
-----Original Message-----
From: Richardson, Bruce
Sent: Friday, September 8, 2017 17:07
To: Li, Xiaoyun <xiaoyun.li@intel.com>
Cc: dev@dpdk.org; Zhang, Helin <helin.zhang@intel.com>
Subject: Re: [PATCH] mk: add silvermont to replace atom as a target
On Fri, Sep 08, 2017 at 11:28:52AM +0800, Xiaoyun Li wrote:
> The -march=atom flag is for older atom CPUs and don't support SSE4
> which is the minimum reqiurement for DPDK. And in fact, the current
> atom CPUs support SSE4. So this patch removes atom as a target for
> DPDK builds and adds a silvermont replacement instead.
>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> ---
Ideally this should be posted as a v2 replacing the previous patch solution you proposed so that it's threaded with that email discussion.
However, that doesn't affect the patch itself which looks reasonable.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] mk: add silvermont to replace atom as a target
2017-09-08 9:07 ` Bruce Richardson
2017-09-11 2:06 ` Li, Xiaoyun
@ 2017-10-02 21:37 ` Ferruh Yigit
1 sibling, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2017-10-02 21:37 UTC (permalink / raw)
To: Bruce Richardson, Xiaoyun Li; +Cc: dev, helin.zhang
On 9/8/2017 10:07 AM, Bruce Richardson wrote:
> On Fri, Sep 08, 2017 at 11:28:52AM +0800, Xiaoyun Li wrote:
>> The -march=atom flag is for older atom CPUs and don't support SSE4 which
>> is the minimum reqiurement for DPDK. And in fact, the current atom CPUs
>> support SSE4. So this patch removes atom as a target for DPDK builds and
>> adds a silvermont replacement instead.
>>
>> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
<...>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-02 21:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-08 3:28 [dpdk-dev] [PATCH] mk: add silvermont to replace atom as a target Xiaoyun Li
2017-09-08 9:07 ` Bruce Richardson
2017-09-11 2:06 ` Li, Xiaoyun
2017-10-02 21:37 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).