From: "Yang, Qiming" <qiming.yang@intel.com> To: "Zhang, Qi Z" <qi.z.zhang@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "Stillwell Jr, Paul M" <paul.m.stillwell.jr@intel.com> Subject: Re: [dpdk-dev] [PATCH 4/8] net/ice/base: code clean in FDIR module Date: Mon, 29 Jun 2020 02:46:09 +0000 Message-ID: <BN6PR11MB0017BF681FA3E2171CF72C5AE56E0@BN6PR11MB0017.namprd11.prod.outlook.com> (raw) In-Reply-To: <20200627150615.2233-5-qi.z.zhang@intel.com> > -----Original Message----- > From: Zhang, Qi Z <qi.z.zhang@intel.com> > Sent: Saturday, June 27, 2020 23:06 > To: Yang, Qiming <qiming.yang@intel.com> > Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Stillwell Jr, Paul M > <paul.m.stillwell.jr@intel.com> > Subject: [PATCH 4/8] net/ice/base: code clean in FDIR module > > Remove unused macro and funciton. funciton / Function > Declare no external referenced function as static. > > Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com> > --- > drivers/net/ice/base/ice_fdir.c | 23 +---------------------- > drivers/net/ice/base/ice_fdir.h | 3 --- > 2 files changed, 1 insertion(+), 25 deletions(-) > > diff --git a/drivers/net/ice/base/ice_fdir.c b/drivers/net/ice/base/ice_fdir.c > index c5a20632c..b1dc2afb7 100644 > --- a/drivers/net/ice/base/ice_fdir.c > +++ b/drivers/net/ice/base/ice_fdir.c > @@ -597,7 +597,7 @@ static const struct ice_fdir_base_pkt ice_fdir_pkt[] = { > * ice_set_dflt_val_fd_desc > * @fd_fltr_ctx: pointer to fd filter descriptor > */ > -void ice_set_dflt_val_fd_desc(struct ice_fd_fltr_desc_ctx *fd_fltr_ctx) > +static void ice_set_dflt_val_fd_desc(struct ice_fd_fltr_desc_ctx > +*fd_fltr_ctx) > { > fd_fltr_ctx->comp_q = ICE_FXD_FLTR_QW0_COMP_Q_ZERO; > fd_fltr_ctx->comp_report = > ICE_FXD_FLTR_QW0_COMP_REPORT_SW_FAIL; > @@ -1389,27 +1389,6 @@ bool ice_fdir_is_dup_fltr(struct ice_hw *hw, > struct ice_fdir_fltr *input) } > > /** > - * ice_clear_vsi_fd_table - admin command to clear FD table for a VSI > - * @hw: hardware data structure > - * @vsi_num: vsi_num (HW VSI num) > - * > - * Clears FD table entries by issuing admin command (direct, 0x0B06) > - * Must to pass valid vsi_num as returned by "AddVSI". > - */ > -enum ice_status ice_clear_vsi_fd_table(struct ice_hw *hw, u16 vsi_num) -{ > - struct ice_aqc_clear_fd_table *cmd; > - struct ice_aq_desc desc; > - > - cmd = &desc.params.clear_fd_table; > - ice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_clear_fd_table); > - cmd->clear_type = CL_FD_VM_VF_TYPE_VSI_IDX; > - > - cmd->vsi_index = CPU_TO_LE16(vsi_num); > - return ice_aq_send_cmd(hw, &desc, NULL, 0, NULL); > -} > - > -/** > * ice_clear_pf_fd_table - admin command to clear FD table for PF > * @hw: hardware data structure > * > diff --git a/drivers/net/ice/base/ice_fdir.h b/drivers/net/ice/base/ice_fdir.h > index 1f31debe6..ad3e11a5b 100644 > --- a/drivers/net/ice/base/ice_fdir.h > +++ b/drivers/net/ice/base/ice_fdir.h > @@ -17,7 +17,6 @@ > #define ICE_FDIR_TUN_PKT_OFF 50 > #define ICE_FDIR_MAX_RAW_PKT_SIZE (512 + > ICE_FDIR_TUN_PKT_OFF) > #define ICE_FDIR_BUF_FULL_MARGIN 10 > -#define ICE_FDIR_BUF_HEAD_ROOM 32 > > /* macros for offsets into packets for flow director programming */ > #define ICE_IPV4_SRC_ADDR_OFFSET 26 > @@ -222,7 +221,6 @@ struct ice_fdir_base_pkt { > > enum ice_status ice_alloc_fd_res_cntr(struct ice_hw *hw, u16 *cntr_id); > enum ice_status ice_free_fd_res_cntr(struct ice_hw *hw, u16 cntr_id); -void > ice_set_dflt_val_fd_desc(struct ice_fd_fltr_desc_ctx *fd_fltr_ctx); enum > ice_status ice_alloc_fd_guar_item(struct ice_hw *hw, u16 *cntr_id, u16 > num_fltr); enum ice_status @@ -231,7 +229,6 @@ enum ice_status > ice_alloc_fd_shrd_item(struct ice_hw *hw, u16 *cntr_id, u16 num_fltr); > enum ice_status ice_free_fd_shrd_item(struct ice_hw *hw, u16 cntr_id, > u16 num_fltr); -enum ice_status ice_clear_vsi_fd_table(struct ice_hw *hw, > u16 vsi_num); enum ice_status ice_clear_pf_fd_table(struct ice_hw *hw); > void ice_fdir_get_prgm_desc(struct ice_hw *hw, struct ice_fdir_fltr *input, > -- > 2.13.6
next prev parent reply other threads:[~2020-06-29 2:46 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-27 15:06 [dpdk-dev] [PATCH 0/8] update base code batch 3 Qi Zhang 2020-06-27 15:06 ` [dpdk-dev] [PATCH 1/8] net/ice/base: fix GTP-U inner RSS IPv4 IPv6 co-exist Qi Zhang 2020-06-27 15:06 ` [dpdk-dev] [PATCH 2/8] net/ice/base: cleanup some code style Qi Zhang 2020-06-27 15:06 ` [dpdk-dev] [PATCH 3/8] net/ice/base: move lldp function to common module Qi Zhang 2020-06-27 15:06 ` [dpdk-dev] [PATCH 4/8] net/ice/base: code clean in FDIR module Qi Zhang 2020-06-29 2:46 ` Yang, Qiming [this message] 2020-06-27 15:06 ` [dpdk-dev] [PATCH 5/8] net/ice/base: add capability list AQ function Qi Zhang 2020-06-27 15:06 ` [dpdk-dev] [PATCH 6/8] net/ice/base: split capability parse into separate functions Qi Zhang 2020-06-27 15:06 ` [dpdk-dev] [PATCH 7/8] net/ice/base: clear and free XLT entries on reset Qi Zhang 2020-06-27 15:06 ` [dpdk-dev] [PATCH 8/8] net/ice/base: update version Qi Zhang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=BN6PR11MB0017BF681FA3E2171CF72C5AE56E0@BN6PR11MB0017.namprd11.prod.outlook.com \ --to=qiming.yang@intel.com \ --cc=dev@dpdk.org \ --cc=paul.m.stillwell.jr@intel.com \ --cc=qi.z.zhang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git