DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
To: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>,
	"jerinj@marvell.com" <jerinj@marvell.com>
Cc: "Vangati, Narender" <narender.vangati@intel.com>
Subject: Re: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue
Date: Wed, 23 Sep 2020 07:10:38 +0000
Message-ID: <BN6PR11MB1827758C02A63FED478A5F12E8380@BN6PR11MB1827.namprd11.prod.outlook.com> (raw)
In-Reply-To: <VI1PR04MB316814A66A4D060D29E08C75E63B0@VI1PR04MB3168.eurprd04.prod.outlook.com>

Hi Akhil,

Recently, I observed that test was failing with sw adapter.
I noticed that, it was because of some changes went in related to crypto in the past releases.
One of the tests, configures a session in turn calls null_crypto_set_session_parameters()
which checks for params was failing. As part of fixing & updating the xforms to address this issue,
thought of getting rid of algo as well, to make the test simpler. The test continues to use null cryptodev
and does not deal with any encryption or auth.

Regards
Abhinandan

> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Wednesday, September 23, 2020 12:59 AM
> To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; dev@dpdk.org;
> jerinj@marvell.com
> Cc: Vangati, Narender <narender.vangati@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue
> 
> Hi Abhinandan,
> 
> > This patch updates the xform with right configuration.
> > For session based ops, sym session pool is created with valid userdata
> > size.
> >
> > Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> > ---
> The patch description do not match with the patch.
> I can see that you are changing the cipher algo from AES-CBC to NULL
> Without explaining the reason.
> Could you please clarify the need of this patch.
> 
> Regards,
> Akhil


  reply	other threads:[~2020-09-23  7:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-17  1:14 Abhinandan Gujjar
2020-09-22 19:29 ` Akhil Goyal
2020-09-23  7:10   ` Gujjar, Abhinandan S [this message]
2020-10-06 10:25     ` Gujjar, Abhinandan S
2020-10-09 19:01       ` Akhil Goyal
2020-10-12  6:24         ` Gujjar, Abhinandan S
2020-10-12 19:29           ` Akhil Goyal
  -- strict thread matches above, loose matches on Subject: below --
2020-09-17  0:57 Abhinandan Gujjar
2020-09-18 10:08 ` Gujjar, Abhinandan S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN6PR11MB1827758C02A63FED478A5F12E8380@BN6PR11MB1827.namprd11.prod.outlook.com \
    --to=abhinandan.gujjar@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=narender.vangati@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git