From: Akhil Goyal <akhil.goyal@nxp.com>
To: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"jerinj@marvell.com" <jerinj@marvell.com>
Cc: "Vangati, Narender" <narender.vangati@intel.com>
Subject: Re: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue
Date: Fri, 9 Oct 2020 19:01:54 +0000 [thread overview]
Message-ID: <VI1PR04MB31680492B8A5C07A6250F2C7E6080@VI1PR04MB3168.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <MWHPR11MB183855357AA7A04CB6CB33A7E80D0@MWHPR11MB1838.namprd11.prod.outlook.com>
Hi Abhinandan,
> Hi Akhil,
>
> If the patch is ok, could you please ack it?
>
Could you please send the Fixes tag for the original patch which introduced this
Issue? I will add it while applying the patch.
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> >
> > Hi Akhil,
> >
> > Recently, I observed that test was failing with sw adapter.
> > I noticed that, it was because of some changes went in related to crypto in
> > the past releases.
> > One of the tests, configures a session in turn calls
> > null_crypto_set_session_parameters()
> > which checks for params was failing. As part of fixing & updating the xforms
> > to address this issue, thought of getting rid of algo as well, to make the test
> > simpler. The test continues to use null cryptodev and does not deal with any
> > encryption or auth.
> >
> > Regards
> > Abhinandan
> >
> > > -----Original Message-----
> > > From: Akhil Goyal <akhil.goyal@nxp.com>
> > > Sent: Wednesday, September 23, 2020 12:59 AM
> > > To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; dev@dpdk.org;
> > > jerinj@marvell.com
> > > Cc: Vangati, Narender <narender.vangati@intel.com>
> > > Subject: RE: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf
> > > issue
> > >
> > > Hi Abhinandan,
> > >
> > > > This patch updates the xform with right configuration.
> > > > For session based ops, sym session pool is created with valid
> > > > userdata size.
> > > >
> > > > Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> > > > ---
> > > The patch description do not match with the patch.
> > > I can see that you are changing the cipher algo from AES-CBC to NULL
> > > Without explaining the reason.
> > > Could you please clarify the need of this patch.
> > >
> > > Regards,
> > > Akhil
next prev parent reply other threads:[~2020-10-09 19:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 1:14 Abhinandan Gujjar
2020-09-22 19:29 ` Akhil Goyal
2020-09-23 7:10 ` Gujjar, Abhinandan S
2020-10-06 10:25 ` Gujjar, Abhinandan S
2020-10-09 19:01 ` Akhil Goyal [this message]
2020-10-12 6:24 ` Gujjar, Abhinandan S
2020-10-12 19:29 ` Akhil Goyal
-- strict thread matches above, loose matches on Subject: below --
2020-09-17 0:57 Abhinandan Gujjar
2020-09-18 10:08 ` Gujjar, Abhinandan S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB31680492B8A5C07A6250F2C7E6080@VI1PR04MB3168.eurprd04.prod.outlook.com \
--to=akhil.goyal@nxp.com \
--cc=abhinandan.gujjar@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=narender.vangati@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).