DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
To: "dev@dpdk.org" <dev@dpdk.org>, "jerinj@marvell.com" <jerinj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue
Date: Fri, 18 Sep 2020 10:08:12 +0000
Message-ID: <MWHPR11MB183848F2D4CB473A56E64E5DE83F0@MWHPR11MB1838.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1600304278-77684-1-git-send-email-abhinandan.gujjar@intel.com>

Please disregard the patch. Didn't realizes commented changes for meson.

> -----Original Message-----
> From: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> Sent: Thursday, September 17, 2020 6:28 AM
> To: dev@dpdk.org; jerinj@marvell.com
> Cc: Vangati, Narender <narender.vangati@intel.com>; Gujjar, Abhinandan S
> <abhinandan.gujjar@intel.com>
> Subject: [PATCH] test/event_crypto_adapter: fix conf issue
> 
> This patch updates the xform with right configuration.
> For session based ops, sym session pool is created with valid userdata size.
> 
> Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> 
> ---
>  app/test/test_event_crypto_adapter.c | 24 +++++-------------------
>  drivers/crypto/meson.build           | 12 ++++++------
>  2 files changed, 11 insertions(+), 25 deletions(-)
> 
> diff --git a/app/test/test_event_crypto_adapter.c
> b/app/test/test_event_crypto_adapter.c
> index 8d42462..530ce96 100644
> --- a/app/test/test_event_crypto_adapter.c
> +++ b/app/test/test_event_crypto_adapter.c
> @@ -171,7 +171,6 @@ struct rte_event_crypto_request request_info = {
>  	struct rte_event ev;
>  	uint32_t cap;
>  	int ret;
> -	uint8_t cipher_key[17];
> 
>  	memset(&m_data, 0, sizeof(m_data));
> 
> @@ -183,14 +182,7 @@ struct rte_event_crypto_request request_info = {
>  	/* Setup Cipher Parameters */
>  	cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
>  	cipher_xform.next = NULL;
> -
> -	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
> -	cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
> -
> -	cipher_xform.cipher.key.data = cipher_key;
> -	cipher_xform.cipher.key.length = 16;
> -	cipher_xform.cipher.iv.offset = IV_OFFSET;
> -	cipher_xform.cipher.iv.length = 16;
> +	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
> 
>  	op = rte_crypto_op_alloc(params.op_mpool,
>  			RTE_CRYPTO_OP_TYPE_SYMMETRIC);
> @@ -378,7 +370,6 @@ struct rte_event_crypto_request request_info = {
>  	struct rte_mbuf *m;
>  	uint32_t cap;
>  	int ret;
> -	uint8_t cipher_key[17];
> 
>  	memset(&m_data, 0, sizeof(m_data));
> 
> @@ -390,14 +381,7 @@ struct rte_event_crypto_request request_info = {
>  	/* Setup Cipher Parameters */
>  	cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
>  	cipher_xform.next = NULL;
> -
> -	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
> -	cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
> -
> -	cipher_xform.cipher.key.data = cipher_key;
> -	cipher_xform.cipher.key.length = 16;
> -	cipher_xform.cipher.iv.offset = IV_OFFSET;
> -	cipher_xform.cipher.iv.length = 16;
> +	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
> 
>  	op = rte_crypto_op_alloc(params.op_mpool,
>  			RTE_CRYPTO_OP_TYPE_SYMMETRIC);
> @@ -564,7 +548,9 @@ struct rte_event_crypto_request request_info = {
> 
>  	params.session_mpool = rte_cryptodev_sym_session_pool_create(
>  			"CRYPTO_ADAPTER_SESSION_MP",
> -			MAX_NB_SESSIONS, 0, 0, 0, SOCKET_ID_ANY);
> +			MAX_NB_SESSIONS, 0, 0,
> +			sizeof(union rte_event_crypto_metadata),
> +			SOCKET_ID_ANY);
>  	TEST_ASSERT_NOT_NULL(params.session_mpool,
>  			"session mempool allocation failed\n");
> 
> diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build index
> a242350..149a8e1 100644
> --- a/drivers/crypto/meson.build
> +++ b/drivers/crypto/meson.build
> @@ -5,14 +5,14 @@ if is_windows
>  	subdir_done()
>  endif
> 
> -drivers = ['aesni_gcm',
> -	   'aesni_mb',
> +drivers = [#'aesni_gcm',
> +	   #'aesni_mb',
>  	   'armv8',
>  	   'caam_jr',
>  	   'ccp',
>  	   'dpaa_sec',
>  	   'dpaa2_sec',
> -	   'kasumi',
> +	  # 'kasumi',
>  	   'mvsam',
>  	   'nitrox',
>  	   'null',
> @@ -21,9 +21,9 @@ drivers = ['aesni_gcm',
>  	   'openssl',
>  	   'qat',
>  	   'scheduler',
> -	   'snow3g',
> -	   'virtio',
> -	   'zuc']
> +	   #'snow3g',
> +	   'virtio']
> +	   #'zuc']
> 
>  std_deps = ['cryptodev'] # cryptodev pulls in all other needed deps
> config_flag_fmt = 'RTE_LIBRTE_@0@_PMD'
> --
> 1.9.1


  reply	other threads:[~2020-09-18 10:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-17  0:57 Abhinandan Gujjar
2020-09-18 10:08 ` Gujjar, Abhinandan S [this message]
2020-09-17  1:14 Abhinandan Gujjar
2020-09-22 19:29 ` Akhil Goyal
2020-09-23  7:10   ` Gujjar, Abhinandan S
2020-10-06 10:25     ` Gujjar, Abhinandan S
2020-10-09 19:01       ` Akhil Goyal
2020-10-12  6:24         ` Gujjar, Abhinandan S
2020-10-12 19:29           ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR11MB183848F2D4CB473A56E64E5DE83F0@MWHPR11MB1838.namprd11.prod.outlook.com \
    --to=abhinandan.gujjar@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git