DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH v2] doc: announce changes in bbdev related to enum extension
@ 2022-03-17 18:37 Nicolas Chautru
  2022-03-17 18:37 ` Nicolas Chautru
  0 siblings, 1 reply; 13+ messages in thread
From: Nicolas Chautru @ 2022-03-17 18:37 UTC (permalink / raw)
  To: dev, gakhil, thomas
  Cc: trix, ray.kinsella, bruce.richardson, hemant.agrawal,
	mingshan.zhang, david.marchand, stephen, Nicolas Chautru

v2: indentation fix

Realizing when submitting new bbdev operation in this patch
(https://patchwork.dpdk.org/project/dpdk/list/?series=22111) that this is not workable in practice to extend this API into 22.07 without fundamental ABI breakage even by using existing versionning framework.
Some existing learnings to be applied here to prevent extension being blocked, hence accouncing changes in bbdev intended for 22.11 to make this more future-proof, including dropping max value from enum, as well as deferring extension of the API for FFT operation into DPDK 22.11.

Let me know if any comments or in case this should be captured differently.
Thanks
Nic


Nicolas Chautru (1):
  doc: announce changes in bbdev related to enum extension

 doc/guides/rel_notes/deprecation.rst | 8 ++++++++
 1 file changed, 8 insertions(+)

-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v2] doc: announce changes in bbdev related to enum extension
  2022-03-17 18:37 [PATCH v2] doc: announce changes in bbdev related to enum extension Nicolas Chautru
@ 2022-03-17 18:37 ` Nicolas Chautru
  2022-06-09  0:20   ` [PATCH v3] " Nicolas Chautru
  2022-06-09  0:34   ` [PATCH v4] " Nicolas Chautru
  0 siblings, 2 replies; 13+ messages in thread
From: Nicolas Chautru @ 2022-03-17 18:37 UTC (permalink / raw)
  To: dev, gakhil, thomas
  Cc: trix, ray.kinsella, bruce.richardson, hemant.agrawal,
	mingshan.zhang, david.marchand, stephen, Nicolas Chautru

Intent to resolve in DPDK 22.11 historical usage which prevents
graceful extension of enum and API without troublesome ABI breakage
as well as extending API RTE_BBDEV_OP_FFT for new operation type
in bbdev.

Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 4e5b23c..ff161c5 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -112,6 +112,14 @@ Deprecation Notices
   session and the private data of session. An opaque pointer can be exposed
   directly to application which can be attached to the ``rte_crypto_op``.
 
+* bbdev: Will fix extending some enum breaking the ABI. Notably
+  deprecating ``RTE_BBDEV_OP_TYPE_COUNT`` terminating the ``rte_bbdev_op_type``
+  and use fixed array size when required to allow for future enum extension.
+  Will also remove some of the inlining when causing ABI future-proof concerns.
+  Will extend API to support new operation type ``RTE_BBDEV_OP_FFT`` as per this
+  RFC https://patchwork.dpdk.org/project/dpdk/list/?series=22111
+  This should be updated in DPDK 22.11.
+
 * security: Hide structure ``rte_security_session`` and expose an opaque
   pointer for the private data to the application which can be attached
   to the packet while enqueuing.
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v3] doc: announce changes in bbdev related to enum extension
  2022-03-17 18:37 ` Nicolas Chautru
@ 2022-06-09  0:20   ` Nicolas Chautru
  2022-06-09  0:20     ` Nicolas Chautru
  2022-06-09  0:34   ` [PATCH v4] " Nicolas Chautru
  1 sibling, 1 reply; 13+ messages in thread
From: Nicolas Chautru @ 2022-06-09  0:20 UTC (permalink / raw)
  To: dev, gakhil, thomas, maxime.coquelin
  Cc: trix, ray.kinsella, bruce.richardson, hemant.agrawal,
	david.marchand, stephen, Nicolas Chautru

v3: being more explicit wrt the list of intended changes for 22.11
v2: indentation fix

Realizing when submitting new bbdev operation in this patch
(https://patchwork.dpdk.org/project/dpdk/list/?series=22111) that this is not workable in practice to extend this API into 22.07 without fundamental ABI breakage even by using existing versionning framework.
Some existing learnings to be applied here to prevent extension being blocked, hence accouncing changes in bbdev intended for 22.11 to make this more future-proof, including dropping max value from enum, as well as deferring extension of the API for FFT operation into DPDK 22.11.

Let me know if any comments or in case this should be captured differently.
Thanks
Nic


Nicolas Chautru (1):
  doc: announce changes in bbdev related to enum extension

 doc/guides/rel_notes/deprecation.rst | 10 ++++++++++
 1 file changed, 10 insertions(+)

-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v3] doc: announce changes in bbdev related to enum extension
  2022-06-09  0:20   ` [PATCH v3] " Nicolas Chautru
@ 2022-06-09  0:20     ` Nicolas Chautru
  0 siblings, 0 replies; 13+ messages in thread
From: Nicolas Chautru @ 2022-06-09  0:20 UTC (permalink / raw)
  To: dev, gakhil, thomas, maxime.coquelin
  Cc: trix, ray.kinsella, bruce.richardson, hemant.agrawal,
	david.marchand, stephen, Nicolas Chautru

Intent to resolve in DPDK 22.11 historical usage which prevents
graceful extension of enum and API without troublesome ABI breakage
as well as extending API RTE_BBDEV_OP_FFT for new operation type
in bbdev as well as other new members in existing structures.

Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 4e5b23c..c75f43e 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -112,6 +112,16 @@ Deprecation Notices
   session and the private data of session. An opaque pointer can be exposed
   directly to application which can be attached to the ``rte_crypto_op``.
 
+* bbdev: Will be deprecating ``RTE_BBDEV_OP_TYPE_COUNT`` terminating the ``rte_bbdev_op_type``
+  and use fixed array size when required to allow for future enum extension.
+  Will extend API to support new operation type ``RTE_BBDEV_OP_FFT`` as per this
+  RFC https://patchwork.dpdk.org/project/dpdk/list/?series=22111 
+  Will be adding new members in ``rte_bbdev_driver_info`` to expose PMD queue topology inspired
+  by this RFC https://patches.dpdk.org/project/dpdk/list/?series=22076
+  Will be adding new member in ``rte_bbdev_driver_info`` to expose the device status as per
+  this RFC https://patches.dpdk.org/project/dpdk/list/?series=23367
+  This should be updated in DPDK 22.11.
+
 * security: Hide structure ``rte_security_session`` and expose an opaque
   pointer for the private data to the application which can be attached
   to the packet while enqueuing.
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v4] doc: announce changes in bbdev related to enum extension
  2022-03-17 18:37 ` Nicolas Chautru
  2022-06-09  0:20   ` [PATCH v3] " Nicolas Chautru
@ 2022-06-09  0:34   ` Nicolas Chautru
  2022-06-09  0:34     ` Nicolas Chautru
  1 sibling, 1 reply; 13+ messages in thread
From: Nicolas Chautru @ 2022-06-09  0:34 UTC (permalink / raw)
  To: dev, gakhil, thomas, maxime.coquelin
  Cc: trix, ray.kinsella, bruce.richardson, hemant.agrawal,
	david.marchand, stephen, Nicolas Chautru

v4: correcting typo. Hemant, Maxime kindly review/ack.
v3: being more explicit wrt the list of intended changes for 22.11
v2: indentation fix

Realizing when submitting new bbdev operation in this patch
(https://patchwork.dpdk.org/project/dpdk/list/?series=22111) that this is not workable in practice to extend this API into 22.07 without fundamental ABI breakage even by using existing versionning framework.
Some existing learnings to be applied here to prevent extension being blocked, hence accouncing changes in bbdev intended for 22.11 to make this more future-proof, including dropping max value from enum, as well as deferring extension of the API for FFT operation into DPDK 22.11.

Let me know if any comments or in case this should be captured differently.
Thanks
Nic


Nicolas Chautru (1):
  doc: announce changes in bbdev related to enum extension

 doc/guides/rel_notes/deprecation.rst | 11 +++++++++++
 1 file changed, 11 insertions(+)

-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v4] doc: announce changes in bbdev related to enum extension
  2022-06-09  0:34   ` [PATCH v4] " Nicolas Chautru
@ 2022-06-09  0:34     ` Nicolas Chautru
  2022-06-09  5:14       ` Hemant Agrawal
                         ` (3 more replies)
  0 siblings, 4 replies; 13+ messages in thread
From: Nicolas Chautru @ 2022-06-09  0:34 UTC (permalink / raw)
  To: dev, gakhil, thomas, maxime.coquelin
  Cc: trix, ray.kinsella, bruce.richardson, hemant.agrawal,
	david.marchand, stephen, Nicolas Chautru

Intent to resolve in DPDK 22.11 historical usage which prevents
graceful extension of enum and API without troublesome ABI breakage
as well as extending API RTE_BBDEV_OP_FFT for new operation type
in bbdev as well as other new members in existing structures.

Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 4e5b23c..c8ab1ec 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -112,6 +112,17 @@ Deprecation Notices
   session and the private data of session. An opaque pointer can be exposed
   directly to application which can be attached to the ``rte_crypto_op``.
 
+* bbdev: ``RTE_BBDEV_OP_TYPE_COUNT`` terminating the ``rte_bbdev_op_type``
+  enum will be deprecated and instead use fixed array size when required to allow for
+  future enum extension.
+  Will extend API to support new operation type ``RTE_BBDEV_OP_FFT`` as per this
+  RFC https://patchwork.dpdk.org/project/dpdk/list/?series=22111
+  New members will be added in ``rte_bbdev_driver_info`` to expose PMD queue topology inspired
+  by this RFC https://patches.dpdk.org/project/dpdk/list/?series=22076
+  New member will be added in ``rte_bbdev_driver_info`` to expose the device status as per
+  this RFC https://patches.dpdk.org/project/dpdk/list/?series=23367
+  This should be updated in DPDK 22.11.
+
 * security: Hide structure ``rte_security_session`` and expose an opaque
   pointer for the private data to the application which can be attached
   to the packet while enqueuing.
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 13+ messages in thread

* RE: [PATCH v4] doc: announce changes in bbdev related to enum extension
  2022-06-09  0:34     ` Nicolas Chautru
@ 2022-06-09  5:14       ` Hemant Agrawal
  2022-06-09  7:53       ` Maxime Coquelin
                         ` (2 subsequent siblings)
  3 siblings, 0 replies; 13+ messages in thread
From: Hemant Agrawal @ 2022-06-09  5:14 UTC (permalink / raw)
  To: Nicolas Chautru, dev, gakhil, thomas, maxime.coquelin
  Cc: trix, ray.kinsella, bruce.richardson, david.marchand, stephen



> -----Original Message-----
> From: Nicolas Chautru <nicolas.chautru@intel.com>
> Sent: Thursday, June 9, 2022 6:05 AM
> To: dev@dpdk.org; gakhil@marvell.com; thomas@monjalon.net;
> maxime.coquelin@redhat.com
> Cc: trix@redhat.com; ray.kinsella@intel.com; bruce.richardson@intel.com;
> Hemant Agrawal <hemant.agrawal@nxp.com>;
> david.marchand@redhat.com; stephen@networkplumber.org; Nicolas
> Chautru <nicolas.chautru@intel.com>
> Subject: [PATCH v4] doc: announce changes in bbdev related to enum
> extension
> Importance: High
> 
> Intent to resolve in DPDK 22.11 historical usage which prevents graceful
> extension of enum and API without troublesome ABI breakage as well as
> extending API RTE_BBDEV_OP_FFT for new operation type in bbdev as well
> as other new members in existing structures.
> 
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 4e5b23c..c8ab1ec 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -112,6 +112,17 @@ Deprecation Notices
>    session and the private data of session. An opaque pointer can be exposed
>    directly to application which can be attached to the ``rte_crypto_op``.
> 
> +* bbdev: ``RTE_BBDEV_OP_TYPE_COUNT`` terminating the
> +``rte_bbdev_op_type``
> +  enum will be deprecated and instead use fixed array size when
> +required to allow for
> +  future enum extension.
> +  Will extend API to support new operation type ``RTE_BBDEV_OP_FFT`` as
> +per this
> +  RFC
> +https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> h
> +work.dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D22111&amp;da
> ta=05%7
> +C01%7Chemant.agrawal%40nxp.com%7Ce8c1b946f9ba4152d02d08da49b1
> 5297%7C686
> +ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637903323196944926%7C
> Unknown%7C
> +TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwi
> LCJXVCI
> +6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=zDwsoIF4tF0eP2py43nwUHUz
> pS3XlDTQDiRMd
> +JxBqwg%3D&amp;reserved=0
> +  New members will be added in ``rte_bbdev_driver_info`` to expose PMD
> +queue topology inspired
> +  by this RFC
> +https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> h
> +es.dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D22076&amp;data=
> 05%7C0
> +1%7Chemant.agrawal%40nxp.com%7Ce8c1b946f9ba4152d02d08da49b152
> 97%7C686ea
> +1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637903323196944926%7CUn
> known%7CTW
> +FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJ
> XVCI6M
> +n0%3D%7C3000%7C%7C%7C&amp;sdata=tx8iueWoLEbbCyFQFQHKsvs9nkib
> c0ANem5dyai
> +mspQ%3D&amp;reserved=0
> +  New member will be added in ``rte_bbdev_driver_info`` to expose the
> +device status as per
> +  this RFC
> +https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> h
> +es.dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D23367&amp;data=
> 05%7C0
> +1%7Chemant.agrawal%40nxp.com%7Ce8c1b946f9ba4152d02d08da49b152
> 97%7C686ea
> +1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637903323196944926%7CUn
> known%7CTW
> +FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJ
> XVCI6M
> +n0%3D%7C3000%7C%7C%7C&amp;sdata=rHnuL7B63SoFIIo1M4kdRnnDm0
> xqmCwML8CEo%2
> +BsxDBA%3D&amp;reserved=0
> +  This should be updated in DPDK 22.11.
> +
>  * security: Hide structure ``rte_security_session`` and expose an opaque
>    pointer for the private data to the application which can be attached
>    to the packet while enqueuing.
> 
Acked-by:  Hemant Agrawal <hemant.agrawal@nxp.com>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v4] doc: announce changes in bbdev related to enum extension
  2022-06-09  0:34     ` Nicolas Chautru
  2022-06-09  5:14       ` Hemant Agrawal
@ 2022-06-09  7:53       ` Maxime Coquelin
  2022-06-17 16:13         ` Chautru, Nicolas
  2022-07-05 15:45       ` Bruce Richardson
  2022-07-17  9:48       ` Thomas Monjalon
  3 siblings, 1 reply; 13+ messages in thread
From: Maxime Coquelin @ 2022-06-09  7:53 UTC (permalink / raw)
  To: Nicolas Chautru, dev, gakhil, thomas
  Cc: trix, ray.kinsella, bruce.richardson, hemant.agrawal,
	david.marchand, stephen

Hi Nicolas,

On 6/9/22 02:34, Nicolas Chautru wrote:
> Intent to resolve in DPDK 22.11 historical usage which prevents
> graceful extension of enum and API without troublesome ABI breakage
> as well as extending API RTE_BBDEV_OP_FFT for new operation type
> in bbdev as well as other new members in existing structures.
> 
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
>   doc/guides/rel_notes/deprecation.rst | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 4e5b23c..c8ab1ec 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -112,6 +112,17 @@ Deprecation Notices
>     session and the private data of session. An opaque pointer can be exposed
>     directly to application which can be attached to the ``rte_crypto_op``.
>   
> +* bbdev: ``RTE_BBDEV_OP_TYPE_COUNT`` terminating the ``rte_bbdev_op_type``
> +  enum will be deprecated and instead use fixed array size when required to allow for
> +  future enum extension.
> +  Will extend API to support new operation type ``RTE_BBDEV_OP_FFT`` as per this
> +  RFC https://patchwork.dpdk.org/project/dpdk/list/?series=22111
> +  New members will be added in ``rte_bbdev_driver_info`` to expose PMD queue topology inspired
> +  by this RFC https://patches.dpdk.org/project/dpdk/list/?series=22076
> +  New member will be added in ``rte_bbdev_driver_info`` to expose the device status as per
> +  this RFC https://patches.dpdk.org/project/dpdk/list/?series=23367
> +  This should be updated in DPDK 22.11.
> +
>   * security: Hide structure ``rte_security_session`` and expose an opaque
>     pointer for the private data to the application which can be attached
>     to the packet while enqueuing.

Thanks for rewording the notice.

Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Maxime


^ permalink raw reply	[flat|nested] 13+ messages in thread

* RE: [PATCH v4] doc: announce changes in bbdev related to enum extension
  2022-06-09  7:53       ` Maxime Coquelin
@ 2022-06-17 16:13         ` Chautru, Nicolas
  2022-06-27 20:47           ` Chautru, Nicolas
  0 siblings, 1 reply; 13+ messages in thread
From: Chautru, Nicolas @ 2022-06-17 16:13 UTC (permalink / raw)
  To: dev, thomas
  Cc: trix, Kinsella, Ray, Richardson, Bruce, hemant.agrawal,
	david.marchand, stephen, Maxime Coquelin, gakhil

Hi Thomas, 
Can this one be applied based on your review? 
Thanks
Nic

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Thursday, June 9, 2022 12:54 AM
> To: Chautru, Nicolas <nicolas.chautru@intel.com>; dev@dpdk.org;
> gakhil@marvell.com; thomas@monjalon.net
> Cc: trix@redhat.com; Kinsella, Ray <ray.kinsella@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; hemant.agrawal@nxp.com;
> david.marchand@redhat.com; stephen@networkplumber.org
> Subject: Re: [PATCH v4] doc: announce changes in bbdev related to enum
> extension
> 
> Hi Nicolas,
> 
> On 6/9/22 02:34, Nicolas Chautru wrote:
> > Intent to resolve in DPDK 22.11 historical usage which prevents
> > graceful extension of enum and API without troublesome ABI breakage as
> > well as extending API RTE_BBDEV_OP_FFT for new operation type in bbdev
> > as well as other new members in existing structures.
> >
> > Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> > ---
> >   doc/guides/rel_notes/deprecation.rst | 11 +++++++++++
> >   1 file changed, 11 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index 4e5b23c..c8ab1ec 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -112,6 +112,17 @@ Deprecation Notices
> >     session and the private data of session. An opaque pointer can be exposed
> >     directly to application which can be attached to the ``rte_crypto_op``.
> >
> > +* bbdev: ``RTE_BBDEV_OP_TYPE_COUNT`` terminating the
> > +``rte_bbdev_op_type``
> > +  enum will be deprecated and instead use fixed array size when
> > +required to allow for
> > +  future enum extension.
> > +  Will extend API to support new operation type ``RTE_BBDEV_OP_FFT``
> > +as per this
> > +  RFC https://patchwork.dpdk.org/project/dpdk/list/?series=22111
> > +  New members will be added in ``rte_bbdev_driver_info`` to expose
> > +PMD queue topology inspired
> > +  by this RFC
> > +https://patches.dpdk.org/project/dpdk/list/?series=22076
> > +  New member will be added in ``rte_bbdev_driver_info`` to expose the
> > +device status as per
> > +  this RFC https://patches.dpdk.org/project/dpdk/list/?series=23367
> > +  This should be updated in DPDK 22.11.
> > +
> >   * security: Hide structure ``rte_security_session`` and expose an opaque
> >     pointer for the private data to the application which can be attached
> >     to the packet while enqueuing.
> 
> Thanks for rewording the notice.
> 
> Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> Maxime


^ permalink raw reply	[flat|nested] 13+ messages in thread

* RE: [PATCH v4] doc: announce changes in bbdev related to enum extension
  2022-06-17 16:13         ` Chautru, Nicolas
@ 2022-06-27 20:47           ` Chautru, Nicolas
  2022-06-30 14:52             ` Chautru, Nicolas
  0 siblings, 1 reply; 13+ messages in thread
From: Chautru, Nicolas @ 2022-06-27 20:47 UTC (permalink / raw)
  To: dev, thomas
  Cc: trix, Kinsella, Ray, Richardson, Bruce, hemant.agrawal,
	david.marchand, stephen, Maxime Coquelin, gakhil

Hi Thomas, 
Kind reminder on this one.
Thanks
Nic

> -----Original Message-----
> From: Chautru, Nicolas
> Sent: Friday, June 17, 2022 9:13 AM
> To: dev@dpdk.org; thomas@monjalon.net
> Cc: trix@redhat.com; Kinsella, Ray <ray.kinsella@intel.com>; Richardson,
> Bruce <bruce.richardson@intel.com>; hemant.agrawal@nxp.com;
> david.marchand@redhat.com; stephen@networkplumber.org; Maxime
> Coquelin <maxime.coquelin@redhat.com>; gakhil@marvell.com
> Subject: RE: [PATCH v4] doc: announce changes in bbdev related to enum
> extension
> 
> Hi Thomas,
> Can this one be applied based on your review?
> Thanks
> Nic
> 
> > -----Original Message-----
> > From: Maxime Coquelin <maxime.coquelin@redhat.com>
> > Sent: Thursday, June 9, 2022 12:54 AM
> > To: Chautru, Nicolas <nicolas.chautru@intel.com>; dev@dpdk.org;
> > gakhil@marvell.com; thomas@monjalon.net
> > Cc: trix@redhat.com; Kinsella, Ray <ray.kinsella@intel.com>;
> > Richardson, Bruce <bruce.richardson@intel.com>;
> > hemant.agrawal@nxp.com; david.marchand@redhat.com;
> > stephen@networkplumber.org
> > Subject: Re: [PATCH v4] doc: announce changes in bbdev related to enum
> > extension
> >
> > Hi Nicolas,
> >
> > On 6/9/22 02:34, Nicolas Chautru wrote:
> > > Intent to resolve in DPDK 22.11 historical usage which prevents
> > > graceful extension of enum and API without troublesome ABI breakage
> > > as well as extending API RTE_BBDEV_OP_FFT for new operation type in
> > > bbdev as well as other new members in existing structures.
> > >
> > > Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> > > ---
> > >   doc/guides/rel_notes/deprecation.rst | 11 +++++++++++
> > >   1 file changed, 11 insertions(+)
> > >
> > > diff --git a/doc/guides/rel_notes/deprecation.rst
> > > b/doc/guides/rel_notes/deprecation.rst
> > > index 4e5b23c..c8ab1ec 100644
> > > --- a/doc/guides/rel_notes/deprecation.rst
> > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > @@ -112,6 +112,17 @@ Deprecation Notices
> > >     session and the private data of session. An opaque pointer can be
> exposed
> > >     directly to application which can be attached to the ``rte_crypto_op``.
> > >
> > > +* bbdev: ``RTE_BBDEV_OP_TYPE_COUNT`` terminating the
> > > +``rte_bbdev_op_type``
> > > +  enum will be deprecated and instead use fixed array size when
> > > +required to allow for
> > > +  future enum extension.
> > > +  Will extend API to support new operation type
> > > +``RTE_BBDEV_OP_FFT`` as per this
> > > +  RFC https://patchwork.dpdk.org/project/dpdk/list/?series=22111
> > > +  New members will be added in ``rte_bbdev_driver_info`` to expose
> > > +PMD queue topology inspired
> > > +  by this RFC
> > > +https://patches.dpdk.org/project/dpdk/list/?series=22076
> > > +  New member will be added in ``rte_bbdev_driver_info`` to expose
> > > +the device status as per
> > > +  this RFC https://patches.dpdk.org/project/dpdk/list/?series=23367
> > > +  This should be updated in DPDK 22.11.
> > > +
> > >   * security: Hide structure ``rte_security_session`` and expose an opaque
> > >     pointer for the private data to the application which can be attached
> > >     to the packet while enqueuing.
> >
> > Thanks for rewording the notice.
> >
> > Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> >
> > Maxime


^ permalink raw reply	[flat|nested] 13+ messages in thread

* RE: [PATCH v4] doc: announce changes in bbdev related to enum extension
  2022-06-27 20:47           ` Chautru, Nicolas
@ 2022-06-30 14:52             ` Chautru, Nicolas
  0 siblings, 0 replies; 13+ messages in thread
From: Chautru, Nicolas @ 2022-06-30 14:52 UTC (permalink / raw)
  To: dev, thomas
  Cc: trix, Kinsella, Ray, Richardson, Bruce, hemant.agrawal,
	david.marchand, stephen, Maxime Coquelin, gakhil, Mcnamara, John

Hi Thomas, 
Any concern with that deprecation notice please?
Thanks
Nic

> -----Original Message-----
> From: Chautru, Nicolas <nicolas.chautru@intel.com>
> Sent: Monday, June 27, 2022 1:48 PM
> To: dev@dpdk.org; thomas@monjalon.net
> Cc: trix@redhat.com; Kinsella, Ray <ray.kinsella@intel.com>; Richardson,
> Bruce <bruce.richardson@intel.com>; hemant.agrawal@nxp.com;
> david.marchand@redhat.com; stephen@networkplumber.org; Maxime
> Coquelin <maxime.coquelin@redhat.com>; gakhil@marvell.com
> Subject: RE: [PATCH v4] doc: announce changes in bbdev related to enum
> extension
> 
> Hi Thomas,
> Kind reminder on this one.
> Thanks
> Nic
> 
> > -----Original Message-----
> > From: Chautru, Nicolas
> > Sent: Friday, June 17, 2022 9:13 AM
> > To: dev@dpdk.org; thomas@monjalon.net
> > Cc: trix@redhat.com; Kinsella, Ray <ray.kinsella@intel.com>;
> > Richardson, Bruce <bruce.richardson@intel.com>;
> > hemant.agrawal@nxp.com; david.marchand@redhat.com;
> > stephen@networkplumber.org; Maxime Coquelin
> > <maxime.coquelin@redhat.com>; gakhil@marvell.com
> > Subject: RE: [PATCH v4] doc: announce changes in bbdev related to enum
> > extension
> >
> > Hi Thomas,
> > Can this one be applied based on your review?
> > Thanks
> > Nic
> >
> > > -----Original Message-----
> > > From: Maxime Coquelin <maxime.coquelin@redhat.com>
> > > Sent: Thursday, June 9, 2022 12:54 AM
> > > To: Chautru, Nicolas <nicolas.chautru@intel.com>; dev@dpdk.org;
> > > gakhil@marvell.com; thomas@monjalon.net
> > > Cc: trix@redhat.com; Kinsella, Ray <ray.kinsella@intel.com>;
> > > Richardson, Bruce <bruce.richardson@intel.com>;
> > > hemant.agrawal@nxp.com; david.marchand@redhat.com;
> > > stephen@networkplumber.org
> > > Subject: Re: [PATCH v4] doc: announce changes in bbdev related to
> > > enum extension
> > >
> > > Hi Nicolas,
> > >
> > > On 6/9/22 02:34, Nicolas Chautru wrote:
> > > > Intent to resolve in DPDK 22.11 historical usage which prevents
> > > > graceful extension of enum and API without troublesome ABI
> > > > breakage as well as extending API RTE_BBDEV_OP_FFT for new
> > > > operation type in bbdev as well as other new members in existing
> structures.
> > > >
> > > > Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> > > > ---
> > > >   doc/guides/rel_notes/deprecation.rst | 11 +++++++++++
> > > >   1 file changed, 11 insertions(+)
> > > >
> > > > diff --git a/doc/guides/rel_notes/deprecation.rst
> > > > b/doc/guides/rel_notes/deprecation.rst
> > > > index 4e5b23c..c8ab1ec 100644
> > > > --- a/doc/guides/rel_notes/deprecation.rst
> > > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > > @@ -112,6 +112,17 @@ Deprecation Notices
> > > >     session and the private data of session. An opaque pointer can
> > > > be
> > exposed
> > > >     directly to application which can be attached to the
> ``rte_crypto_op``.
> > > >
> > > > +* bbdev: ``RTE_BBDEV_OP_TYPE_COUNT`` terminating the
> > > > +``rte_bbdev_op_type``
> > > > +  enum will be deprecated and instead use fixed array size when
> > > > +required to allow for
> > > > +  future enum extension.
> > > > +  Will extend API to support new operation type
> > > > +``RTE_BBDEV_OP_FFT`` as per this
> > > > +  RFC https://patchwork.dpdk.org/project/dpdk/list/?series=22111
> > > > +  New members will be added in ``rte_bbdev_driver_info`` to
> > > > +expose PMD queue topology inspired
> > > > +  by this RFC
> > > > +https://patches.dpdk.org/project/dpdk/list/?series=22076
> > > > +  New member will be added in ``rte_bbdev_driver_info`` to expose
> > > > +the device status as per
> > > > +  this RFC
> > > > +https://patches.dpdk.org/project/dpdk/list/?series=23367
> > > > +  This should be updated in DPDK 22.11.
> > > > +
> > > >   * security: Hide structure ``rte_security_session`` and expose an
> opaque
> > > >     pointer for the private data to the application which can be attached
> > > >     to the packet while enqueuing.
> > >
> > > Thanks for rewording the notice.
> > >
> > > Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> > >
> > > Maxime


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v4] doc: announce changes in bbdev related to enum extension
  2022-06-09  0:34     ` Nicolas Chautru
  2022-06-09  5:14       ` Hemant Agrawal
  2022-06-09  7:53       ` Maxime Coquelin
@ 2022-07-05 15:45       ` Bruce Richardson
  2022-07-17  9:48       ` Thomas Monjalon
  3 siblings, 0 replies; 13+ messages in thread
From: Bruce Richardson @ 2022-07-05 15:45 UTC (permalink / raw)
  To: Nicolas Chautru
  Cc: dev, gakhil, thomas, maxime.coquelin, trix, ray.kinsella,
	hemant.agrawal, david.marchand, stephen

On Wed, Jun 08, 2022 at 05:34:30PM -0700, Nicolas Chautru wrote:
> Intent to resolve in DPDK 22.11 historical usage which prevents
> graceful extension of enum and API without troublesome ABI breakage
> as well as extending API RTE_BBDEV_OP_FFT for new operation type
> in bbdev as well as other new members in existing structures.
> 
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v4] doc: announce changes in bbdev related to enum extension
  2022-06-09  0:34     ` Nicolas Chautru
                         ` (2 preceding siblings ...)
  2022-07-05 15:45       ` Bruce Richardson
@ 2022-07-17  9:48       ` Thomas Monjalon
  3 siblings, 0 replies; 13+ messages in thread
From: Thomas Monjalon @ 2022-07-17  9:48 UTC (permalink / raw)
  To: Nicolas Chautru
  Cc: dev, gakhil, maxime.coquelin, trix, ray.kinsella,
	bruce.richardson, hemant.agrawal, david.marchand, stephen

09/06/2022 02:34, Nicolas Chautru:
> Intent to resolve in DPDK 22.11 historical usage which prevents
> graceful extension of enum and API without troublesome ABI breakage
> as well as extending API RTE_BBDEV_OP_FFT for new operation type
> in bbdev as well as other new members in existing structures.
> 
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>

    Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
    Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
    Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Improved links and applied, thanks.






^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2022-07-17  9:48 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-17 18:37 [PATCH v2] doc: announce changes in bbdev related to enum extension Nicolas Chautru
2022-03-17 18:37 ` Nicolas Chautru
2022-06-09  0:20   ` [PATCH v3] " Nicolas Chautru
2022-06-09  0:20     ` Nicolas Chautru
2022-06-09  0:34   ` [PATCH v4] " Nicolas Chautru
2022-06-09  0:34     ` Nicolas Chautru
2022-06-09  5:14       ` Hemant Agrawal
2022-06-09  7:53       ` Maxime Coquelin
2022-06-17 16:13         ` Chautru, Nicolas
2022-06-27 20:47           ` Chautru, Nicolas
2022-06-30 14:52             ` Chautru, Nicolas
2022-07-05 15:45       ` Bruce Richardson
2022-07-17  9:48       ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).