Re: [dpdk-dev] [PATCH v2 2/2] bus/pci: rename probe/remove operation types

["Xueming(Steven) Li" <xuemingl@nvidia.com>]

>-----Original Message-----
>From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon
>Sent: Monday, April 5, 2021 5:15 PM
>To: dev@dpdk.org
>Subject: [dpdk-dev] [PATCH v2 2/2] bus/pci: rename probe/remove operation types
>
>The names of the prototypes pci_probe_t and pci_remove_t are missing a prefix rte_.
>These function types are simply renamed.
>
>No compatibility break is expected for the applications because it is considered as an internal name in the driver interface.

No long line warning with checkpatch?

Besides this,
Reviewed-by: Xueming Li <xuemingl@nvidia.com>

>
>Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>---
> drivers/bus/pci/rte_bus_pci.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/bus/pci/rte_bus_pci.h b/drivers/bus/pci/rte_bus_pci.h index 3a092bc6d5..64886b4731 100644
>--- a/drivers/bus/pci/rte_bus_pci.h
>+++ b/drivers/bus/pci/rte_bus_pci.h
>@@ -112,12 +112,12 @@ struct rte_pci_device {
> /**
>  * Initialisation function for the driver called during PCI probing.
>  */
>-typedef int (pci_probe_t)(struct rte_pci_driver *, struct rte_pci_device *);
>+typedef int (rte_pci_probe_t)(struct rte_pci_driver *, struct
>+rte_pci_device *);
>
> /**
>  * Uninitialisation function for the driver called during hotplugging.
>  */
>-typedef int (pci_remove_t)(struct rte_pci_device *);
>+typedef int (rte_pci_remove_t)(struct rte_pci_device *);
>
> /**
>  * Driver-specific DMA mapping. After a successful call the device @@ -164,8 +164,8 @@ struct rte_pci_driver {
> 	TAILQ_ENTRY(rte_pci_driver) next;  /**< Next in list. */
> 	struct rte_driver driver;          /**< Inherit core driver. */
> 	struct rte_pci_bus *bus;           /**< PCI bus reference. */
>-	pci_probe_t *probe;                /**< Device Probe function. */
>-	pci_remove_t *remove;              /**< Device Remove function. */
>+	rte_pci_probe_t *probe;            /**< Device probe function. */
>+	rte_pci_remove_t *remove;          /**< Device remove function. */
> 	pci_dma_map_t *dma_map;		   /**< device dma map function. */
> 	pci_dma_unmap_t *dma_unmap;	   /**< device dma unmap function. */
> 	const struct rte_pci_id *id_table; /**< ID table, NULL terminated. */
>--
>2.31.1