* [dpdk-dev] No information about needed pcap version
@ 2014-01-09 11:59 Mats Liljegren
2014-01-09 13:47 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Mats Liljegren @ 2014-01-09 11:59 UTC (permalink / raw)
To: dev
In file lib/librte_pmd_pcap/rte_eth_pcap.h there is a test to see
whether function pcap_sendpacket is a macro or not. If not, send is
not supported using pcap.
My pcap library do have the function, but not defined as a macro.
I'm using libpcap-dev version 1.4.0, but I couldn't find any
information in the manuals what version I need.
Which version do I need to make this work?
Regards
Mats
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] No information about needed pcap version
2014-01-09 11:59 [dpdk-dev] No information about needed pcap version Mats Liljegren
@ 2014-01-09 13:47 ` David Marchand
2014-01-09 13:55 ` Mats Liljegren
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2014-01-09 13:47 UTC (permalink / raw)
To: Mats Liljegren; +Cc: dev
Hello,
Indeed, this check on a define is wrong.
pcap.h does not seem to have information on library version (nor a #define
linked to pcap_sendpacket functionality).
We need to think of a better check but, for now, you can try to #define
PCAP_SEND to 1 in lib/librte_pmd_pcap/rte_eth_pcap.h.
pcap_sendpacket() is undefined for really old versions of libpcap (I think
< 1.0.0).
I suppose we might need something like configure (trying to link against
pcap lib and see if pcap_sendpacket symbol is defined).
Or we can revert 4fc6677d995bb46ddf155ee08a215f41e5ecbfe8 and declare
libpcap < X.X.X unsupported.
--
David Marchand
On Thu, Jan 9, 2014 at 12:59 PM, Mats Liljegren
<liljegren.mats2@gmail.com>wrote:
> In file lib/librte_pmd_pcap/rte_eth_pcap.h there is a test to see
> whether function pcap_sendpacket is a macro or not. If not, send is
> not supported using pcap.
>
> My pcap library do have the function, but not defined as a macro.
>
> I'm using libpcap-dev version 1.4.0, but I couldn't find any
> information in the manuals what version I need.
>
> Which version do I need to make this work?
>
> Regards
> Mats
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] No information about needed pcap version
2014-01-09 13:47 ` David Marchand
@ 2014-01-09 13:55 ` Mats Liljegren
0 siblings, 0 replies; 3+ messages in thread
From: Mats Liljegren @ 2014-01-09 13:55 UTC (permalink / raw)
To: David Marchand; +Cc: dev
You could let PCAP_SEND be always 1 in rte_eth_pcap.h and then
document that for libpcap < 1.0.0 you need to change PCAP_SEND to 0 to
avoid link error for pcap_sendpacket().
Regards
Mats
On Thu, Jan 9, 2014 at 2:47 PM, David Marchand <david.marchand@6wind.com> wrote:
> Hello,
>
> Indeed, this check on a define is wrong.
>
> pcap.h does not seem to have information on library version (nor a #define
> linked to pcap_sendpacket functionality).
>
> We need to think of a better check but, for now, you can try to #define
> PCAP_SEND to 1 in lib/librte_pmd_pcap/rte_eth_pcap.h.
> pcap_sendpacket() is undefined for really old versions of libpcap (I think <
> 1.0.0).
> I suppose we might need something like configure (trying to link against
> pcap lib and see if pcap_sendpacket symbol is defined).
>
> Or we can revert 4fc6677d995bb46ddf155ee08a215f41e5ecbfe8 and declare
> libpcap < X.X.X unsupported.
>
>
> --
> David Marchand
>
>
> On Thu, Jan 9, 2014 at 12:59 PM, Mats Liljegren <liljegren.mats2@gmail.com>
> wrote:
>>
>> In file lib/librte_pmd_pcap/rte_eth_pcap.h there is a test to see
>> whether function pcap_sendpacket is a macro or not. If not, send is
>> not supported using pcap.
>>
>> My pcap library do have the function, but not defined as a macro.
>>
>> I'm using libpcap-dev version 1.4.0, but I couldn't find any
>> information in the manuals what version I need.
>>
>> Which version do I need to make this work?
>>
>> Regards
>> Mats
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-09 13:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-09 11:59 [dpdk-dev] No information about needed pcap version Mats Liljegren
2014-01-09 13:47 ` David Marchand
2014-01-09 13:55 ` Mats Liljegren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).