From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Kalesh A P <kalesh-anakkur.purayil@broadcom.com>
Cc: dpdk-dev <dev@dpdk.org>, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix check for single PF per port
Date: Sun, 2 May 2021 15:33:30 -0700 [thread overview]
Message-ID: <CACZ4nht9DfFi5ZEyf7B=X7PAW81o70d+bFx7RTqrpCkwJPk4iA@mail.gmail.com> (raw)
In-Reply-To: <20210429055300.18326-1-kalesh-anakkur.purayil@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 2082 bytes --]
On Wed, Apr 28, 2021 at 10:31 PM Kalesh A P <
kalesh-anakkur.purayil@broadcom.com> wrote:
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> The check BNXT_SINGLE_PF(bp) returns false for a VF. So there is no
> extra check needed for VF along with BNXT_SINGLE_PF(bp).
>
> Also make error messages more explicit.
>
> Fixes: ff947c6ce15f ("net/bnxt: add check for multi host PF per port")
> Fixes: f86febfb46da ("net/bnxt: support VF")
> Fixes: 3e12fdb78e82 ("net/bnxt: support VLAN pvid")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
>
Patch applied to dpdk-next-net-brcm. Thanks
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c
> b/drivers/net/bnxt/bnxt_ethdev.c
> index f5d2dc8..50cb12d 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -2197,8 +2197,9 @@ static int bnxt_flow_ctrl_set_op(struct rte_eth_dev
> *dev,
> if (rc)
> return rc;
>
> - if (!BNXT_SINGLE_PF(bp) || BNXT_VF(bp)) {
> - PMD_DRV_LOG(ERR, "Flow Control Settings cannot be
> modified\n");
> + if (!BNXT_SINGLE_PF(bp)) {
> + PMD_DRV_LOG(ERR,
> + "Flow Control Settings cannot be modified on
> VF or on shared PF\n");
> return -ENOTSUP;
> }
>
> @@ -2992,9 +2993,8 @@ bnxt_vlan_pvid_set_op(struct rte_eth_dev *dev,
> uint16_t pvid, int on)
> if (rc)
> return rc;
>
> - if (!BNXT_SINGLE_PF(bp) || BNXT_VF(bp)) {
> - PMD_DRV_LOG(ERR,
> - "PVID cannot be modified for this function\n");
> + if (!BNXT_SINGLE_PF(bp)) {
> + PMD_DRV_LOG(ERR, "PVID cannot be modified on VF or on
> shared PF\n");
> return -ENOTSUP;
> }
> bp->vlan = on ? pvid : 0;
> --
> 2.10.1
>
>
prev parent reply other threads:[~2021-05-02 22:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 5:53 Kalesh A P
2021-05-02 22:33 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nht9DfFi5ZEyf7B=X7PAW81o70d+bFx7RTqrpCkwJPk4iA@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).