DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Huisong Li <lihuisong@huawei.com>, dpdk-dev <dev@dpdk.org>,
	 Ferruh Yigit <ferruh.yigit@intel.com>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	 Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Subject: Re: [dpdk-dev] Questions about reporting auto-negotiation capability
Date: Mon, 29 Mar 2021 07:18:29 -0700
Message-ID: <CACZ4nhtj9MpzFjq4J6BvXsF+GypACB-OFSi1Azcdc3bGZB5dQQ@mail.gmail.com> (raw)
In-Reply-To: <7245184.973KLNHvPo@thomas>

[-- Attachment #1: Type: text/plain, Size: 1351 bytes --]

On Mon, Mar 29, 2021 at 12:19 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 29/03/2021 09:03, Thomas Monjalon:
> > 29/03/2021 06:02, Huisong Li:
> > >          'speed_capa' in struct rte_eth_dev_info is defined as follows:
> > >
> > > uint32_t speed_capa;  /**< Supported speeds bitmap (ETH_LINK_SPEED_). */
> > >
> > >
> > >        Most PMD drivers use this field to report the speeds capability
> > > supported by the device to the upper-layer app.
> > >
> > > But it seems that few NICs report their auto-negotiation capability
> > > through this field. If NIC also uses it to report
> > > their auto-negotiation capability through this field, and should set it
> > > to ETH_LINK_SPEED_AUTONEG(0) based on
> > > the definition of ETH_LINK_SPEED_xxx. In this case, it conflicts the
> > > report of the speeds capability .
> > >
> > > I don't know how to correctly report the auto-negotiation capability of
> > > the device. Thanks for your reply.
> >
> > ETH_LINK_SPEED_AUTONEG is not for capabilities.
> > Anyway, if it is set, it changes nothing (0) in the bitmap.
> > I see mlx5 is wrongly using it.
> >
> > speed_capa is only for enumerating speeds.
>
> I see some drivers are advertising ETH_LINK_SPEED_FIXED in speed_capa
> if the device cannot support autonegotiation.
> Should we add a note in doxygen?
I think we should do that.

>
>

  parent reply	other threads:[~2021-03-29 14:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-29  4:02 Huisong Li
2021-03-29  7:03 ` Thomas Monjalon
2021-03-29  7:19   ` Thomas Monjalon
2021-03-29 11:44     ` Huisong Li
2021-03-29 12:05       ` Thomas Monjalon
2021-03-29 14:18     ` Ajit Khaparde [this message]
2021-03-29  7:28 ` [dpdk-dev] [PATCH] drivers/net: remove useless autoneg capability Thomas Monjalon
2021-03-29 14:12   ` Ajit Khaparde
2021-04-01 13:26     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACZ4nhtj9MpzFjq4J6BvXsF+GypACB-OFSi1Azcdc3bGZB5dQQ@mail.gmail.com \
    --to=ajit.khaparde@broadcom.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinj@marvell.com \
    --cc=lihuisong@huawei.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git