From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Kalesh A P <kalesh-anakkur.purayil@broadcom.com>
Cc: dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: remove workaround for default VNIC
Date: Tue, 20 Jul 2021 14:36:16 -0700 [thread overview]
Message-ID: <CACZ4nhvuegsd_ktCoYkexZ8E1zm3-eSh1D+rNG=i2TGKBuwHcQ@mail.gmail.com> (raw)
In-Reply-To: <20210718053059.16194-1-kalesh-anakkur.purayil@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 1705 bytes --]
On Sat, Jul 17, 2021 at 10:10 PM Kalesh A P <
kalesh-anakkur.purayil@broadcom.com> wrote:
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> On older Wh+ firmware versions, HWRM_FUNC_QCFG returns zero
> for the parent default vnic. Commit "3fb93bc7c349" added a
> temporary Wh+-specific workaround in the PMD.
> This has been fixed in latest firmware and hence removing
> the workaround.
>
> Fixes: 3fb93bc7c349 ("net/bnxt: initialize parent PF information")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Reviewed-by: Lance Richardson <lance.richardson@broadcom.com>
>
Patch applied to dpdk-next-net-brcm
> ---
> drivers/net/bnxt/bnxt_hwrm.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
> index e6c46d4..73deb41 100644
> --- a/drivers/net/bnxt/bnxt_hwrm.c
> +++ b/drivers/net/bnxt/bnxt_hwrm.c
> @@ -3390,16 +3390,6 @@ int bnxt_hwrm_parent_pf_qcfg(struct bnxt *bp)
> bp->parent->fid = rte_le_to_cpu_16(resp->fid);
> bp->parent->port_id = rte_le_to_cpu_16(resp->port_id);
>
> - /* FIXME: Temporary workaround - remove when firmware issue is
> fixed. */
> - if (bp->parent->vnic == 0) {
> - PMD_DRV_LOG(DEBUG, "parent VNIC unavailable.\n");
> - /* Use hard-coded values appropriate for current Wh+ fw. */
> - if (bp->parent->fid == 2)
> - bp->parent->vnic = 0x100;
> - else
> - bp->parent->vnic = 1;
> - }
> -
> HWRM_UNLOCK();
>
> return 0;
> --
> 2.10.1
>
>
prev parent reply other threads:[~2021-07-20 21:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-18 5:30 Kalesh A P
2021-07-20 21:36 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhvuegsd_ktCoYkexZ8E1zm3-eSh1D+rNG=i2TGKBuwHcQ@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=kalesh-anakkur.purayil@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).