DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] rte_memcpy.h
@ 2015-04-14 21:25 Ravi Kerur
  0 siblings, 0 replies; only message in thread
From: Ravi Kerur @ 2015-04-14 21:25 UTC (permalink / raw)
  To: dev

DPDK team,

I am looking at rte_memcpy.h implementation and I wasn't sure whether
coding in that file is done for any specific reason. I see superfluous type
casting in functions and instead of using loop for offset changes during
copy, separate invocation (same function) is done repeatedly.

I modified the code to remove unnecessary type casting and used loop for
offset changes. I compared the code generated by gcc (4.8.2) and in both
cases it looked same. In addition, "make test" for memcpy performance gave
similar results. I will send out a patch so you can check the changes I did
and let me know if it is good to make those changes.

Thanks,
Ravi

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-04-14 21:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-14 21:25 [dpdk-dev] rte_memcpy.h Ravi Kerur

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).