DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	 Bruce Richardson <bruce.richardson@intel.com>,
	dpdk stable <stable@dpdk.org>,  Jerin Jacob <jerinj@marvell.com>,
	Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/1] devtools: fix build test config inheritance from env
Date: Thu, 12 Nov 2020 15:36:41 +0100	[thread overview]
Message-ID: <CAJFAV8wJoc2ED6+3RuXLJ+d_qGJUu0YBvs4w6XLj31m_u85W8A@mail.gmail.com> (raw)
In-Reply-To: <20201112142233.1433309-1-thomas@monjalon.net>

On Thu, Nov 12, 2020 at 3:22 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> The variables DPDK_MESON_OPTIONS, PATH, PKG_CONFIG_PATH,
> CPPFLAGS, CFLAGS and LDFLAGS can be customized in the config file
> loaded by devtools/load-devel-config at each build.
> The configuration can be adjusted per target thanks to the value set
> in the DPDK_TARGET variable.
>
> PKG_CONFIG_PATH is specific to each target, so it must be empty
> before configuring each build from the file according to DPDK_TARGET.
> Inheriting a default PKG_CONFIG_PATH for all targets does not make sense
> and is prone to confusion.
>
> DPDK_MESON_OPTIONS might take a global initial value from environment
> to customize a build test from the shell. Example:
>         DPDK_MESON_OPTIONS="b_lto=true"
> Some target-specific options can be added in the configuration file:
>         DPDK_MESON_OPTIONS="$DPDK_MESON_OPTIONS kernel_dir=$MYKERNEL"
>
> Fixes: 272236741258 ("devtools: load target-specific compilation environment")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Tested-by: Jerin Jacob <jerinj@marvell.com>

Acked-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand


      reply	other threads:[~2020-11-12 14:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-09 21:00 [dpdk-dev] [PATCH " Thomas Monjalon
2020-11-10 10:14 ` Bruce Richardson
2020-11-10 10:45   ` Thomas Monjalon
2020-11-10 11:20     ` Bruce Richardson
2020-11-10 14:08       ` Jerin Jacob
2020-11-10 17:18 ` Ferruh Yigit
2020-11-10 17:55   ` Thomas Monjalon
2020-11-10 18:09     ` Ferruh Yigit
2020-11-11  9:18       ` Bruce Richardson
2020-11-11 10:37         ` Thomas Monjalon
2020-11-11 11:00           ` Bruce Richardson
2020-11-11 11:13             ` Ferruh Yigit
2020-11-11 11:18               ` Thomas Monjalon
2020-11-12 14:22 ` [dpdk-dev] [PATCH v2 " Thomas Monjalon
2020-11-12 14:36   ` David Marchand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8wJoc2ED6+3RuXLJ+d_qGJUu0YBvs4w6XLj31m_u85W8A@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=bluca@debian.org \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinj@marvell.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).