DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dpdk-dev <dev@dpdk.org>,
	 Ferruh Yigit <ferruh.yigit@intel.com>,
	David Marchand <david.marchand@redhat.com>,
	 dpdk stable <stable@dpdk.org>, Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-dev] [PATCH 1/1] devtools: fix build test config inheritance from env
Date: Tue, 10 Nov 2020 19:38:03 +0530	[thread overview]
Message-ID: <CALBAE1MTyQuEQ1Sz3AcS6sLEGGGTdR1bV6d6MWLJgZEk=iEFcQ@mail.gmail.com> (raw)
In-Reply-To: <20201110112044.GD1641@bricha3-MOBL.ger.corp.intel.com>

On Tue, Nov 10, 2020 at 4:51 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Tue, Nov 10, 2020 at 11:45:52AM +0100, Thomas Monjalon wrote:
> > 10/11/2020 11:14, Bruce Richardson:
> > > On Mon, Nov 09, 2020 at 10:00:08PM +0100, Thomas Monjalon wrote:
> > > > PKG_CONFIG_PATH is specific to each target, so it must be empty
> > > > before configuring each build from the file according to DPDK_TARGET.
> > > > Inheriting a default PKG_CONFIG_PATH for all targets does not make sense
> > > > and is prone to confusion.
> > > >
> > > > DPDK_MESON_OPTIONS might take a global initial value from environment
> > > > to customize a build test from the shell. Example:
> > > >   DPDK_MESON_OPTIONS="b_lto=true"
> > > > Some target-specific options can be added in the configuration file:
> > > >   DPDK_MESON_OPTIONS="$DPDK_MESON_OPTIONS kernel_dir=$MYKERNEL"
> > > >
> > > > Fixes: 272236741258 ("devtools: load target-specific compilation environment")
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > > > ---
> > >
> > > Patch looks fine, but I think the log (and comments in the code too,
> > > perhaps) should make it clear that the PKG_CONFIG_PATH can be set in the
> > > local config file, to make it available to the script.
> >
> > OK, I'll look at improving the "doc".
> > We could also provide a template for the config file.
> >
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Tested-by: Jerin Jacob <jerinj@marvell.com>



>

  reply	other threads:[~2020-11-10 14:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-09 21:00 Thomas Monjalon
2020-11-10 10:14 ` Bruce Richardson
2020-11-10 10:45   ` Thomas Monjalon
2020-11-10 11:20     ` Bruce Richardson
2020-11-10 14:08       ` Jerin Jacob [this message]
2020-11-10 17:18 ` Ferruh Yigit
2020-11-10 17:55   ` Thomas Monjalon
2020-11-10 18:09     ` Ferruh Yigit
2020-11-11  9:18       ` Bruce Richardson
2020-11-11 10:37         ` Thomas Monjalon
2020-11-11 11:00           ` Bruce Richardson
2020-11-11 11:13             ` Ferruh Yigit
2020-11-11 11:18               ` Thomas Monjalon
2020-11-12 14:22 ` [dpdk-dev] [PATCH v2 " Thomas Monjalon
2020-11-12 14:36   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALBAE1MTyQuEQ1Sz3AcS6sLEGGGTdR1bV6d6MWLJgZEk=iEFcQ@mail.gmail.com' \
    --to=jerinjacobk@gmail.com \
    --cc=bluca@debian.org \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).