From: David Marchand <david.marchand@redhat.com>
To: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Cc: dev <dev@dpdk.org>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Gaetan Rivet <grive@u256.net>
Subject: Re: [dpdk-dev] [PATCH] pci: properly parse 32-bit domain numbers
Date: Tue, 19 May 2020 11:15:03 +0200 [thread overview]
Message-ID: <CAJFAV8xZz=b8EwqmbgyByPfrSXcEpM-Az7CEjDiERFJkta-5tQ@mail.gmail.com> (raw)
In-Reply-To: <20200512133057.106374-1-dariusz.stojaczyk@intel.com>
On Tue, May 12, 2020 at 3:31 PM Darek Stojaczyk
<dariusz.stojaczyk@intel.com> wrote:
>
> The parsing code was bailing on domains greater than UINT16_MAX,
> but domain numbers like that are still valid and present on some systems.
> One example is Intel VMD (Volume Management Device), which acts somewhat
> as a software-managed PCI switch and its upstream linux driver assigns
> all downstream devices a PCI domain of 0x10000.
>
> Parsing a BDF like 10000:01:00.0 was failing before. To fix it, increase
> the upper limit of domain number to UINT32_MAX. This matches the size of
> struct rte_pci_addr->domain (uint32).
Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org
> Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Acked-by: Gaetan Rivet <grive@u256.net>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2020-05-19 9:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 13:30 Darek Stojaczyk
2020-05-12 15:08 ` Burakov, Anatoly
2020-05-12 18:16 ` Stephen Hemminger
2020-05-13 9:04 ` Gaëtan Rivet
2020-05-13 12:20 ` Stojaczyk, Dariusz
2020-05-19 9:15 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xZz=b8EwqmbgyByPfrSXcEpM-Az7CEjDiERFJkta-5tQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=dariusz.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=grive@u256.net \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).