DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Takeshi T Yoshimura <TYOS@jp.ibm.com>
Cc: dev <dev@dpdk.org>, David Christensen <drc@linux.vnet.ibm.com>
Subject: Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in ppc
Date: Wed, 31 Jul 2019 21:44:56 +0200	[thread overview]
Message-ID: <CAJFAV8xp7T+Y_9JM29VtezRXM=jgbtigkVhvy=hewy=MCLOuRA@mail.gmail.com> (raw)
In-Reply-To: <OF6FEB6022.2D33273A-ON00258448.003A6495-00258448.003AFACA@notes.na.collabserv.com>

On Wed, Jul 31, 2019 at 12:44 PM Takeshi T Yoshimura <TYOS@jp.ibm.com> wrote:
>
> -----David Marchand <david.marchand@redhat.com> wrote: -----
>
> >To: Takeshi Yoshimura <tyos@jp.ibm.com>
> >From: David Marchand <david.marchand@redhat.com>
> >Date: 07/31/2019 06:29PM
> >Cc: dev <dev@dpdk.org>
> >Subject: [EXTERNAL] Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in
> >ppc
> >
> >On Wed, Jul 31, 2019 at 5:36 AM Takeshi Yoshimura <tyos@jp.ibm.com>
> >wrote:
> >>
> >> Commit b76fafb174d2 ("eal: fix IOVA mode selection as VA for PCI
> >> drivers") breaks ppc apps with no IOVA configs (or RTE_IOVA_DC)
> >> because of the inconsistency of user's request and the result of
> >> device capability for IOVA mode. I updated the code to force IOVA
> >as
> >> PA in ppc as before because current ppc driver does not support VA
> >> mode.
> >
> >What is the "ppc driver" you are referring to?
> >Do you mean the vfio implementation for ppc?
> >
> >>
> >> Theoretically, ppc can support VA mode, but I suspect that ppc with
> >> VA mode may have performance issues to create a big DMA window
> >> (VA often uses higher addresses than PA). So, I didn't change the
> >> code to check device capability in ppc.
> >
> >Sorry, I am confused.
> >Is VA mode not working at all? or is it a performance issue?
> >
> >
> >--
> >David Marchand
> >
> >
>
> Ah, I overlooked your first question. The "ppc driver" is in
> drivers/bus/pci/linux/pci.c. In pci.c, pci_one_device_iommu_support_va()
> always returns false in ppc. so, the driver does not allow VA mode in ppc.
>
> This return value is passed to rte_pci_probe_one_driver()
> in drivers/bus/pci/pci_common.c. And the error log appeared like:
>
> EAL: PCI device 0000:01:00.0 on NUMA socket 0
> EAL:   probe driver: 144d:a822 spdk_nvme
> EAL:   Expecting 'PA' IOVA mode but current mode is 'VA', not initializing

Can you confirm on which kernel driver this device was bound ?
I'd like to be sure this is the same issue than David.


-- 
David Marchand

  parent reply	other threads:[~2019-07-31 19:45 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-31  3:35 Takeshi Yoshimura
2019-07-31  9:10 ` Burakov, Anatoly
2019-07-31  9:29 ` David Marchand
2019-07-31 10:34 ` Takeshi T Yoshimura
2019-07-31 10:44 ` Takeshi T Yoshimura
2019-07-31 10:58   ` David Marchand
2019-07-31 19:23     ` David Christensen
2019-07-31 19:32       ` David Marchand
2019-07-31 21:20         ` David Christensen
2019-08-01  5:04           ` David Marchand
2019-07-31 19:44   ` David Marchand [this message]
2019-08-01  4:10   ` Takeshi T Yoshimura
2019-08-01  5:01     ` David Marchand
2019-08-01  5:25     ` Takeshi T Yoshimura
2019-08-01  7:15       ` David Marchand
2019-08-01  8:46       ` Takeshi T Yoshimura
2019-08-01  9:46         ` David Marchand
2019-08-02  8:09         ` Takeshi T Yoshimura
2019-08-02  8:22           ` David Marchand
2019-08-01  4:12   ` Takeshi T Yoshimura
2019-08-01 13:01 ` David Marchand
2019-08-02  8:50   ` Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8xp7T+Y_9JM29VtezRXM=jgbtigkVhvy=hewy=MCLOuRA@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=TYOS@jp.ibm.com \
    --cc=dev@dpdk.org \
    --cc=drc@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).