DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Steven Lariau <steven.lariau@arm.com>
Cc: dev <dev@dpdk.org>, nd <nd@arm.com>,
	Gage Eads <gage.eads@intel.com>,
	 Dharmik Thakkar <Dharmik.Thakkar@arm.com>,
	 "Ruifeng Wang (Arm Technology China)" <ruifeng.wang@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/4] test/stack: improve multithreaded test
Date: Wed, 30 Sep 2020 21:12:47 +0200	[thread overview]
Message-ID: <CAJFAV8yD373kiM3_BwjvwGFH1Mfra=erZ-_jtiBDMP9A1VZ-2w@mail.gmail.com> (raw)
In-Reply-To: <20200812191847.16529-1-steven.lariau@arm.com>

On Wed, Aug 12, 2020 at 9:20 PM Steven Lariau <steven.lariau@arm.com> wrote:
>
> The current multithread DPDK stack test is using atomics operations to
> share information between threads.
> The lockfree stack implementation also uses atomic operations.
> This is an issue for testing. The atomics operations for the test may
> add some extra synchronization to the stack implementation,
> that doesn't exist.
> It makes it harder to find bugs related to memory orderings and data
> races. The main goal of the patch is to remove all atomics operations
> and any other form of data sharing in this test, to make sure that
> most of the execution time is spent on the stack library.
>
> Furthermore, this patch uses more appropriate functions to start /
> wait cores in order to simplify the code.
> The patch also adds code to propagate errors on any slave core to the
> master.
>
> v2: replace stack variable for arguments with a global variable.
>
> Steven Lariau (4):
>   test/stack: avoid trivial memory allocations
>   test/stack: launch tests with mp remote launch API
>   test/stack: propagate errors to main core
>   test/stack: remove atomics operations
>
>  app/test/test_stack.c | 80 +++++++++----------------------------------
>  1 file changed, 17 insertions(+), 63 deletions(-)
>

Series applied, thanks Steven.


-- 
David Marchand


      parent reply	other threads:[~2020-09-30 19:13 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-05 15:57 [dpdk-dev] [PATCH " Steven Lariau
2020-08-05 15:57 ` [dpdk-dev] [PATCH 1/4] test/stack: avoid trivial memory allocations Steven Lariau
2020-08-11 20:13   ` Eads, Gage
2020-08-11 20:38     ` Stephen Hemminger
2020-08-11 20:49       ` Honnappa Nagarahalli
2020-08-11 21:14         ` Eads, Gage
2020-08-05 15:57 ` [dpdk-dev] [PATCH 2/4] test/stack: launch tests with mp remote launch API Steven Lariau
2020-08-11 20:13   ` Eads, Gage
2020-08-05 15:57 ` [dpdk-dev] [PATCH 3/4] test/stack: propagate errors to main core Steven Lariau
2020-08-11 20:13   ` Eads, Gage
2020-08-05 15:57 ` [dpdk-dev] [PATCH 4/4] test/stack: remove atomics operations Steven Lariau
2020-08-11 20:13   ` Eads, Gage
2020-08-12 19:18 ` [dpdk-dev] [PATCH v2 0/4] test/stack: improve multithreaded test Steven Lariau
2020-08-12 19:18   ` [dpdk-dev] [PATCH v2 1/4] test/stack: avoid trivial memory allocations Steven Lariau
2020-08-13 21:38     ` Eads, Gage
2020-08-12 19:18   ` [dpdk-dev] [PATCH v2 2/4] test/stack: launch tests with mp remote launch API Steven Lariau
2020-08-12 19:18   ` [dpdk-dev] [PATCH v2 3/4] test/stack: propagate errors to main core Steven Lariau
2020-08-12 19:18   ` [dpdk-dev] [PATCH v2 4/4] test/stack: remove atomics operations Steven Lariau
2020-09-30 19:12   ` David Marchand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8yD373kiM3_BwjvwGFH1Mfra=erZ-_jtiBDMP9A1VZ-2w@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=Dharmik.Thakkar@arm.com \
    --cc=dev@dpdk.org \
    --cc=gage.eads@intel.com \
    --cc=nd@arm.com \
    --cc=ruifeng.wang@arm.com \
    --cc=steven.lariau@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).