DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v5 0/1] eal/interrupts: add synchronous wrapper around unregister
@ 2021-04-06 14:46 Renata Saiakhova
  2021-04-06 14:46 ` [dpdk-dev] [PATCH v5 1/1] " Renata Saiakhova
  0 siblings, 1 reply; 3+ messages in thread
From: Renata Saiakhova @ 2021-04-06 14:46 UTC (permalink / raw)
  Cc: dev, Renata Saiakhova

For pci_vfio, while removing the device by rte_dev_remove(),
pci_vfio_disable_notifier() will call rte_intr_callback_unregister(),
which may return -EAGAIN, if an interrupt source (kernel) has some active
callbacks right now. As a result, the callback (req notifier) can be never unregistered,
and the corresponding descriptor (vfio_req_intr_handle.fd) can be never closed.
The kernel will continuously try to notify the user space using req notifier, but as
the device is already removed, in this case it even cannot find a bus for that
device, the log is full of messages "EAL: Cannot find bus for device (XX:XX.X)"

v5:
  Re-spin with windows update and 21.05 edition
v4:
* Typo spelling in commit message
v3:
* Subject line reworded
v2:
* Use only for pci-vfio in pci_vfio_disable_notifier()

Renata Saiakhova (1):
  eal/interrupts: add synchronous wrapper around unregister

 drivers/bus/pci/linux/pci_vfio.c        |  2 +-
 lib/librte_eal/freebsd/eal_interrupts.c | 12 ++++++++++++
 lib/librte_eal/include/rte_interrupts.h | 25 +++++++++++++++++++++++++
 lib/librte_eal/linux/eal_interrupts.c   | 12 ++++++++++++
 lib/librte_eal/version.map              |  1 +
 lib/librte_eal/windows/eal_interrupts.c |  8 ++++++++
 6 files changed, 59 insertions(+), 1 deletion(-)

-- 
2.17.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-04-07  9:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-06 14:46 [dpdk-dev] [PATCH v5 0/1] eal/interrupts: add synchronous wrapper around unregister Renata Saiakhova
2021-04-06 14:46 ` [dpdk-dev] [PATCH v5 1/1] " Renata Saiakhova
2021-04-07  9:12   ` David Marchand

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git